Do I need to call MemoryStream.Close ?

[Oleg Subachev]

I use local to methods MemoryStreams.
Both read-only and read-write ones.

Do I need to call MemoryStream.Close for read-only MemoryStreams before
leaving the method ?

And what about read-write MemoryStreams ?
--
Best regards,

Oleg Subachev
su******@ural.ru

[Josip Habjan]

Hi,

I suggest you to close / dispose your memory stream, and also set memsrm
variable to null..
In some cases if you dont set memsrm to null, it will lock this file and you
could not access it again till you restart your PC.. (maby this happends
only to me).

Regards,
Josip Habjan, Croatia
URL: www.habjansoftware.com

"Oleg Subachev" <ol**@urvb.ru> wrote in message
news:%2****************@TK2MSFTNGP14.phx.gbl...

I use local to methods MemoryStreams.
Both read-only and read-write ones.

Do I need to call MemoryStream.Close for read-only MemoryStreams before
leaving the method ?

And what about read-write MemoryStreams ?
--
Best regards,

Oleg Subachev
su******@ural.ru

[Oleg Subachev]

> I suggest you to close / dispose your memory stream, and also set memsrm

variable to null..
In some cases if you dont set memsrm to null, it will lock this file and you could not access it again till you restart your PC.. (maby this happends
only to me).

My MemoryStreams are not linked with any files.
--
Best regards,

Oleg Subachev
su******@ural.ru

[BravesCharm]

You should not have to set the variable to null. The only thing you
should need to do is call close/dispose. However, it's always a good
idea to set the variable to null so you know not to use it anymore.

[Josip Habjan]

Sorry .. eyes are faster then mind... :o)

Regards,
Josip Habjan, Croatia
URL: www.habjansoftware.com

"Oleg Subachev" <ol**@urvb.ru> wrote in message
news:eg*************@tk2msftngp13.phx.gbl...

I suggest you to close / dispose your memory stream, and also set memsrm
variable to null..
In some cases if you dont set memsrm to null, it will lock this file and

you

could not access it again till you restart your PC.. (maby this happends
only to me).

My MemoryStreams are not linked with any files.
--
Best regards,

Oleg Subachev
su******@ural.ru

[Stoitcho Goutsev \(100\) [C# MVP]]

Hi

It is good practice to close all the streams after using them. However,
MemoryStream is little bit different. Closing/Disposing this stream doesn't
do much resourcewise. It just marks the stream as closed so no more
reading/writing to the stream are possible. Methods like ToArray() and
GetBuffer() still works, which means that the data is still in the memory.
The Dispose simply calls Close so it doesn't make much of a difference.

Depending on the type of the variable that holds the reference to the stream
(whether it is a local variable or class field), the level of memory
consumptions and the structure of the code that uses this variable it make
become more important to set the variable to *null* than to close/dispose
the stream.

But anyways it is always a good programming practice to close/dispose all
the streams when finish working with them.


--
Stoitcho Goutsev (100) [C# MVP]

"BravesCharm" <ma*********@gmail.com> wrote in message
news:11**********************@g49g2000cwa.googlegr oups.com...

You should not have to set the variable to null. The only thing you
should need to do is call close/dispose. However, it's always a good
idea to set the variable to null so you know not to use it anymore.

[Nicholas Paldino [.NET/C# MVP]]

Oleg,

Some people in this thread have suggested that you set the variable to
null. You actually don't want to do this. In debug builds, you will end up
keeping the reference around longer (because of lack of optimizations) than
necessary. In release builds, assignments to null should be optimized out.

Also, it is good practice to always call Dispose on any instance of a
type that implements IDisposable.

Hope this helps.

--
- Nicholas Paldino [.NET/C# MVP]
- mv*@spam.guard.caspershouse.com

"Oleg Subachev" <ol**@urvb.ru> wrote in message
news:%2****************@TK2MSFTNGP14.phx.gbl...

I use local to methods MemoryStreams.
Both read-only and read-write ones.

Do I need to call MemoryStream.Close for read-only MemoryStreams before
leaving the method ?

And what about read-write MemoryStreams ?
--
Best regards,

Oleg Subachev
su******@ural.ru

[Helge Jensen]

Nicholas Paldino [.NET/C# MVP] wrote:

Also, it is good practice to always call Dispose on any instance of a
type that implements IDisposable.

If you are the one "responsible" for that object. For example:

void foo(Stream s) {
s.Write(...);
// should usually *not* invoke s.Dispose();
}

whereas the creator of the object should (usually) either: Dispose() it
when done:

void bar() {
using ( MemoryStream s = new MemoryStream() ) {
foo(s);
...;
}
}

or be sure it has given that responsibility to some other code:

class Baz: IDispoable {
Stream s;
void Dispose() { if ( s != null ) s.Dispose(); }
}
void quux(Baz baz) {
baz.s = new MemoryStream();
}

--
Helge Jensen
mailto:he**********@slog.dk
sip:he**********@slog.dk
-=> Sebastian cover-music: http://ungdomshus.nu <=-

[Nicholas Paldino [.NET/C# MVP]]

Helge,

Yes, if you are responsible for that. Sorry, I assumed that was
implied, but thanks for the clarification.
--
- Nicholas Paldino [.NET/C# MVP]
- mv*@spam.guard.caspershouse.com

"Helge Jensen" <he**********@slog.dk> wrote in message
news:u6**************@TK2MSFTNGP14.phx.gbl...

Nicholas Paldino [.NET/C# MVP] wrote:

Also, it is good practice to always call Dispose on any instance of a
type that implements IDisposable.

If you are the one "responsible" for that object. For example:

void foo(Stream s) {
s.Write(...);
// should usually *not* invoke s.Dispose();
}

whereas the creator of the object should (usually) either: Dispose() it
when done:

void bar() {
using ( MemoryStream s = new MemoryStream() ) {
foo(s);
...;
}
}

or be sure it has given that responsibility to some other code:

class Baz: IDispoable {
Stream s;
void Dispose() { if ( s != null ) s.Dispose(); }
}
void quux(Baz baz) {
baz.s = new MemoryStream();
}

--
Helge Jensen
mailto:he**********@slog.dk
sip:he**********@slog.dk
-=> Sebastian cover-music: http://ungdomshus.nu <=-

[Jon Skeet [C# MVP]]

Josip Habjan <jh*****@SPAM-OFF.net.hr> wrote:

I suggest you to close / dispose your memory stream, and also set memsrm
variable to null..
In some cases if you dont set memsrm to null, it will lock this file and you
could not access it again till you restart your PC.. (maby this happends
only to me).

1) MemoryStreams aren't associated with any files
2) Closing a memory stream doesn't actually do anything, although it's
good practice to get into the habit of disposing of all IDisposable
objects where appropriate (i.e. where you own it)
3) Setting a variable to null will have no effect if the stream has
already been disposed; it's very rarely worth setting a variable to
null for garbage collection reasons, to be frank.

--
Jon Skeet - <sk***@pobox.com>
http://www.pobox.com/~skeet
If replying to the group, please do not mail me too