using statment with sql connection

[John J. Hughes II]

I was wondering about the follow code. I know that dispose is called on an
object when it leaves the using clause but was also wondering if the closed
statement was called on objects like Sql Connection and Data Readers?
Basically will I have problem or leave an object in memory if the closed is
not called below?

using(SqlConnection con = new SqlConnection())
{
con.Open();
using(SqlCommand cmd = con.CreateCommand)
{
... set up
using(SqlDataReader dr = cmd.ExecuteDateReader())
{
while(dr.Read())
..... do something
}
}
}

Regards,
John

[Cordell Lawrence]

John, in both cases the object's Close( ) methods are called in their
respective Dispose( ) methods. In a situation where you don't wrap your code
in using statements, then I suppose not calling the Close methods of these
objects only become a problem if they are long lived or objects scoped as
members of some class that is long lived, otherwise when the objects fall
out of scope they should be disposed of.

Hope this helps.
Cordell Lawrence
Teleios Systems Ltd.

"John J. Hughes II" <[e-mail]> wrote in message
news:eJ****************@TK2MSFTNGP10.phx.gbl...

I was wondering about the follow code. I know that dispose is called on an object when it leaves the using clause but was also wondering if the closed statement was called on objects like Sql Connection and Data Readers?
Basically will I have problem or leave an object in memory if the closed is not called below?

using(SqlConnection con = new SqlConnection())
{
con.Open();
using(SqlCommand cmd = con.CreateCommand)
{
... set up
using(SqlDataReader dr = cmd.ExecuteDateReader())
{
while(dr.Read())
..... do something
}
}
}

Regards,
John

[Ignacio Machin \( .NET/ C# MVP \)]

Hi,

The close operation will be performed when the Dispose event, now as this
is not deterministic you don't have control of when will that happen,
therefore it's advised that you close your connectin as soon as you finish
with it.

cheers,

--
Ignacio Machin,
ignacio.machin AT dot.state.fl.us
Florida Department Of Transportation
"John J. Hughes II" <[e-mail]> wrote in message
news:eJ****************@TK2MSFTNGP10.phx.gbl...

I was wondering about the follow code. I know that dispose is called on an
object when it leaves the using clause but was also wondering if the closed
statement was called on objects like Sql Connection and Data Readers?
Basically will I have problem or leave an object in memory if the closed is
not called below?

using(SqlConnection con = new SqlConnection())
{
con.Open();
using(SqlCommand cmd = con.CreateCommand)
{
... set up
using(SqlDataReader dr = cmd.ExecuteDateReader())
{
while(dr.Read())
..... do something
}
}
}

Regards,
John

[Tom Porterfield]

Ignacio Machin ( .NET/ C# MVP ) wrote:

Hi,

The close operation will be performed when the Dispose event, now as this
is not deterministic you don't have control of when will that happen,
therefore it's advised that you close your connectin as soon as you finish
with it.

?? I thought Disposed was deterministic, only finalize is not
deterministic. In his example Dispose should be called when the using block
is exited.
--
Tom Porterfield

[John J. Hughes II]

Thanks,
John

"Cordell Lawrence" <cl*******@teleios-systems.com> wrote in message
news:eD**************@TK2MSFTNGP09.phx.gbl...

John, in both cases the object's Close( ) methods are called in their
respective Dispose( ) methods. In a situation where you don't wrap your
code
in using statements, then I suppose not calling the Close methods of these
objects only become a problem if they are long lived or objects scoped as
members of some class that is long lived, otherwise when the objects fall
out of scope they should be disposed of.

Hope this helps.
Cordell Lawrence
Teleios Systems Ltd.

"John J. Hughes II" <[e-mail]> wrote in message
news:eJ****************@TK2MSFTNGP10.phx.gbl...

I was wondering about the follow code. I know that dispose is called on

an

object when it leaves the using clause but was also wondering if the

closed

statement was called on objects like Sql Connection and Data Readers?
Basically will I have problem or leave an object in memory if the closed

is

not called below?

using(SqlConnection con = new SqlConnection())
{
con.Open();
using(SqlCommand cmd = con.CreateCommand)
{
... set up
using(SqlDataReader dr = cmd.ExecuteDateReader())
{
while(dr.Read())
..... do something
}
}
}

Regards,
John

[John J. Hughes II]

Ok, I had a feeling about that. Basically I could end up with a bunch of
open connection waiting for the system to get around to closing them which
could be a problem.

Thanks,
John

"Ignacio Machin ( .NET/ C# MVP )" <ignacio.machin AT dot.state.fl.us> wrote
in message news:%2***************@TK2MSFTNGP15.phx.gbl...

Hi,

The close operation will be performed when the Dispose event, now as this
is not deterministic you don't have control of when will that happen,
therefore it's advised that you close your connectin as soon as you finish
with it.

cheers,

--
Ignacio Machin,
ignacio.machin AT dot.state.fl.us
Florida Department Of Transportation
"John J. Hughes II" <[e-mail]> wrote in message
news:eJ****************@TK2MSFTNGP10.phx.gbl...

I was wondering about the follow code. I know that dispose is called on
an object when it leaves the using clause but was also wondering if the
closed statement was called on objects like Sql Connection and Data
Readers? Basically will I have problem or leave an object in memory if the
closed is not called below?

using(SqlConnection con = new SqlConnection())
{
con.Open();
using(SqlCommand cmd = con.CreateCommand)
{
... set up
using(SqlDataReader dr = cmd.ExecuteDateReader())
{
while(dr.Read())
..... do something
}
}
}

Regards,
John

[Ignacio Machin \( .NET/ C# MVP \)]

Hi Tom,

My mistake, you are 100% right, Dispose is deterministic

sorry for the error, going to get some expresso in my bloodstream :)

cheers,

--
Ignacio Machin,
ignacio.machin AT dot.state.fl.us
Florida Department Of Transportation
"Tom Porterfield" <tp******@mvps.org> wrote in message
news:%2****************@TK2MSFTNGP09.phx.gbl...

Ignacio Machin ( .NET/ C# MVP ) wrote:

Hi,

The close operation will be performed when the Dispose event, now as
this
is not deterministic you don't have control of when will that happen,
therefore it's advised that you close your connectin as soon as you
finish
with it.

?? I thought Disposed was deterministic, only finalize is not
deterministic. In his example Dispose should be called when the using
block
is exited.
--
Tom Porterfield

[John J. Hughes II]

So basically if I can stop writing close on these short read commands,
that's nice, saves a lot of finally statments in my code.

Regards,
John