Closing database connections in a class destructor

[Charlie]

Hi:

I have a destructor in my base class that is supposed to close a database
connection when class is released.

~BaseTable()
{
this.Conn.Close();
}

However, connection is never closed. It doesn't appear destructor is
firing. Why?

Thanks,
Charlie

[Mark Rae]

"Charlie" <cf*******@radiustravel.com> wrote in message
news:e1*************@TK2MSFTNGP09.phx.gbl...

I have a destructor in my base class that is supposed to close a database
connection when class is released.

~BaseTable()
{
this.Conn.Close();
}

However, connection is never closed. It doesn't appear destructor is
firing. Why?

1) After you've finished with the instance of the class, are you setting it
to null? If so, and nothing else is using it, the GC should collect it,
causing your destructor to fire...

[Chris, Master of All Things Insignificant]

Why do you think it isn't closed? AFAIK the destructor only runs when the
garbage collector does its thing. You won't know for sure when it gets run.
If you need to be sure it closes in a timely manner, call the Conn.Close
directly.

Chris

"Charlie" <cf*******@radiustravel.com> wrote in message
news:e1*************@TK2MSFTNGP09.phx.gbl...

Hi:

I have a destructor in my base class that is supposed to close a database
connection when class is released.

~BaseTable()
{
this.Conn.Close();
}

However, connection is never closed. It doesn't appear destructor is
firing. Why?

Thanks,
Charlie

[Tu-Thach]

Charlie,

The runtime controls when it calls the destructor. You need to take that
into consideration when closing your resources. Maybe you can implement
IDisposable interface and close the connection there.

"Charlie" wrote:

Hi:

I have a destructor in my base class that is supposed to close a database
connection when class is released.

~BaseTable()
{
this.Conn.Close();
}

However, connection is never closed. It doesn't appear destructor is
firing. Why?

Thanks,
Charlie

[RCS]

If at all possible, it's proper to use the "Using" statement to set the
scope of a database connection:

using ( SqlConnection Conn = new SqlConnection() )
{
// do your database work
}

As soon as you leave that curly brace, the scope of that variable goes away
and will "immediately" goto garbage collection..

"Charlie" <cf*******@radiustravel.com> wrote in message
news:e1*************@TK2MSFTNGP09.phx.gbl...

Hi:

I have a destructor in my base class that is supposed to close a database
connection when class is released.

~BaseTable()
{
this.Conn.Close();
}

However, connection is never closed. It doesn't appear destructor is
firing. Why?

Thanks,
Charlie

[Ollie Riches]

firstly you shouldn't have a destructor for a class unless the class is
implementing the IDisposable interface and secondly you should close a
database connection as soon as you have finished with it.

HTH

Ollie Riches

"Charlie" <cf*******@radiustravel.com> wrote in message
news:e1*************@TK2MSFTNGP09.phx.gbl...

Hi:

I have a destructor in my base class that is supposed to close a database
connection when class is released.

~BaseTable()
{
this.Conn.Close();
}

However, connection is never closed. It doesn't appear destructor is
firing. Why?

Thanks,
Charlie

[Cor Ligthert]

Charlie,

Beside all answers you have had already is this one of the few places where
is advised to use the connection.dispose in dotnet 2002/2003. It seems that
there is done some extra overloading for the connection pooling not
mentioned on MSDN. On MSDN is the difference between the close and the
dispose that the reference to the connectionstring is removed.

Just a little addition.

Cor

[Dan Shanyfelt MCAD]

Is it better to go with the
finally {conn.dispose;}
or
using (con = new conn)
?

-Dan

[Cor Ligthert]

Dan,

I don't know the only thing I know is that Angel (MS AdoNet) is always
writting that they have used the connection.dispose to do something extra
for connection pooling in the versions 2002 and 2003 while they have a new
implementation for that in the version 2005.

How far that is affected with the real dispose, I don't know as I said
before.

Cor

[CSharper]

Basically the same thing. Either way is still better than setting it to
null, since the SqlConnection's Dispose method explicitly closes the
connection.

Dan Cox

"Dan Shanyfelt MCAD" <da*************@yahoo.com> wrote in message
news:11**********************@f14g2000cwb.googlegr oups.com...

Is it better to go with the
finally {conn.dispose;}
or
using (con = new conn)
?

-Dan

[CSharper]

They're basically the same thing. Either way is still better than simply
setting it to null, since the SqlConnection's Dispose method explicitly
closes the connection.

Dan Cox

"Dan Shanyfelt MCAD" <da*************@yahoo.com> wrote in message
news:11**********************@f14g2000cwb.googlegr oups.com...

Is it better to go with the
finally {conn.dispose;}
or
using (con = new conn)
?

-Dan

[CSharper]

They're basically the same thing. Either way is still better than simply
setting it to null, since the SqlConnection's Dispose method explicitly
closes the connection.

Dan Cox

"Dan Shanyfelt MCAD" <da*************@yahoo.com> wrote in message
news:11**********************@f14g2000cwb.googlegr oups.com...

Is it better to go with the
finally {conn.dispose;}
or
using (con = new conn)
?

-Dan

[CSharper]

They're basically the same thing. Either way is still better than simply
setting it to null, since the SqlConnection's Dispose method explicitly
closes the connection.

Dan Cox

"Dan Shanyfelt MCAD" <da*************@yahoo.com> wrote in message
news:11**********************@f14g2000cwb.googlegr oups.com...

Is it better to go with the
finally {conn.dispose;}
or
using (con = new conn)
?

-Dan

[CSharper]

They're basically the same thing. Either way is still better than simply
setting it to null, since the SqlConnection's Dispose method explicitly
closes the connection.

Dan Cox

"Dan Shanyfelt MCAD" <da*************@yahoo.com> wrote in message
news:11**********************@f14g2000cwb.googlegr oups.com...

Is it better to go with the
finally {conn.dispose;}
or
using (con = new conn)
?

-Dan

[CSharper]

Sorry for the multiple reposts...darn newsgroup server.
"CSharper" <do**@botherme.com> wrote in message
news:d7********************@bignews4.bellsouth.net ...

They're basically the same thing. Either way is still better than simply
setting it to null, since the SqlConnection's Dispose method explicitly
closes the connection.

Dan Cox

"Dan Shanyfelt MCAD" <da*************@yahoo.com> wrote in message
news:11**********************@f14g2000cwb.googlegr oups.com...

Is it better to go with the
finally {conn.dispose;}
or
using (con = new conn)
?

-Dan

[Thomas Tomiczek [MVP]]

I normally do not use "using".

The issue is that I normally have more than one thing to close.

Multiple "using" statements make the sourec look awfull, indentaion wise.

Multiple closingsin the finally do not.

--
Regards

Thomas Tomiczek
THONA Software & Consulting Ltd.
(Microsoft MVP C#/.NET)
(CTO PowerNodes Ltd.)
---

Still waiting for ObjectSpaces? Try the EntityBroker today - more versatile,
more powerfull.
And something in use NOW. for the projects you have to deliver - NOW.
"CSharper" <do**@botherme.com> wrote in message
news:d7********************@bignews4.bellsouth.net ...

They're basically the same thing. Either way is still better than simply
setting it to null, since the SqlConnection's Dispose method explicitly
closes the connection.

Dan Cox

"Dan Shanyfelt MCAD" <da*************@yahoo.com> wrote in message
news:11**********************@f14g2000cwb.googlegr oups.com...

Is it better to go with the
finally {conn.dispose;}
or
using (con = new conn)
?

-Dan