Best Practice: Remove ',' from a string

[Mike]

I want to remove all commas from a numerical form field.

I know that Replace(",", "") will to the job, but Replace(',', '') seems
more appropriot but does not work.

Any efficient suggestions would be appreciated.

Thank,

Mike

[Jon Skeet [C# MVP]]

Mike <mi********@com.nospam> wrote:

I want to remove all commas from a numerical form field.

I know that Replace(",", "") will to the job, but Replace(',', '') seems
more appropriot but does not work.
Replace (char, char) replaces one character with another - you want to
replace one character with nothing.
Any efficient suggestions would be appreciated.

Well, the first question is: have you checked that Replace(",", "")
isn't fast enough already?

--
Jon Skeet - <sk***@pobox.com>
http://www.pobox.com/~skeet
If replying to the group, please do not mail me too

[Nicholas Paldino [.NET/C# MVP]]

Mike,

How does it not work? There are overloads of Replace that take two
characters as the arguments. Are you getting a compile time exception?

Can you show an example where it does not work?
--
- Nicholas Paldino [.NET/C# MVP]
- mv*@spam.guard.caspershouse.com

"Mike" <mi********@com.nospam> wrote in message
news:eJ**************@TK2MSFTNGP15.phx.gbl...

I want to remove all commas from a numerical form field.

I know that Replace(",", "") will to the job, but Replace(',', '') seems
more appropriot but does not work.

Any efficient suggestions would be appreciated.

Thank,

Mike

[Nicholas Paldino [.NET/C# MVP]]

Mike,

When you call the Replace method, are you storing the return value?
Calling Replace does not replace the characters on the string you call it
on, rather, it performs the operation on a new string, and returns that. My
guess is that you are not storing the return value and using that.

Hope this helps.
--
- Nicholas Paldino [.NET/C# MVP]
- mv*@spam.guard.caspershouse.com

"Mike" <mi********@com.nospam> wrote in message
news:eJ**************@TK2MSFTNGP15.phx.gbl...

I want to remove all commas from a numerical form field.

I know that Replace(",", "") will to the job, but Replace(',', '') seems
more appropriot but does not work.

Any efficient suggestions would be appreciated.

Thank,

Mike

[Tom Porterfield]

On Tue, 7 Dec 2004 15:59:37 -0500, Nicholas Paldino [.NET/C# MVP] wrote:

Mike,

When you call the Replace method, are you storing the return value?
Calling Replace does not replace the characters on the string you call it
on, rather, it performs the operation on a new string, and returns that. My
guess is that you are not storing the return value and using that.

Hope this helps.

Actually, no, that's not the reason it is failing. His invocation that is
failing, Replace(',','') has in invalid second parameter. '' is not a
valid char. There is no empty char, so he must use the overload that takes
two strings to replace , with nothing.
--
Tom Porterfield

[Mike]

'' does not compile, no null character. I can use Replace(string, string) I
am simply looking for a very fast efficient way.

Thanks,

Mike

"Nicholas Paldino [.NET/C# MVP]" <mv*@spam.guard.caspershouse.com> wrote in
message news:eS**************@TK2MSFTNGP09.phx.gbl...

Mike,

How does it not work? There are overloads of Replace that take two
characters as the arguments. Are you getting a compile time exception?

Can you show an example where it does not work?
--
- Nicholas Paldino [.NET/C# MVP]
- mv*@spam.guard.caspershouse.com

"Mike" <mi********@com.nospam> wrote in message
news:eJ**************@TK2MSFTNGP15.phx.gbl...

I want to remove all commas from a numerical form field.

I know that Replace(",", "") will to the job, but Replace(',', '') seems
more appropriot but does not work.

Any efficient suggestions would be appreciated.

Thank,

Mike

[Mike]

Tom,

The best way to put it is what is the fastest way to strip a char or char[]
from a string.

Guess I should have said that to begin with.

Thanks,

Mike
"Tom Porterfield" <tp******@mvps.org> wrote in message
news:b1***************@tpportermvps.org...

On Tue, 7 Dec 2004 15:59:37 -0500, Nicholas Paldino [.NET/C# MVP] wrote:

Mike,

When you call the Replace method, are you storing the return value?
Calling Replace does not replace the characters on the string you call it on, rather, it performs the operation on a new string, and returns that. My guess is that you are not storing the return value and using that.

Hope this helps.
Actually, no, that's not the reason it is failing. His invocation that is
failing, Replace(',','') has in invalid second parameter. '' is not a
valid char. There is no empty char, so he must use the overload that

takes two strings to replace , with nothing.
--
Tom Porterfield

[John Vottero]

"Mike" <mi********@com.nospam> wrote in message
news:eJ**************@TK2MSFTNGP15.phx.gbl...

I want to remove all commas from a numerical form field.

I know that Replace(",", "") will to the job, but Replace(',', '') seems
more appropriot but does not work.

Any efficient suggestions would be appreciated.

The fastest way is to not do it. Why are you removing the commas? If it's
part of parsing the string into a numeric value, try something like:

float theValue = Single.Parse(theString, NumberStyles.Currency)

which will accept commas, $ etc. You have many options for NumberStyles.