Beginner : closing DataReader

[NotYetaNurd]

try
{
SqlDataReader dread=sqlcom.ExecuteReader();
}

finally
{
dread.Close();
sqlcom.Connection.Close();
}

here is my problem..
the above code does not compile becoz dread (SqlDataReader) is out of scope
in finally block
i cant declare dread (SqlDataReader) outside try block .....
how do i close data reader dread (SqlDataReader) if any exception happens
.......

[Saurabh]

Can you not do something like :

SqlDataReader dread = null;
try
{
SqlDataReader dread=sqlcom.ExecuteReader();
}

finally
{
if (dread != null)
{ //or some sensible checking, i can't say what it should be... ;)
dread.Close();
}
sqlcom.Connection.Close();
}
"NotYetaNurd" <No*********@Matrix.com> wrote in message
news:Of****************@TK2MSFTNGP11.phx.gbl...

try
{
SqlDataReader dread=sqlcom.ExecuteReader();
}

finally
{
dread.Close();
sqlcom.Connection.Close();
}

here is my problem..
the above code does not compile becoz dread (SqlDataReader) is out of scope in finally block
i cant declare dread (SqlDataReader) outside try block .....
how do i close data reader dread (SqlDataReader) if any exception happens
......

[Miha Markic]

Hi Not

SqlDataReader dread=sqlcom.ExecuteReader();
try
{
}
finally
{
dread.Close();
sqlcom.Connection.Close();
}

Your code should looks like the code above.

--
Miha Markic - RightHand .NET consulting & software development
miha at rthand com
www.rthand.com

"NotYetaNurd" <No*********@Matrix.com> wrote in message
news:Of****************@TK2MSFTNGP11.phx.gbl...

try
{
SqlDataReader dread=sqlcom.ExecuteReader();
}

finally
{
dread.Close();
sqlcom.Connection.Close();
}

here is my problem..
the above code does not compile becoz dread (SqlDataReader) is out of scope in finally block
i cant declare dread (SqlDataReader) outside try block .....
how do i close data reader dread (SqlDataReader) if any exception happens
......

[Shiva]

Since dread variable is local only to the try block it will not be available
in the finally block. Only option is to move the data reader declaration
outside try block or have the Close() method inside try.

"NotYetaNurd" <No*********@Matrix.com> wrote in message
news:Of**************@TK2MSFTNGP11.phx.gbl...
try
{
SqlDataReader dread=sqlcom.ExecuteReader();
}

finally
{
dread.Close();
sqlcom.Connection.Close();
}

here is my problem..
the above code does not compile becoz dread (SqlDataReader) is out of scope
in finally block
i cant declare dread (SqlDataReader) outside try block .....
how do i close data reader dread (SqlDataReader) if any exception happens
.......

[Sami Vaaraniemi]

Or even better:

try
{
using (SqlDataReader dread = sqlcom.ExecuteReader())
{
// use reader here - no need to call Close in the finally block
}
}
finally
{
sqlcom.Connection.Close();
}

Further, if you put the SqlConnection into a using block too you can get rid
of the try/finally completely.

Regards,
Sami

"Saurabh" <sa*****@nagpurcity.net> wrote in message
news:eh**************@tk2msftngp13.phx.gbl...

Can you not do something like :

SqlDataReader dread = null;
try
{
SqlDataReader dread=sqlcom.ExecuteReader();
}

finally
{
if (dread != null)
{ //or some sensible checking, i can't say what it should be... ;)
dread.Close();
}
sqlcom.Connection.Close();
}
"NotYetaNurd" <No*********@Matrix.com> wrote in message
news:Of****************@TK2MSFTNGP11.phx.gbl...

try
{
SqlDataReader dread=sqlcom.ExecuteReader();
}

finally
{
dread.Close();
sqlcom.Connection.Close();
}

here is my problem..
the above code does not compile becoz dread (SqlDataReader) is out of

scope

in finally block
i cant declare dread (SqlDataReader) outside try block .....
how do i close data reader dread (SqlDataReader) if any exception happens ......

[NotYetaNurd]

Thanks saurabh ..

"Saurabh" <sa*****@nagpurcity.net> wrote in message
news:eh**************@tk2msftngp13.phx.gbl...

Can you not do something like :

SqlDataReader dread = null;
try
{
SqlDataReader dread=sqlcom.ExecuteReader();
}

finally
{
if (dread != null)
{ //or some sensible checking, i can't say what it should be... ;)
dread.Close();
}
sqlcom.Connection.Close();
}
"NotYetaNurd" <No*********@Matrix.com> wrote in message
news:Of****************@TK2MSFTNGP11.phx.gbl...

try
{
SqlDataReader dread=sqlcom.ExecuteReader();
}

finally
{
dread.Close();
sqlcom.Connection.Close();
}

here is my problem..
the above code does not compile becoz dread (SqlDataReader) is out of

scope

in finally block
i cant declare dread (SqlDataReader) outside try block .....
how do i close data reader dread (SqlDataReader) if any exception happens ......

[Saurabh]

Actually it should be as below.... in the previous post i had the
declaration outside as well as inside the try block. My mistake in copy +
paste ;)

SqlDataReader dread = null;
try
{
dread=sqlcom.ExecuteReader();
}

"NotYetaNurd" <No*********@Matrix.com> wrote in message
news:ey**************@TK2MSFTNGP11.phx.gbl...

Thanks saurabh ..

"Saurabh" <sa*****@nagpurcity.net> wrote in message
news:eh**************@tk2msftngp13.phx.gbl...

Can you not do something like :

SqlDataReader dread = null;
try
{
SqlDataReader dread=sqlcom.ExecuteReader();
}

finally
{
if (dread != null)
{ //or some sensible checking, i can't say what it should be... ;)
dread.Close();
}
sqlcom.Connection.Close();
}
"NotYetaNurd" <No*********@Matrix.com> wrote in message
news:Of****************@TK2MSFTNGP11.phx.gbl...

try
{
SqlDataReader dread=sqlcom.ExecuteReader();
}

finally
{
dread.Close();
sqlcom.Connection.Close();
}

here is my problem..
the above code does not compile becoz dread (SqlDataReader) is out of

scope

in finally block
i cant declare dread (SqlDataReader) outside try block .....
how do i close data reader dread (SqlDataReader) if any exception happens ......

[Daniel Pratt]

Or you could even do:

using (SqlDataReader dread =
sqlcom.ExecuteReader(CommandBehavior.CloseConnecti on))
{
// use reader here - no need to call Close in the finally block
...
}

Regards,
Dan

"Sami Vaaraniemi" <sa***************@jippii.fi> wrote in message
news:bs**********@phys-news1.kolumbus.fi...

Or even better:

try
{
using (SqlDataReader dread = sqlcom.ExecuteReader())
{
// use reader here - no need to call Close in the finally block
}
}
finally
{
sqlcom.Connection.Close();
}

Further, if you put the SqlConnection into a using block too you can get rid of the try/finally completely.

Regards,
Sami

[NotYetaNurd]

hi miha but i wanted to capture any exception that happens in
SqlDataReader dread=sqlcom.ExecuteReader();
so i have to put it inside try block....
"Miha Markic" <miha at rthand com> wrote in message
news:eW**************@TK2MSFTNGP10.phx.gbl...

Hi Not

SqlDataReader dread=sqlcom.ExecuteReader();
try
{
}
finally
{
dread.Close();
sqlcom.Connection.Close();
}

Your code should looks like the code above.

--
Miha Markic - RightHand .NET consulting & software development
miha at rthand com
www.rthand.com

"NotYetaNurd" <No*********@Matrix.com> wrote in message
news:Of****************@TK2MSFTNGP11.phx.gbl...

try
{
SqlDataReader dread=sqlcom.ExecuteReader();
}

finally
{
dread.Close();
sqlcom.Connection.Close();
}

here is my problem..
the above code does not compile becoz dread (SqlDataReader) is out of

scope

in finally block
i cant declare dread (SqlDataReader) outside try block .....
how do i close data reader dread (SqlDataReader) if any exception happens ......

[NotYetaNurd]

okey :-)
"Saurabh" <sa*****@nagpurcity.net> wrote in message
news:u2**************@tk2msftngp13.phx.gbl...

Actually it should be as below.... in the previous post i had the
declaration outside as well as inside the try block. My mistake in copy +
paste ;)

SqlDataReader dread = null;
try
{
dread=sqlcom.ExecuteReader();
}

"NotYetaNurd" <No*********@Matrix.com> wrote in message
news:ey**************@TK2MSFTNGP11.phx.gbl...

Thanks saurabh ..

"Saurabh" <sa*****@nagpurcity.net> wrote in message
news:eh**************@tk2msftngp13.phx.gbl...

Can you not do something like :

SqlDataReader dread = null;
try
{
SqlDataReader dread=sqlcom.ExecuteReader();
}

finally
{
if (dread != null)
{ //or some sensible checking, i can't say what it should be... ;)
dread.Close();
}
sqlcom.Connection.Close();
}
"NotYetaNurd" <No*********@Matrix.com> wrote in message
news:Of****************@TK2MSFTNGP11.phx.gbl...
> try
> {
> SqlDataReader dread=sqlcom.ExecuteReader();
> }
>
> finally
> {
> dread.Close();
> sqlcom.Connection.Close();
> }
>
> here is my problem..
> the above code does not compile becoz dread (SqlDataReader) is out of scope
> in finally block
> i cant declare dread (SqlDataReader) outside try block .....
> how do i close data reader dread (SqlDataReader) if any exception

happens

> ......
>
>

[Miha Markic]

Hi,

Yes, you might put it inside another try/catch block or do like this:
SqlDataReader dread;
try
{
dread = =sqlcom.ExecuteReader();
}
finally
{
if (dread != null)
dread.Close();
sqlcom.Connection.Close();
}

--
Miha Markic - RightHand .NET consulting & software development
miha at rthand com
www.rthand.com

"NotYetaNurd" <No*********@Matrix.com> wrote in message
news:%2****************@TK2MSFTNGP10.phx.gbl...

hi miha but i wanted to capture any exception that happens in
SqlDataReader dread=sqlcom.ExecuteReader();
so i have to put it inside try block....
"Miha Markic" <miha at rthand com> wrote in message
news:eW**************@TK2MSFTNGP10.phx.gbl...

Hi Not

SqlDataReader dread=sqlcom.ExecuteReader();
try
{
}
finally
{
dread.Close();
sqlcom.Connection.Close();
}

Your code should looks like the code above.

--
Miha Markic - RightHand .NET consulting & software development
miha at rthand com
www.rthand.com

"NotYetaNurd" <No*********@Matrix.com> wrote in message
news:Of****************@TK2MSFTNGP11.phx.gbl...

try
{
SqlDataReader dread=sqlcom.ExecuteReader();
}

finally
{
dread.Close();
sqlcom.Connection.Close();
}

here is my problem..
the above code does not compile becoz dread (SqlDataReader) is out of

scope

in finally block
i cant declare dread (SqlDataReader) outside try block .....
how do i close data reader dread (SqlDataReader) if any exception happens ......