Why Doesn't this work

[Jim]

<code>
string x = "[phone]";
string dialString = null;
for(int i = 0; i < x.Length; i++)
{
if(x[i] != '-' || x[i] !
= '(' || x[i] != ')')
dialString += x[i];
else
MessageBox.Show(x
[i].ToString());
}
MessageBox.Show(dialString);
</code>

[mikeb]

Jim wrote:

<code>
string x = "[phone]";
string dialString = null;
for(int i = 0; i < x.Length; i++)
{
if(x[i] != '-' || x[i] !
= '(' || x[i] != ')')
dialString += x[i];
else
MessageBox.Show(x
[i].ToString());
}
MessageBox.Show(dialString);
</code>

As your character test stands, every character, x[i], will evaluate to true.

I think you want your test to be:

if(x[i] != '-' && x[i] != '(' && x[i] != ')')

--
mikeb

[Bjorn Abelli]

"Jim" wrote...

if(x[i] != '-' || x[i] != '(' || x[i] != ')')

....something not equals something OR something not equals something else,
will always return true...

Try this instead:

if(x[i] != '-' && x[i] != '(' && x[i] != ')')

// Bjorn A

[leo lin]

I agree with Bjorn, but I think the line
string dialString = null;
should be
String dialString = new String();
or
String dialString = "";
"Bjorn Abelli" <bj**********@DoNotSpam.hotmail.com> wrote in message
news:u6**************@TK2MSFTNGP10.phx.gbl...

"Jim" wrote...

if(x[i] != '-' || x[i] != '(' || x[i] != ')')

...something not equals something OR something not equals something else,
will always return true...

Try this instead:

if(x[i] != '-' && x[i] != '(' && x[i] != ')')

// Bjorn A