How can I improve my coding style in the following code?

[krisssgopi]

Hi Team,

Please give me a feedback on the below coding. I like to know whether i had improved in writing the .net coding. Thanks in advance.

Imports System.Data
Imports Offlinemessage
 
Partial Class Offline_Message_Offline_Message
    Inherits System.Web.UI.Page
    Dim ds As New DataSet
    Dim obj As New Offlinemessage
 
    Protected Sub Button1_Click(ByVal sender As Object, ByVal e As System.EventArgs)
 
    End Sub
 
    Protected Sub Page_Load(ByVal sender As Object, ByVal e As System.EventArgs) Handles Me.Load
        page_initialization()
    End Sub
    Public Sub page_initialization()
        offlinecountlabel.Visible = True
        OfflinemessageQuery.Visible = True
        Dim str As String
        str = Session("UserAccountNumber")
        DateTextBox.Attributes.Add("onclick", "showCalendarControl(DateTextBox,1)")
        FromDateTextBox.Attributes.Add("onclick", "showCalendarControl(FromDateTextBox,2)")
        ToDateTextBox.Attributes.Add("onclick", "showCalendarControl(ToDateTextBox,2)")
        offlineSearchButton.Attributes.Add("onclientclick", "search_validation()")
        Advancesearchbutton.Attributes.Add("onclientclick", "advancesearch_validation()")
        AdvanceSearchEmailidTextBox.Attributes.Add("onclick", "advancesearch_uservalidation()")
        AdvanceSearchEmailidTextBox.Attributes.Add("onKeyDown", "advancesearch_uservalidation()")
        AdvanceSearchNameTextBox.Attributes.Add("onclick", "advancesearch_nametextbox()")
        AdvanceSearchNameTextBox.Attributes.Add("onKeyDown", "advancesearch_nametextbox()")
        AdvanceSearchPhoneNoTextBox.Attributes.Add("onclick", "AdvanceSearch_PhoneNoTextBox()")
        AdvanceSearchPhoneNoTextBox.Attributes.Add("onKeyDown", "AdvanceSearch_PhoneNoTextBox()")
        Year4monthLabel.Text = CType(2010, Integer)
        yearlabel1.Text = CType(2010, Integer)
        yearLabel2.Text = CType(2011, Integer)
        yearLabel3.Text = CType(2012, Integer)
        yearLabel4.Text = CType(2013, Integer)
    End Sub
 
    Protected Sub offlineSearchButton_Click(ByVal sender As Object, ByVal e As System.EventArgs)
 
        'MonthTextBox.Text
        'YearTextBox
        'FromDateTextBox
        'ToDateTextBox
        'AdvanceSearchNameTextBox
        'AdvanceSearchEmailidTextBox
        'AdvanceSearchPhoneNoTextBox
 
        If DateTextBox.Text <> "" Then
            datewise_search(DateTextBox.Text)
        ElseIf MonthTextBox.Text <> "" Then
            monthwise_search(MonthTextBox.Text)
        ElseIf YearTextBox.Text <> "" Then
            yearwise_search(YearTextBox.Text)
        ElseIf FromDateTextBox.Text <> "" And ToDateTextBox.Text <> "" Then
            from2todatewise_search(FromDateTextBox.Text, ToDateTextBox.Text)
        End If
    End Sub
 
    Public Sub datewise_search(ByVal getdate As String)
        Dim obj As New Offlinemessage
        Dim ds As New DataSet
        'MsgBox(getdate)
        Dim mydate As New Date
        mydate = CDate(getdate)
        Dim str1 As String
        str1 = Format(mydate, "yyyy-MM-dd")
        'MsgBox(str1)
        Dim count As Integer
        'This is for getting count of offline message.
        count = obj.offlinemessage_count(Session("UserAccountNumber"), str1)
        If (count = 0) Then
 
            offlinecountlabel.Text = count & " Number of Offline Messages"
        Else
 
            offlinecountlabel.Text = count & " Number of Offline Messages"
        End If
        ds = Session("Globalds")
        Session("Globalds") = obj.searchdatewise(Session("UserAccountNumber"), str1)
        bindgrid_offlinemessage()
    End Sub
 
    Public Sub monthwise_search(ByVal month As String)
        Dim obj As New Offlinemessage
        Dim mydate As New Date
        Dim count As Integer
        Dim str As String
        Dim ds As New DataSet
        Session("Globalds") = ds
        mydate = CDate(month)
        str = Format(mydate, "yyyy-MM")
        count = obj.offlinemessage_count(Session("UserAccountNumber"), month)
        If (count = 0) Then
            offlinecountlabel.Text = count & " Number of Offline Messages"
        Else
            offlinecountlabel.Text = count & " Number of Offline Messages"
        End If
        Session("Globalds") = obj.searchmonthwise(Session("UserAccountNumber"), str)
        bindgrid_offlinemessage()
    End Sub
 
    Public Sub yearwise_search(ByVal year As String)
        Dim count As Integer
        Dim ds As New DataSet
        Dim obj As New Offlinemessage
        count = obj.offlinemessage_count(Session("UserAccountNumber"), year)
        If (count = 0) Then
            offlinecountlabel.Text = count & " Number of Offline Messages"
        Else
            offlinecountlabel.Text = count & " Number of Offline Messages"
        End If
        ds = Session("Globalds")
        Session("Globalds") = obj.searchyearwise(Session("UserAccountNumber"), year)
        bindgrid_offlinemessage()
    End Sub
 
    Public Sub from2todatewise_search(ByVal fromdate As String, ByVal todate As String)
        Dim frommydate, tomydate As New Date
        Dim fromdatewise, todatewise As String
        Dim ds As New DataSet
        Dim obj As New Offlinemessage
        frommydate = CDate(fromdate)
        tomydate = CDate(todate)
        fromdatewise = Format(frommydate, "yyyy-MM-dd")
        todatewise = Format(tomydate, "yyyy-MM-dd")
        Session("Globalds") = obj.search_from2todatewise(Session("UserAccountNumber"), fromdatewise, todatewise)
        bindgrid_offlinemessage()
 
    End Sub
 
    Public Sub bindgrid_offlinemessage()
        ds = Session("Globalds")
        OfflinemessageGridView.DataSource = ds
        OfflinemessageGridView.DataBind()
 
 
    End Sub
 
    Protected Sub OfflinemessageGridView_PageIndexChanged(ByVal sender As Object, ByVal e As System.EventArgs) Handles OfflinemessageGridView.PageIndexChanged
 
    End Sub
 
    Protected Sub OfflinemessageGridView_PageIndexChanging(ByVal sender As Object, ByVal e As System.Web.UI.WebControls.GridViewPageEventArgs) Handles OfflinemessageGridView.PageIndexChanging
        OfflinemessageGridView.PageIndex = e.NewPageIndex
        bindgrid_offlinemessage()
 
    End Sub
 
    Protected Sub OfflinemessageGridView_SelectedIndexChanged(ByVal sender As Object, ByVal e As System.EventArgs) Handles OfflinemessageGridView.SelectedIndexChanged
        Dim link As New LinkButton
        Dim obj As New Offlinemessage
        Dim txt As New HiddenField
        Dim mydate As New Date
        Dim ds As New DataSet
        Dim username, userdate As String
        link = CType(OfflinemessageGridView.SelectedRow.Cells(0).FindControl("OfflineMessageCustomerLinkButton"), LinkButton)
        txt = CType(OfflinemessageGridView.SelectedRow.Cells(0).FindControl("OfflineMessageDateandTime"), HiddenField)
        'MsgBox(txt.Value)
        'MsgBox(link.Text)
        username = link.Text
        userdate = txt.Value
        mydate = CDate(userdate)
        'MsgBox(mydate)
        Dim userdates As String
        userdates = Format(mydate, "yyyy-MM-dd HH:mm:ss")
        'MsgBox(userdates)
        'ds = Session("Globalds")
        ds = obj.get_offline_customerdetail(Session("UserAccountNumber"), username, userdates)
        'bindgrid_offlinemessage()
        show_offlinemessage(ds)
    End Sub
 
    Public Sub show_offlinemessage(ByVal ds As DataSet)
        Dim t1, t2 As New TextBox
        t1.Text = ds.Tables(0).Rows(0).Item(0)
        t2.Text = ds.Tables(0).Rows(0).Item(8)
        VisitorFirstNameTextBox.Text = ds.Tables(0).Rows(0).Item(2)
        VisitorLastNameTextBox.Text = ds.Tables(0).Rows(0).Item(3)
        VisitorEmailidTextBox.Text = ds.Tables(0).Rows(0).Item(4)
        VisitorPhonenumberTextBox.Text = ds.Tables(0).Rows(0).Item(5)
        VisitorDateTextBox.Text = ds.Tables(0).Rows(0).Item(7)
        VisitorDepartmentTextBox.Text = ds.Tables(0).Rows(0).Item(9)
        'VisitorCountryTextbox.Text = ds.Tables(0).Rows(0).Item(10)
        OfflinemessageQuery.Text = ds.Tables(0).Rows(0).Item(6)
        If ds.Tables(0).Rows(0).Item(10).ToString.Trim = vbNullString Then
            VisitorCountryTextbox.Text = ""
        Else
            VisitorCountryTextbox.Text = ds.Tables(0).Rows(0).Item(10)
        End If
    End Sub
 
    'This is for Advance Search Criteria.
 
    Protected Sub Advancesearchbutton_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles Advancesearchbutton.Click
 
        If (AdvanceSearchNameTextBox.Text <> "") Then
            search_byname(AdvanceSearchNameTextBox.Text)
        ElseIf (AdvanceSearchEmailidTextBox.Text <> "") Then
            search_byemailid(AdvanceSearchEmailidTextBox.Text)
        ElseIf (AdvanceSearchPhoneNoTextBox.Text <> "") Then
            search_byContactno(AdvanceSearchPhoneNoTextBox.Text)
        End If
    End Sub
 
    Public Sub search_byname(ByVal customername As String)
        Dim ds As New DataSet
        Dim count As Integer
        count = obj.count_customername(Session("UserAccountNumber"), customername)
        If (count = 0) Then
            'MsgBox("Customer You specified does not exists.....")
            offlinecountlabel.Text = count & " Number of Offline Messages"
        Else
            offlinecountlabel.Text = count & " Number of Offline Messages"
            ds = Session("Globalds")
            Session("Globalds") = obj.search_customername(Session("UserAccountNumber"), customername)
            bindgrid_offlinemessage()
        End If
    End Sub
 
    Public Sub search_byemailid(ByVal emailid As String)
        Dim ds As New DataSet
        Dim count As Integer
        count = obj.count_customeremailid(Session("UserAccountNumber"), emailid)
        If (count = 0) Then
            'MsgBox("Customer with mail id you specified does not exists.....")
            offlinecountlabel.Text = count & " Number of Offline Messages"
        Else
            offlinecountlabel.Text = count & " Number of Offline Messages"
            ds = Session("Globalds")
            Session("Globalds") = obj.search_emailid(Session("UserAccountNumber"), emailid)
            bindgrid_offlinemessage()
        End If
    End Sub
 
    Public Sub search_byContactno(ByVal contact As String)
        Dim ds As New DataSet
        Dim count As Integer
        count = obj.count_Contactno(Session("UserAccountNumber"), contact)
        If (count = 0) Then
            'MsgBox("Customer with contact number you specified does not exists.....")
            offlinecountlabel.Text = count & " Number of Offline Messages"
        Else
            offlinecountlabel.Text = count & " Number of Offline Messages"
            ds = Session("Globalds")
            Session("Globalds") = obj.search_bycontactno(Session("UserAccountNumber"), contact)
            bindgrid_offlinemessage()
        End If
    End Sub
End Class
 

[khurramzeb]

The better approach is use Class. And by using the classes it will seperate your Presentation Layer to Business Layer

In this case you can create a class Search and then you can put all the functions for search i-e search_byContactno,search_byName,search_byEmail in the Search class and call these functions from the page.

[krisssgopi]

Hi Buddy,

Thank you. I can able to understand what you are saying. Above mentioned coding was written in code behind vb page. i have also written business layer and database layer. Shall i know what you are trying to say is to create one more class file and get the parameter from code behind page is it correct. please give me feedback.

[khurramzeb]

Hi,

Yes what i want to establish is create search class in your business layer, and call the functions of search class by passing parameters from code behind page (presentation layer), and your database layer will perform the database operations. If you still have some questions then let me know.
thanks