security issue while sending sms

[vinaypratap]

Hi everyone,

I need to send sms, I am using some API and code is, please someone tell me is there any security issue regarding username and password, if yes then how can I fix it. please help

WebClient client = new WebClient();
            string uname = "xxxxx";
            string passwd = "xxxxx";
            string mo_no = xxxxxxxxxx;
 
          string sid = "xxx";
 
           string msg = xxxxxxx;
            string baseurl = "providerURL?username="+uname+"&password="+passwd+"&sendername="+sid+"&mobileno="+mo_no+"&message=" + msg + "";
            Stream data = client.OpenRead(baseurl);
            StreamReader reader = new StreamReader(data);
            string s = reader.ReadToEnd();
            data.Close();
            reader.Close();

[Frinavale]

You could consider storing this information in your web.config file so that you can encrypt it. If you store credential information as strings in your code (like you are) you can read them if you view the binary. If you store them in the web.config file instead you can encrypt this information.

-Frinny