Error in my asp.net application

[rajanji]

Hi all,

I am a newbie to Asp.Net and currently practicing on a Job Portal Website... but encountering a problem when i try to insert my textbox and dropdownlist values into my sqlserver database called Fishingjobs.... Here is the code i am using :

 SqlConnection cn = newSqlConnection("Data Source=.;Initial Catalog=fishingjobs;Integrated Security=True;
SqlCommand selectcmd = newSqlCommand("select * from regcompany, cn);
SqlCommand insertcmd = new SqlCommand ("insert into regcompany values '" + txtuname.Text + "','" + txtpass.Text + "','" + txtemail +"','" + txtcname +"','" + RadioButtonList1.SelectedItem + "','" + txtcontactperson.Text + "','" + ddlindustrytype.SelectedItem + [/"','" + txtadd1.Text + "','" + txtadd2.Text + "','" + txtadd3.Text + "','" + ddlcountry.SelectedItem + "','" + ddlstate.SelectedItem + "','" + ddlcity.SelectedItem + "','"+txtpin.Text+"','"+txtphone.Text+"','" + txtwebsite.Text + "'", cn);
SqlDataAdapter da = new SqlDataAdapter();
DataSet ds = new DataSet();
DataTable dt = new DataTable();
cn.Open();
da.SelectCommand=selectcmd;
da.Fill(ds,"regcompany");
dt= ds.Tables("regcompany");
DataRow dr=dt.NewRow();
 
 
dr(0)= txtuname.Text;
dr(1)= txtpass.Text;
dr(2)= txtemail.Text;
dr(3)= txtcname.Text;
dr(4)= RadioButtonList1.SelectedItem;
dr(5)= txtcontactperson.Text;
dr(6)= ddlindustrytype.SelectedItem;
dr(7)= txtadd1.Text;
dr(8)= txtadd2.Text;
dr(9)= txtadd3.Text;
dr(10)= ddlcountry.SelectedItem;
dr(11)= ddlstate.SelectedItem;
dr(12)= ddlcity.Text;
dr(13)= txtpin.Text;
dr(14)= txtphone.Text;
dr(15)= txtwebsite.Text;
 
dt.Rows.Add(dr);
da.InsertCommand = insertcmd;
da.Update(ds, "regcompany");
 
cn.Close();
MultiView1.SetActiveView(View2);

[Frinavale]

Please post the error message that you're getting or indicate what is not working correctly.

Also, you shouldn't be forming your SQL insert statement using values directly inserted by the user. You should be creating this statement using parameters instead.

Check out this article for an example of what I'm talking about.