Database Connection Module

[NH]

I have a module that handles creating a sql connection object as per below
code. What do you think, is there a better way to do this?

Imports System.Data
Imports System.Data.SqlClient
Imports System.Configuration.ConfigurationManager

Public Module DBConnections
'Handles Opening and Closing connections to the Database
Public objConnection As SqlConnection

'Get the Connection string from the web config file
Public ConnStr As String = ConnectionStrings("DBString").ConnectionString

Public Sub openDB()
If objConnection Is Nothing = True Then
objConnection = New SqlConnection(ConnStr)
objConnection.Open()
Else

If objConnection.State <> ConnectionState.Open Then
objConnection.Open()
End If
End If
End Sub

Public Sub closeDB()
If objConnection Is Nothing = False Then
objConnection.Close()
objConnection = Nothing
End If
End Sub

End Module

[Bruce Barker]

bad idea if used with asp.net.

the code is not threadsafe, and am not sure why you want to share the same
connection object with all current page requests. if you add the required
locking, you website could only process one request at a time.

-- bruce (sqlwork.com)

"NH" <[e-mail]> wrote in message
news:C4**********************************@microsof t.com...

I have a module that handles creating a sql connection object as per below
code. What do you think, is there a better way to do this?

Imports System.Data
Imports System.Data.SqlClient
Imports System.Configuration.ConfigurationManager

Public Module DBConnections
'Handles Opening and Closing connections to the Database
Public objConnection As SqlConnection

'Get the Connection string from the web config file
Public ConnStr As String =
ConnectionStrings("DBString").ConnectionString

Public Sub openDB()
If objConnection Is Nothing = True Then
objConnection = New SqlConnection(ConnStr)
objConnection.Open()
Else

If objConnection.State <> ConnectionState.Open Then
objConnection.Open()
End If
End If
End Sub

Public Sub closeDB()
If objConnection Is Nothing = False Then
objConnection.Close()
objConnection = Nothing
End If
End Sub

End Module

[NH]

can you suggest the best way to handle connection objects?

"Bruce Barker" wrote:

bad idea if used with asp.net.

the code is not threadsafe, and am not sure why you want to share the same
connection object with all current page requests. if you add the required
locking, you website could only process one request at a time.

-- bruce (sqlwork.com)

"NH" <[e-mail]> wrote in message
news:C4**********************************@microsof t.com...

I have a module that handles creating a sql connection object as per below
code. What do you think, is there a better way to do this?

Imports System.Data
Imports System.Data.SqlClient
Imports System.Configuration.ConfigurationManager

Public Module DBConnections
'Handles Opening and Closing connections to the Database
Public objConnection As SqlConnection

'Get the Connection string from the web config file
Public ConnStr As String =
ConnectionStrings("DBString").ConnectionString

Public Sub openDB()
If objConnection Is Nothing = True Then
objConnection = New SqlConnection(ConnStr)
objConnection.Open()
Else

If objConnection.State <> ConnectionState.Open Then
objConnection.Open()
End If
End If
End Sub

Public Sub closeDB()
If objConnection Is Nothing = False Then
objConnection.Close()
objConnection = Nothing
End If
End Sub

End Module