faster page loading

[Soniad]

Hello,
i am using VBScript to load xml file and creating array of xml child nodes. i am retreiving this xml file from server using "Server.mappath". i think due to this process, my asp page is loading slowly. i want to reduce page load time..any suggestions..

Regards,
"D"

[Nicodemas]

I can't agree that use of Server.MapPath() is the cause of the execution time lag.

Can we see some code?

[Soniad]

ya sure..here's the code :


If trim(session("language")) = "" Then
session("language") = "ENGLISH"
End If
Dim xml
Set xml = Server.CreateObject("Microsoft.XMLDOM")
xml.async = False 'Download XML file first, then load rest of page (IE only)

xml.load (Server.MapPath("../../language/"&trim(session("language"))&"/Instant.xml"))


For i = 0 TO (xml.documentElement.childNodes.length - 1)
Set thisChild = xml.documentElement.childNodes(i)
English = thisChild.childNodes(2).Text
ReDim Preserve hindiArray(i)
hindiArray(i) = English
next


xml.async = False '//Download XML file first, then load rest of page (IE only)

xml.load (Server.MapPath("../../language/"&trim(session("language"))&"/common.xml"))

For i = 0 TO (xml.documentElement.childNodes.length - 1)
Set thisChild = xml.documentElement.childNodes(i)
English= thisChild.childNodes(2).Text
ReDim Preserve CmhindiArray(i)
CmhindiArray(i) = English
Next


set xml = Nothing



Regards
"D"

[Nicodemas]

the issue is in your For loop, I believe. My reasons are below, as well as my suggestions:

Change your For loop's counting method. You have this:

For i = 0 TO (xml.documentElement.childNodes.length - 1) 
 

Everytime the loop cycles back, it has to reevaluate the value of xml.documentElement.childNodes.length - 1. Instead of making the processor do that math over and over again, do the following. It's only one computation:

dim stopCount
stopCount = xml.documentElement.childNodes.length - 1
 
For i = 0 to stopCount
 

Second, you have a ReDim statement in your loop. That's really processor intensive because it has to reassign the entire memory space of the array each time you ReDim.

I suggest you use a VBScript dictionary instead.

[Soniad]

@Nicodemas

Thank you ...I have modified the code as below ..and its loading time is much better than before..

stopCount = xml.documentElement.childNodes.length - 1                 
ReDim Preserve hindiArray(stopCount)
 
For i = 0 TO stopCount
    Set thisChild = xml.documentElement.childNodes(i) 
    English = thisChild.childNodes(2).Text 
    'ReDim Preserve hindiArray(i)
    hindiArray(i) = English
next

Regards,
"D"