Need Help! --> ADODB

[bmallett]

I am getting the following error:

Error Type:
ADODB.Command (0x800A0BB9)
Arguments are of the wrong type, are out of acceptable range, or are in conflict with one another.
/dcme/newframe/verify.asp, line 48


Line 48 is:

cmd.Parameters.Append cmd.CreateParameter("UN", adVarChar, adParamInput, 10)

My table is set to text and 10 char

My code is here:

<%
'Connection String
Dim Conn
'Query to be executed
Dim SQLQuery
'Recordset
Dim rs
'UN Of Logged in user
Dim UserName
'PW of User
Dim Password
 
'Getting information from submitted form
UserName = UCase(request.form("username"))
Password = UCase(request.form("password"))
RememberMe = request.form("rememberme")
NewPassword = request.form("newpassword")
NewUser = request.form("newuser")
SessionID=Session.SessionID
 
'Creating connection Object
set Conn=server.createobject("ADODB.Connection")
Conn.Mode = 3
'Creating Recordset Object
'set rs = Server.CreateObject("ADODB.Recordset")
'Initialising Provider String
connStr = "Provider=Microsoft.Jet.OLEDB.4.0;Persist Security Info=False;Data Source="
connStr = connStr + server.MapPath("db/frame.mdb")
 
'Opening Connection to Database
Conn.open  connStr
 
'If not blank Username password submitted
if UserName <> "" or Password <> "" then
 
    'Recordset and Query to be executed
    rs = "select * from [user] where UN = '"&UserName&"' AND PW = '"&Password&"'"
 
    'Retrieving recordset by executing SQL
    'set rs=Conn.execute(SQLQuery)
 
    'If New User selected
        if NewUser = "ON" then
        'Create Entry
        Set cmd = Server.CreateObject("ADODB.Command")
        Set cmd.ActiveConnection = Conn
        cmd.CommandText = "insert into [user] (UN, PW, ssid) values (?, ?, ?)"
        cmd.Parameters.Append cmd.CreateParameter("UN", adVarChar, adParamInput, 10)
        cmd.Parameters.Append cmd.CreateParameter("PW", adVarChar, adParamInput, 10)
        cmd.Parameters.Append cmd.CreateParameter("ssid", adVarChar, adParamInput, 50)
        cmd.Parameters("UN") = UserName
        cmd.Parameters("PW") = Password
        cmd.Parameters("ssid") = SessionID
        cmd.Execute
    else
        end if
 
    'If New Password selected
        if NewPassword = "ON" then
            'Update Password
        Set cmd = Server.CreateObject("ADODB.Command")
        Set cmd.ActiveConnection = Conn
        cmd.CommandText = "UPDATE user SET PW="& Password &" WHERE UN="+ UserName +""
        cmd.Execute
    else
        end if
 
        'If remember me selected
        if RememberMe = "ON" then
            'Writing cookies permanently
            Response.Cookies("UserName")=UserName
            Response.Cookies("Password")=Password
            Response.Cookies("UserName").Expires = Now() + 365
            Response.Cookies("Password").Expires = Now() + 365
            Response.Redirect "basicinfo.asp"
        else
            'writing cookies temporarily
            Response.Cookies("UserName")=UserName
            Response.Cookies("Password")=Password
            Response.Redirect "basicinfo.asp"
        end if
 
    'If no records retrieved
    if rs.BOF and rs.EOF then
        Response.Redirect "Signon.asp?username=" & UserName
    else 
        'Closing all database connections
        Conn.Close
        rs.close   
        set rs = nothing
        set Conn = nothing
    end if
else
    'Invalid User
    Response.Redirect "Signon.asp?UserName=blank"
end if
%>

[jhardman]

Check out the method in the "How-to" section, I think it runs a bit smoother.

Jared

[CroCrew]

Hello bmallett,

You might want to take another look at how your code is set to run and also your database. Table names should not use reserved names within your database. Here is a stab at cleaning/thinning out your code. Please be advised I tried to keep inline with what your were trying to do so even my code is not truly optimized. PM me if you want to talk more in person.

Hope this helps~

<%
    xUserName = replace(request.form("UserName"),"'","''") '<-- User's Name.
    xPassword = replace(request.form("Password"),"'","''") '<-- User's current password.
    xNewPassword = replace(request.form("NewPassword"),"'","''") '<-- New password to be saved if ChangePassword value is true.
    xNewUser = request.form("NewUser") '<-- Make this a boolean (true or false) value.
    xChangePassword = request.form("ChangePassword") '<-- Make this a boolean (true or false) value.
    xRememberMe = request.form("RememberMe") '<-- Make this a boolean (true or false) value.
    xSessionID = Session.SessionID
 
    Set adoCon = Server.CreateObject("ADODB.Connection")
    adoCon.Open "DRIVER={Microsoft Access Driver (*.mdb)}; DBQ=" & Server.MapPath("db/frame.mdb") 
    Set rsUpdate = Server.CreateObject("ADODB.Recordset")
 
    If (xNewUser) Then 
        strSQL = "SELECT TOP 1 * FROM [user]"
        rsUpdate.CursorType = 2
        rsUpdate.LockType = 3
        rsUpdate.Open strSQL, adoCon
        rsUpdate.AddNew
        rsUpdate.Fields("UN").Value = xUserName
        rsUpdate.Fields("PW").Value = xPassword
        rsUpdate.Fields("ssid").Value = xSessionID 
        rsUpdate.Update
        Response.Write("New user has been added.<br>")
    Else
        strSQL = "SELECT * FROM [user] WHERE UN = '" & xUserName & "' AND PW = '" & xPassword & "'"
        rsUpdate.CursorType = 2
        rsUpdate.LockType = 3
        rsUpdate.Open strSQL, adoCon
        If ((rsUpdate.EOF) OR (((StrComp(xPassword, rsUpdate("PW").value) = 0)) Then
            Response.Write("The combination of UserName and Current Password is bad!")
            Response.end
        End If
        If (NewPassword) Then
            rsUpdate.Fields("PW") = xNewPassword 
            rsUpdate.Update 
            Response.Write("Password has been changed.<br>")
        End If
    End If
 
    Response.Write("You are currently login in.")
 
    If (xRememberMe) Then
        Response.Cookies("LocalUser")("CookieTest") = "true"
        If Request.Cookies("LocalUser")("CookieTest") Then
            Response.Cookies("LocalUser")("UserName") = xUserName
            Response.Cookies("LocalUser")("Password") = xPassword
            Response.Cookies("LocalUser").Expires = (Now() + 365)
        Else
            Response.Write("But, you will not be remembered because your cookies are disabled.")
        End If
    End If
%>