insertion into database

[gudipati]

hi i have one checkbox in the form if i check that it should be check in the database field.(in database yes/no field for ckeckbox).what is my problem is every thing is stored except checkbox field.
can u pl correct me?
this is my check box.*******
<input name="current" type="checkbox" id="current" value="">

this is insertion code******

<%
 
        If( (Request("SUBMIT") <> "") and(Request("SUBMIT") = "SUBMIT") ) Then
                set rstinsert = server.CreateObject("ADODB.Recordset")
 
        if Request("radiobutton") = "Ms" then
                salutation = Ms
        elseif Request("radiobutton") = "Mrs" then
                salutation = Mrs
        else
                salutation = Mr
           end if 
 
         lastName=request("lastName")
         middleName=request("middleName")
         firstName=request("firstName")
         if Request("rbpostname")= "Jr" then
           postName=Jr
         else
           postName=Sr
         end if         
         dateBorn=request("dateBorn")
         dateExpired=request("dateExpired")
         cemetaryDetails=request("cemetaryDetails")
         VisitationDetails=request("VisitationDetails")
         ServicesDetails=request("ServicesDetails")
 
         if Request.Form("current") = true then
              rstinsert("current") = "Yes"
         else
             rstinsert("current") = "No"
         end if
        ' dateExpired=Now()
         sqlinsert = "insert into visitations(salutation,lastName,middleName,firstName,postName,dateBorn,dateExpired,cemetaryDetails,VisitationDetails,ServicesDetails,current) values('" & request("radiobutton") & "','" & lastName & "' , '" & middleName & "', '" & firstName & "','" & request("rbpostname") & "','" & dateBorn & "','" & dateExpired & "','" & cemetaryDetails & "' ,'" & VisitationDetails & "','" & ServicesDetails & "', '" & current & "')"   
        ' dbCon.Execute SQL_query
         rstinsert.Open sqlinsert,dbCon,3,2
'         response.Write("added")
         Response.Redirect("visitations.asp?valid=true")
         'response.write(sqlinsert)
         end if
   %>
 

may be i have done mistake in sqlinsert stmt pl correct if u have any idea.currect is the database yes/no field.

[JamieHowarth0]

Hi gudipati,

This question should be in the ASP Forum, not the Articles section (Articles is only to be used for sharing information and not for asking questions).

medicineworker

[jhardman]

         if Request.Form("current") = true then
              rstinsert("current") = "Yes"
         else
             rstinsert("current") = "No"
         end if

These lines

        ' dateExpired=Now()
         sqlinsert = "insert into visitations(salutation,lastName,middleName,firstName,postName,dateBorn,dateExpired,cemetaryDetails,VisitationDetails,ServicesDetails,current) values('" & request("radiobutton") & "','" & lastName & "' , '" & middleName & "', '" & firstName & "','" & request("rbpostname") & "','" & dateBorn & "','" & dateExpired & "','" & cemetaryDetails & "' ,'" & VisitationDetails & "','" & ServicesDetails & "', '" & current & "')"   

don't match with these lines. It looks like maybe "rstinsert" is left over from a previous attempt or some other code snippet. This should work:

dim current
         if Request.Form("current") = true then
              current = "Yes"
         else
             current = "No"
         end if

[/quote]

[gudipati]

hi i tried what u said.still i did't get.

[jhardman]

hi i tried what u said.still i did't get.

which line gives you the error?

[markrawlingson]

if Request.Form("current") = true then

Checkboxes do not return a boolean value. They return, by default, a value of "on" if they are checked, and do not return a value if they are not checked. If you set the value attribute of a checkbox, the checkbox will return that value if it is checked, but it still will not return a value if it is not checked.

With that said, you're also setting your checkbox to a value of "" - so you can never tell whether it was checked or not. Since a checkbox that is not checked will not be returned in the Request.Form object - Request.Form("current") will have a value of "" if it is not checked. If the checkbox IS checked, since you are setting its value="" it will also have a value of "" if it IS checked.

Next...

rstinsert("current") = "Yes"

If you are using access, which i'm assuming you are because you referred to it as a yes/no field, this value should be -1 for yes, and 0 for no.

Here is the proper code.

First your checkbox.

<input type="checkbox" name="current" id="current"/>
 

And the ASP to get the result of the "current" checkbox.

If Request.Form("current") = "on" then
   rstinsert("current") = -1
Else
   rstinsert("current") = 0
End If
 

And finally a suggestion...

In your access database, if you set the default value of a yes/no field to 0 - when a new record is inserted, the value of this field will be false/0/no etc, unless you specifically tell it that it is true/1/yes etc when you are inserting a new record. This make programming yes/no boxes much easier, and your coding much leaner.

If Request.Form("current") = "on" then
   rstinsert("current") = -1
End If
 

In other words, if the checkbox is checked - set the yes/no field to yes. If it not checked, don't do anything because the default value of the yes/no field is automatically no, and we don't have to worry about telling it that it is supposed to be false if the checkbox is not checked.

The last part, of course, is merely a suggestion.