Asp Help!

[shafshaa]

Hi,

I am updating a website for my final year project at university, I was wondering if anyone can help.

I am trying to write a script that allows the user to update their email address.
which is also their login. I have written the following script, however, its just adds the new email address as oppose to replacing it. can anyone tell me where i'm going wrong?

<%

Dim strNEW 'New email string

Dim strCONFIRM 'Confirmed email string

Dim strOLD 'old email address string


strOLD = Trim(Request.Form("User_Login") )

strNEW = Trim(Request.Form("New_email") )

strCONFIRM = Trim(Request.Form("Confirm_email") )

%>



<!--#include file="dbOpen.asp"-->

<%

If (strNew <> strCONFIRM) Then

Response.Redirect("my_email_retry.asp")

Else

'qry="select user_id from tblRegUser WHERE user_Email ='" + strNEW + "'"
'set rsChk = Conn.execute(qry)
'IF rsChk.EOF THEN
Conn.BeginTrans
qry="Insert Into tblRegUser(user_Email) VALUES('" & strNEW & "')"
Conn.execute(qry)
Conn.CommitTrans
'END IF

Response.Redirect("disp_login.asp")


%>

<% End IF %>

[sicarie]

shafshaa-

I'm guessing the ASP forum (on the right-hand side of the page) would probably be a better place for this post.

[jhardman]

why are you using "insert" rather than "update"? This is really starting to perplex me. When I learned SQL, insert was only used on certain occasions, but on this forum people are using it for any old thing. I'd really like to hear your opinion. When should we use "insert" in a SQL statement?

Oh, and here is how I would do it:

        qry="select * from tblRegUser WHERE user_Email ='" + strOLD + "'"
        set rsChk = server.createObject("ADODB.recordset")
        rsChk.open Conn,qry, adOpenDynamic, adLockOptimistic
        if not rsChk.EOF then
            rsChk("user_Email") = strNEW
            rsChk.update
            response.redirect("disp_login.asp")
        else
            'user is not in db, so deal with it as appropriate
            Response.Redirect("my_email_retry.asp")
        end if
 

Jared

[shafshaa]

<%
IF(Request.QueryString("isqry")= "yes") THEN
%>
<!--#include file="dbOpen.asp"-->

<%
Dim strNEW 'New email string
Dim strCONFIRM 'Confirmed email string
Dim strOLD 'old email address string

strOLD = Trim(Request.Form("user_login") )
strNEW = Trim(Request.Form("new_email") )
strCONFIRM = Trim(Request.Form("confirm_email") )

IF (strNew <> strCONFIRM) Then

Session("msg") = "The email addresses you entered did not match. Please try again."
Response.Redirect("change_email.asp?New_email=" & Request("New_email"))
Else


qry="Select user_Email From tblRegUser WHERE user_Email='" & strOLD & "'"
Set rsChk = Conn.execute(qry)


IF rsChk.EOF THEN
Response.write("No matching records found")
END IF

IF NOT rsChk.EOF THEN
Response.write("Found match in existing users")

qry="Update tblRegUser Set user_Email='" & strNEW & "'" & _

" WHERE user_Email = '" & strOLD & "'"

Conn.execute(qry)

Session("msg") = "Your Login (Email-address) Has Been Updated Successfully."

Response.Redirect("myaccount.asp")


END IF '** For rsChk.EOF
END IF
%>
<!--#include file="dbClose.asp"-->

<%

END IF
%>