Improper response.redirect after objConn.execute

[gyung]

Hi, this is my first post but I've been constantly referred to this site when I needed help. Anyway, this time I can't seem to find anything, so here goes.

This is part of my case statement, and I can't figure out why it's having problems. When I use objConn.execute after I check it's not EOF, I will get redirected to the condition that IS EOF, BUT the items is still properly deleted. If I comment out the execute statement, it redirects properly.

Sorry if it's obvious, but I seriously can't see WHY. I have similar code on another page and it works fine.

Thanks in advance!

    case "delete"
 
        cID = cInt(cleanString(request.QueryString("id")))
 
            set rs = Server.CreateObject("ADODB.Recordset")
            SQL = "SELECT cName FROM class WHERE cID = " & cID
            'response.Write(sql)
            'response.End()
            'Open connection
            rs.Open SQL, objConn
 
            if rs.eof then
 
                closeRS(rs)
                closeConn()        
 
                response.Redirect("admin.asp?page=class" & "&statusMsg=failed") 'THIS LINE IS EXECUTED IF I USE objConn.execute IN THE NEXT SECTION
                response.End()    
 
            else
 
                'objConn.open
                objConn.execute("DELETE FROM class WHERE cID=" & cID)
 
                closeRS(rs)
                closeConn()
 
                response.Redirect("admin.asp?page=class" & "&statusMsg=delOK") 'THIS LINE WON'T EXECUTE IF I USE objConn.execute
                response.End()
 
            end if
 
    'end case DELETE

[sashi]

Hi, this is my first post but I've been constantly referred to this site when I needed help. Anyway, this time I can't seem to find anything, so here goes.

This is part of my case statement, and I can't figure out why it's having problems. When I use objConn.execute after I check it's not EOF, I will get redirected to the condition that IS EOF, BUT the items is still properly deleted. If I comment out the execute statement, it redirects properly.

Sorry if it's obvious, but I seriously can't see WHY. I have similar code on another page and it works fine.

Thanks in advance!

    case "delete"
 
        cID = cInt(cleanString(request.QueryString("id")))
 
            set rs = Server.CreateObject("ADODB.Recordset")
            SQL = "SELECT cName FROM class WHERE cID = " & cID
            'response.Write(sql)
            'response.End()
            'Open connection
            rs.Open SQL, objConn
 
            if rs.eof then
 
                closeRS(rs)
                closeConn()        
 
                response.Redirect("admin.asp?page=class" & "&statusMsg=failed") 'THIS LINE IS EXECUTED IF I USE objConn.execute IN THE NEXT SECTION
                response.End()    
 
            else
 
                'objConn.open
                objConn.execute("DELETE FROM class WHERE cID=" & cID)
 
                closeRS(rs)
                closeConn()
 
                response.Redirect("admin.asp?page=class" & "&statusMsg=delOK") 'THIS LINE WON'T EXECUTE IF I USE objConn.execute
                response.End()
 
            end if
 
    'end case DELETE

Hi there,

Kindly refer to below modified code segment, hope it works. Good luck & Take care.

  ..
  ..
  rs.Open SQL, objConn, 1, 3
 
  If rs.RecordCount > 0 Then ' Make sure table is not empty
    If rs.EOF = True Then ' EOF is false
      Response.Redirect "somepage.asp"
      closeRS(rs)
      closeConn()        
    Else ' EOF is true
      objConn.execute("DELETE FROM class WHERE cID=" & cID)
      Response.Redirect "anotherpage.asp"      
      closeRS(rs)
      closeConn()        
    End If
  End If
 

[gyung]

Thanks for your reply!
the recordcount property didn't work for me, so I used count(*), which worked fine. It finds a record, but I'm still getting redirected to the wrong place... I think i'll just have to use another way to validate it.

again if I remove the execute, it works fine. I'm guessing it's somehow running the script twice after execution. Thanks again!

[gyung]

Ok it's driving me nuts, I can't validate the entry before deleting properly AND have the successful message. I'll probably be the one managing the site and DB anyway, but from a programming standpoint i'm hung up about it >.<

[iam_clint]

    case "delete"
 
        cID = cInt(cleanString(request.QueryString("id")))
        set rs = Server.CreateObject("ADODB.Recordset")
        SQL = "SELECT cName FROM class WHERE cID = " & cID
        rs.Open SQL, objConn, 1, 2
        if rs.eof then
            closeRS(rs)
            closeConn()        
            response.Redirect("admin.asp?page=class&statusMsg=failed")
            response.End()    
        else
            'objConn.open
            objConn.execute("DELETE FROM class WHERE cID=" & cID)
            closeRS(rs)
            closeConn()
            response.Redirect("admin.asp?page=class&statusMsg=delOK")
            response.End()
        end if
    'end case DELETE
 

heres my modified version for you... hope it works for ya but cId is a number correct is your cleanstring changing the variable to an int?

[gyung]

Hey thanks a lot. I was away for a while so I didn't check this...

Anyway the execute statements are being... executed.. before the if else statements. I found a workaround for that page by not closing the recordsets. I don't know why that works, but it does.

Sometimes validation in if else statements don't work though... Like for my update page for checking dates, my commands are being sent to the SQL server before anything else is evaluated.

Unless I specifically try using something such as response.write(SQL) followed by response.end(), it will complete execute first.

Why is it doing that??

Thanks again!

[gyung]

Ok...

I'm using

If (--) then
%><script>asdf</script><%
end if

so it's being execute along with the objConn.execute

I just put a response.End() behind the script and it works :)