Locking fields per user rights

[3dcad2011]

Im trying to restict user from certain groups and only allowing them to fill in certain fields. but it seems that the code i have allows all user to enter data can some one help me. the code <

Option Compare Database
 
Private Sub Form_Load()
 
'dim the control
Dim ctl As Control
'If the user is in admin do not lock the fields.
    If IsUserInGroup(1) Then
    'dont lock the form
 
For Each ctl In Me.Controls
    If ctl.ControlType = acTextBox Or ctl.ControlType = acComboBox Then
        ctl.Locked = True
        ctl.BackColor = RGB(200, 200, 200) 'grey
    End If
Next
End If
 
'Production Users unlocked fields
 
If IsUserInGroup(4) Then
    TSubmittedDate.Locked = False
    TRequestor_Name.Locked = False
    TDepartment.Locked = False
    TAreaAffected.Locked = False
    TProjectSummary.Locked = False
    TProjectDetails.Locked = False
    TContactPhoneNo.Locked = False
    TDepartmentManager.Locked = False
    TReqCompletedDate.Locked = False
    TSubmittedDate.BackColor = vbWhite
    TRequestor_Name.BackColor = vbWhite
    TDepartment.BackColor = vbWhite
    TAreaAffected.BackColor = vbWhite
    TProjectSummary.BackColor = vbWhite
    TProjectDetails.BackColor = vbWhite
    TContactPhoneNo.BackColor = vbWhite
    TDepartmentManager.BackColor = vbWhite
    TReqCompletedDate.BackColor = vbWhite
End If
 
End Sub
Function IsUserInGroup(GroupID As Long) As Boolean
 
    If IsNull(Forms!Main_Form!txtUserID) Then
        IsUserInGroup = False
        Exit Function
    End If
 
    Dim X As Long
    X = Nz(DLookup("ID", "GroupXUserT", "UserID=" & Forms!Main_Form!txtUserID & " AND GroupID=" & GroupID))
 
    If X > 0 Then
        IsUserInGroup = True
    Else
        IsUserInGroup = False
    End If
 
 
End Function
 
Function CurrentUserId() As Long
 
    CurrentUserId = Forms!Main_Form!txtUserID
End Function

[NeoPa]

It actually looks like you're locking out only administrators.

Line #13 should probably read :

ctl.Locked = False

That would rely on the Form being set to being locked up by default though.

NB. You should not proceed with any coding until you've read Require Variable Declaration.

[NeoPa]

PS. Lines #53 through #57 could more easily be just :

IsUserInGroup = (X > 0)

[isladogs]

Suggest you use the Tag property to simplify the code used in your code section If IsUserInGroup(4) - lines 21-40.
Assign each of the controls which you want to modify in the same manner with the same tag value e.g. G4. Then loop through the controls and if tag value ="G4", set locked = false and backcolor= vbWhite

Dim ctrl As Control
For Each ctrl In Me.Controls
     If ctrl.Tag = "G4" Then
    ctrl.Locked=False
    ctrl.BackColor=vbWhite
     End If
Next ctrl

[3dcad2011]

whats the tag property

[isladogs]

The tag property can be applied to one or more form controls and can be used for various purposes.
See the MS documentation about the tag property https://support.microsoft.com/en-ie/...on%20a%20form. and https://docs.microsoft.com/en-us/off...ccess.form.tag