Search Criteria Error

[Gwyn Jones]

I am using an example code to filter a form which lists records from a table.

The example database provided allows users to filter records with multiple criteria fields. However, since I have made the same code specific to the names of fields in my table, I receive an error "debug" message when I filter with more than one criteria.

Below is the "Filter" and "Filter Reset" code, with line 80 being highlighted as the problem.

Can anyone tell me what I might be doing wrong?

Private Sub cmdFilter_Click()
    'Purpose:   Build up the criteria string from the non-blank search boxes, and apply to the form's Filter.
    'Notes:     1. We tack " AND " on the end of each condition so you can easily add more search boxes; _
                        we remove the trailing " AND " at the end.
    '           2. The date range works like this: _
                        Both dates      = only dates between (both inclusive. _
                        Start date only = all dates from this one onwards; _
                        End date only   = all dates up to (and including this one).
    Dim strWhere As String                  'The criteria string.
    Dim lngLen As Long                      'Length of the criteria string to append to.
    Const conJetDate = "\#mm\/dd\/yyyy\#"   'The format expected for dates in a JET query string.
 
    '***********************************************************************
    'Look at each search box, and build up the criteria string from the non-blank ones.
    '***********************************************************************
    'Text field example. Use quotes around the value in the string.
 
    'Customer Name
    If Not IsNull(Me.txtFilterCustomerName) Then
        strWhere = strWhere & "([Customer Name] = """ & Me.txtFilterCustomerName & """) AND "
    End If
 
    'Hours
    If Not IsNull(Me.txtFilterHours) Then
        strWhere = strWhere & "([M1 Hours] = """ & Me.txtFilterHours & """) AND "
    End If
 
    'Another text field example. Use Like to find anywhere in the field.
 
    'Serial No
    If Not IsNull(Me.txtFilterSerial) Then
        strWhere = strWhere & "([M1 Serial] Like ""*" & Me.txtFilterSerial & "*"") AND "
    End If
 
    'Issues
    If Not IsNull(Me.txtFilterIssues) Then
        strWhere = strWhere & "([Issues] Like ""*" & Me.txtFilterIssues & "*"") AND "
    End If
 
     'Actions
    If Not IsNull(Me.txtFilterActions) Then
        strWhere = strWhere & "([Details] Like ""*" & Me.txtFilterActions & "*"") AND "
    End If
 
    'Number field example. Do not add the extra quotes.
    'If Not IsNull(Me.cboFilterHours) Then
        'strWhere = strWhere & "([M1 Hours] = " & Me.cboFilterHours & ") AND "
    'End If
 
    'Yes/No field and combo example. If combo is blank or contains "ALL", we do nothing.
    If Me.cboFilterFurtherAction = -1 Then
        strWhere = strWhere & "([Further Action] = True) AND "
    ElseIf Me.cboFilterFurtherAction = 0 Then
        strWhere = strWhere & "([Further Action] = False) AND "
    End If
 
    'Date field example. Use the format string to add the # delimiters and get the right international format.
    If Not IsNull(Me.txtStartDate) Then
        strWhere = strWhere & "([Visit Date] >= " & Format(Me.txtStartDate, conJetDate) & ") AND "
    End If
 
    'Another date field example. Use "less than the next day" since this field has times as well as dates.
    If Not IsNull(Me.txtEndDate) Then   'Less than the next day.
        strWhere = strWhere & "([Visit Date] < " & Format(Me.txtEndDate + 1, conJetDate) & ") AND "
    End If
 
    '***********************************************************************
    'Chop off the trailing " AND ", and use the string as the form's Filter.
    '***********************************************************************
    'See if the string has more than 5 characters (a trailng " AND ") to remove.
    lngLen = Len(strWhere) - 5
    If lngLen <= 0 Then     'Nah: there was nothing in the string.
        MsgBox "No criteria", vbInformation, "Nothing to do."
    Else                    'Yep: there is something there, so remove the " AND " at the end.
        strWhere = Left$(strWhere, lngLen)
        'For debugging, remove the leading quote on the next line. Prints to Immediate Window (Ctrl+G).
        'Debug.Print strWhere
 
        'Finally, apply the string as the form's Filter.
        Me.Filter = strWhere
        Me.FilterOn = True
    End If
End Sub
 
Private Sub cmdReset_Click()
    'Purpose:   Clear all the search boxes in the Form Header, and show all records again.
    Dim ctl As Control
 
    'Clear all the controls in the Form Header section.
    For Each ctl In Me.Section(acHeader).Controls
        Select Case ctl.ControlType
        Case acTextBox, acComboBox
            ctl.value = Null
        Case acCheckBox
            ctl.value = False
        End Select
    Next
 
    'Remove the form's filter.
    Me.FilterOn = False
End Sub

[Gwyn Jones]

I think the problem may be with lines 23-26. This is purely a NUMBER field with a TEXT based criteria. It seems If I have take out these lines, the code works just fine.

Can anyone tell me how I should change this purely for a number field?

Many thanks.

[sierra7]

Hi
There is obviously something wrong with the syntax of the Filter String.

Line #77 will allow it to be printed in the debug window for viewing, however you may just write

MsgBox strWhere

to display in a messagebox.

To start with, check that string values have single quotes around them and dates have # around them, and that all fieldnames are spelt correctly.
S7

[TheSmileyCoder]

If its a text based field match, you should use syntax like shown in lines 18-21.

If its a numeric match, you should use syntax like shown in lines 45-48.

When posting anything related to an error message, you should ALWAYS give the error number, as well as the error description.

If the above information does not help you, you will need to post the field types for all your fields.

[sierra7]

Hi Gwyn
It seems our messages crossed

If what is the content of Me.txtFilterHours? Whole hours, decimal hours or hours and minutes with a colon (:) separator?
S7

[NeoPa]

Gwyn Jones:
This is purely a NUMBER field with a TEXT based criteria.

In that case I would say you should replace line #25 with :

strWhere = strWhere & "([M1 Hours] = " & Me.txtFilterHours & ") AND "

NB. Line #81 sets Me.FilterOn to True yet nowhere is it ever reset. I'd remove that line and add the following after the current line #82 :

Me.FilterOn = (strWhere > "")