DeleteControl For..Each Control in Form, arbitrary behaviour

[Knut Ole]

im trying to delete all existing controls in a form before creating new ones... however, it wont delete all the controls. for every code run i create 6 controls, but for every run the "For Each" frmSub1.Controls will only delete 3. actually, if i start out with 0 controls on my form, the first run 0 will be deleted, and 6 made. second run, 3 will be deleted, 6 made (total = 9). third run, it will delete 5, add 6 (total = 10), same fourth run (tot=11), then stabilize on 6 deletions and 6 additions (tot=11) for every run after that... (when i want all to be deleted every time!)

why arent "For Each ctl In Forms!frmSub1.Controls" picking up all the controls?

thanks!

Public Function makeArrows()
 
    Dim lngColor As Long
    Dim str1
    Dim str2
    Dim n As Integer
    Dim RecSet As Recordset
    Dim DatePoint As Recordset
 
    Set DatePoint = CurrentDb.OpenRecordset("DatePointer")
    Set RecSet = CurrentDb.OpenRecordset("CalQarrows")
    lngColor = RGB(0, 255, 0)
 
 
    c = DatePoint.Fields("RStartDate").Value 'access day# for manual datepicker in calendar
    d = 0
 
    '// some way of picking each room/subform
    Forms!Calendar!ctrlSub1.SourceObject = ""
    n = 1
    str1 = "frmSub" & n
    DoCmd.OpenForm str1, acDesign, , , acFormEdit, acHidden
    '// delete all controls
    Dim ctl As Control
    o = 0
    For Each ctl In Forms!frmSub1.Controls
        o = o + 1
        'MsgBox str1 & " / " & ctlDel.Name
        'MsgBox str1
        DeleteControl str1, ctl.Name
    Next ctl
    MsgBox o
 
    Do Until RecSet.EOF
        If RecSet.Fields("RoomNumber").Value = 105 Then
 
        d = d + 1
 
        a = (RecSet.Fields("SlotBegin").Value - c) * 1000
        b = (RecSet.Fields("SlotLength").Value * 1000)
        bookID = RecSet.Fields("Bookings.ID").Value
        bookNameS = RecSet.Fields("NameString").Value
        bookFullName = RecSet.Fields("LastName").Value & ", " & RecSet.Fields("FirstName").Value
        bookDate = RecSet.Fields("INdate").Value & " @ " & RecSet.Fields("INtime").Value & " to " & RecSet.Fields("OUTdate").Value & " @ " & RecSet.Fields("OUTtime")
 
 
 
        Set cImg1 = CreateControl(str1, acImage)
        cImgn = cImg1.Name
        Forms!frmSub1!(cImgn).BackStyle = 0
        Forms!frmSub1!(cImgn).Width = 432
        Forms!frmSub1!(cImgn).Height = 360
        Forms!frmSub1!(cImgn).Left = a
        Forms!frmSub1!(cImgn).Top = 0
        Forms!frmSub1!(cImgn).ControlTipText = bookFullName
        Forms!frmSub1!(cImgn).OnClick = ""
        Forms!frmSub1!(cImgn).Picture = "C:\Users\Lailita\Documents\arrows\yellowA.png"
 
        Set cImg2 = CreateControl(str1, acImage)
        cImg2n = cImg2.Name
        Forms!frmSub1!(cImg2n).BackStyle = 0
        Forms!frmSub1!(cImg2n).Width = 432
        Forms!frmSub1!(cImg2n).Height = 360
        Forms!frmSub1!(cImg2n).Left = a + b
        Forms!frmSub1!(cImg2n).Top = 0
        Forms!frmSub1!(cImg2n).Picture = "C:\Users\Lailita\Documents\arrows\yellowAh.png"
 
        Set cLbl1 = CreateControl(str1, acLabel)
        cLbln = cLbl1.Name
        Forms!frmSub1!(cLbln).Visible = True
        Forms!frmSub1!(cLbln).BackColor = RGB(255, 194, 14)
        Forms!frmSub1!(cLbln).ForeColor = RGB(255, 255, 255)
        Forms!frmSub1!(cLbln).FontWeight = 900
        Forms!frmSub1!(cLbln).TopMargin = 34
        Forms!frmSub1!(cLbln).TextAlign = 2
        Forms!frmSub1!(cLbln).BackStyle = 1
        Forms!frmSub1!(cLbln).Top = 0
        Forms!frmSub1!(cLbln).Height = 350
        Forms!frmSub1!(cLbln).Left = a + 250
        Forms!frmSub1!(cLbln).Width = b
        Forms!frmSub1!(cLbln).Caption = bookNameS
        Forms!frmSub1!(cLbln).ControlTipText = bookFullName & ": " & bookDate
 
        End If
 
    RecSet.MoveNext
    Loop
    MsgBox "no of recset loops is " & d
    Dim ctlCheck As Control
    p = 0
    For Each ctlCheck In Forms!frmSub1.Controls
        p = p + 1
        'MsgBox str1 & " / " & ctlDel.Name
        'MsgBox str1
        'DeleteControl str1, ctl.Name
    Next ctlCheck
    MsgBox "total controls at build end is " & p
    DoCmd.Close acForm, str1, acSaveYes
    Forms!Calendar!ctrlSub1.SourceObject = str1
 

[TheSmileyCoder]

Because imagine looping through an array of controls, where first you delete the first element, then proceed to delete the second element and so on. Problem is that as you delete the first element, the remaining controls "move down".
This behavior is something you need to be wary of, when using for each in combination with deletions and maybe also additions.

Instead you can use:

Do While Forms!frmSub1.Controls.Count>0
 Forms.Controls(0).Delete
Loop

Maybe the 0 should be a 1, not 100% sure.

[Knut Ole]

thanks, looks clean - but i get a object not supported for the .Delete line..?
but this worked now:

Do While Forms!frmSub1.Controls.Count > 0
        For Each ctl In Forms!frmSub1.Form.Controls
        DeleteControl str1, ctl.Name
        Next ctl
    Loop
 

so thank you very much!!

[TheSmileyCoder]

Sorry, I didn't have the correct syntax in front of me when I wrote the last post.

A small modification to your code if I may, to make it nicer:

    Do While Forms(strFormName).Controls.Count > 0
        DeleteControl strFormName, Forms(strFormName).Controls(1).Name
    Loop

[NeoPa]

I don't know if performance is an issue, but to save the object references to be worked out each time through the loop :

With Forms(strFormName).Controls
    Do While .Count > 0
        Call DeleteControl(strFormName, .Item(0).Name)
    Loop
End With