seeDBChanges and Too few Parameters

[vikD]

Hi I have one table which I upsized to SQL Server 2005 from access. Everything seems to work fine when I use "dbOpenDynaset, [dbSeeChanges]" when needed for tbl_Clients (the table on SQL Server) but this I can't seem to make work....

sql = "SELECT tbl_Users.sFirstname as sFN, tbl_Users.sLastname, tbl_Artists.lngClientNumber as sLN, tbl_Clients.sEmail as sE, * "
sql = sql & "FROM tbl_Users RIGHT JOIN tbl_Clients ON tbl_Users.lngUserID = tbl_Clients.lngUserID "

If chkUnsubscribe = 1 Then
sql = sql & "WHERE tbl_Clients.bUnsubscribe= 0 "
End If


Set rsSource = db.OpenRecordset((sql), dbOpenDynaset, dbSeeChanges)

Any ideas??
Thanks in advance

[Rabbit]

You have * in there but you didn't qualify which table to get all fields from.

[munkee]

You are also using "sql" as a variable which is a reserved word. If it hasn't caused issues yet then it will likely in the future use something like strSql instead.

[vikD]

Hmmm no dice I changed it and still the same too few parameters....

strsql = "SELECT tbl_Users.sFirstname as sFN, tbl_Users.sLastname, tbl_Artists.lngClientNumber as sLN, tbl_Clients.sEmail as sE, tbl_Clients.* "
strsql = strsql & "FROM tbl_Users RIGHT JOIN tbl_Clients ON tbl_Users.lngUserID = tbl_Clients.lngUserID "


If chkUnsubscribe = 1 Then
strsql = strsql & "WHERE tbl_Clients.bUnsubscribe= 0 "
End If


Set rsSource = db.OpenRecordset((strsql), dbOpenDynaset, dbSeeChanges)

[Rabbit]

Does that SQL string work outside of code?

[vikD]

Ohhh I'm an idiot. I inherited this code and it used to work until I upsized. After looking at the SQL it was messed up to begin with. The seeDBChanges was the solution.

Guess the moral is don't assume just because it works it's correct.

Thanks All!!