Error 3061, Too few parameters Expected 1

[tasawer]

Hi,

I need to add a new record to table "ACC_Vehicle", with three pieces of information.
When I activate the code, I get the error "Error 3061, Too few parameters Expected 1"

ACCVehicleID is the Autonumber field.
Reg is a required field.

Your help is appreciated.

DIM NewACCVehicleID As Long
DIM strVehicleInsert As String
 
NewACCVehicleID = DMax("ACCVehicleID", "ACC_Vehicle") + 1
strVehicleInsert = "INSERT INTO [ACC_Vehicle] ( ACCVehicleID, Reg, Make, Model ) " & _
"SELECT " & NewACCVehicleID & " As NewID, Reg, VehicleMake, VehicleModel " & _
"FROM [tbl_Accident] WHERE AccidentID = " & Me.AccidentId & ";"
DBEngine(0)(0).Execute strVehicleInsert, dbFailOnError
 

[patjones]

One issue I see here is that you are trying to manually assign the ID. If this is an autonumber column, Access will automatically assign the ID according to what the next number in the existing sequence is. Thus, you should only need to include your other columns in the INSERT.

You can get a feel for this concept by opening the table in datasheet view and entering a record by hand. Access will fill in the autonumber ID column for you.

I might add however, that if your ID column weren't an autonumber, using DMax to obtain the highest existing ID and incrementing it by 1 to get the next ID is a great way to manually assign ID's.

Pat

[tasawer]

HI,

Thanks for your reply.

I have used Reg as the new id and now it works succefully (Code Below).
Service field determines if the vehicle is in repair or not. I have set this field to true.

If the vehicle is in repair (Service=true) I wish to disable a command button.
This code gives me "invalid use of Null".
however, if all details are entered manually into the ACC_Vehicle table, then this code does not give an error)

DIM inService As Boolean
inService = DLookup("Service", "ACC_Vehicle", "ACCVehicleID=" & Me.ACCVehicleID)
Me.cmdRepairInvoice.Enabled = Not inService
 

SQL to insert New data (all fields are inserted as expected)

strVehicleInsert = "INSERT INTO [ACC_Vehicle] ( Reg, Make, Model, Service, VehicleOwnerID ) " & _
"SELECT '" & Me.RegNo & "' As NewID, VehicleMake, VehicleModel, -1, '" & txtContactID & "' " & _
"FROM [tbl_Accident] WHERE AccidentID = " & Me.AccidentId & ";"
DBEngine(0)(0).Execute strVehicleInsert, dbFailOnError

[patjones]

This happens with aggregate functions (DLookup, DMax, etc.) when the function can't find anything. If you set var = DLookup(...) and DLookup doesn't return anything, then var is set to null.

So somehow your DLookup call is not returning anything. It is always good procedure to put a DLookup call inside Nz() to account for the possibility of getting no results and avoiding a null value.

Naturally, you might also want to determine why your DLookup is not returning a result in the first place.

Pat