handle error in save button because of (docmd.Requery)

[mseo]

hi, I am developing a form for adding employees where you can find three fields in the table employees (firstname, middlename, lastname, hiredate (Is Not Null)
and ADezii prompt me to use this code and it gives me the msgboxes which I need to be viewed to the user but after that It gives me an error because the code which I used for save cmdbutton is

private sub save_click()
docmd.save
docmd.requery  (the error because of this I think)
end sub

Private Sub Form_BeforeUpdate(Cancel As Integer) 
If IsNull(Me![firstname]) Then 
  MsgBox "You must enter a First Name before this Record can be saved" 
    Cancel = True: Me![firstname].SetFocus 
ElseIf IsNull(Me![middlename]) Then 
  MsgBox "You must enter a Middle Name before this Record can be saved" 
    Cancel = True: Me![middlename].SetFocus 
ElseIf IsNull(Me![lastname]) Then 
  MsgBox "You must enter a Last Name before this Record can be saved" 
    Cancel = True: Me![lastname].SetFocus 
ElseIf IsNull(Me![hiredate]) Then 
  MsgBox "You must enter a Hire Date before this Record can be saved" 
    Cancel = True: Me![hiredate].SetFocus 
End If 
End Sub 

please help me handling this problem because I want to make a form for adding employees without any error
thanks in advance for any help you may provide me

[Delerna]

you don't tell us what the error is ???

Perhaps using

me.requery

might solve it.

[NeoPa]

Mseo,

It's really no good at all posting in code that you write out freestyle. This wastes everybody's time and energy.

When posting any code on here please :

1. Ensure you have Option Explicit set (See Require Variable Declaration).
2. Try to compile it. If it doesn't compile for any reason please explain that clearly - including the error message and which line of your code it appears on. Compilation is done from the Visual Basic Editor menu - Debug \ Compile Project (Where Project is the actual name of your project).
3. Copy your code (using the Clipboard - Cut / Copy / Paste) from your project directly into your post. Typing in code is not appreciated as it is likely to introduce typos which cause members to waste their time unnecessarily.
4. Ensure that the code in your post is enveloped within CODE tags. The hash (#) button in the posting page helps with this. Simply select your code and click on the hash button to have it enveloped automatically.

If all these points are covered then all members will be better able to understand, and therefore attempt to answer, your question.

[NeoPa]

When you've posted the code properly, you will need to include exactly which line caused the error message (Don't just guess. Find out before posting.) and post the error message itself. Error messages are there for a reason. They are there to help people determine what the problem is and fix it. Posting the problem without the message is just wasting people's time.

[mseo]

the error is
3021 No Current record
comes from this line (Me.Requery)

[Delerna]

The error suggests that it might be coming from the previous line

docmd.save
 

The reason I say that is that the error suggests that an operation (save) on a record is being attempted but there is no record for that operation to work on.

Not sure why that is, and there is not much info to go off.

The form is bound to a table .... right ?

Or if you are binding the form to a query...it is an updatable query?

Sometimes when creating queries, they can become unable to make updates because of the way they are constructed. You can tell if you run the query directly. The create new record button will be greyed out

[topher23]

It looks to me like you may not understand how to use the right methods of the DoCmd object. The method you're using (DoCmd.Save) will save the current form, not the data in the form. You should use

DoCmd.RunCommand acCmdSaveRecord 

to save the record, then Me.Requery will probably work correctly.

Also, it is helpful to know which version of Access you're using (2000, 2003, 2007, etc.) so we can help you better.

[NeoPa]

@mseo
It's so tedious writing the same thing twice.

Please refer back to post #5 :

1. Post the code properly.
2. Indicate exactly the correct line the error was triggered by (Don't just guess. Find out before posting.) Clearly not the one you claim.

The error message is correct at least.

[Delerna]

Another point to consider.
Microft has for a long long time (since 1998 I think) been discouraging the use of docmd stating that it will eventually become obsolete and removed.

Yea right, 11 years later its still there.
Anyway, I hardly ever use it anymore
about the only thing I ever use it for is

docmd.SetWarnings
 

Oh, and I agree with Neopa whole heartedly
Its very difficult to help you without those basic steps on your part.

[topher23]

@Delerna
Hah! Yeah, when I was upgrading to 2000, I was told that MS was "deprecating" the DoCmd object, and that I should start using macros instead. Yeah, right (I was programming in BASIC almost before I was out of diapers, what do you mean, macros?!). Yet, with 2007, they've added 13 new methods to the DoCmd object and there is no mention on any MS resource of any plans to get rid of it. I'd say it's safe as long as there are pure programmers out there who like to avoid macros whenever possible.

Sorry, don't wanna hijack the thread. mseo, any news or progress?

[NeoPa]

There's only so much a software provider can do as far as removing facilities goes from a popular product.

Unfortunately, they seem to have found a way to make pure coders suffer with the security difficulties they've put in the way of allowing code to run. This is part of their push to encourage the usage of macros (It obviously makes life much easier for them). Let's hope they continue to find it unprofitable to emasculate the code side of things - otherwise there would really be no reason not to switch to OpenOffice.

[mseo]

hi,
I didn't intend to make duplicate thread but i don't know how to follow up or submit more detail about my question
I used this

RunCommand acCmdSaveRecord 

in stead of

docmd.save

but get two error
1- run-time error 2046 (the command or action "saverecord" isn't available now
2- if the Id generated and I press save I get error 3021 (no current record)
thanks

[NeoPa]

I will move this for you now, but each post of each thread has a link (bottom right of the post) to Quote that post and include it in a reply, which is appended to the end of the thread. Also, each thread has a Quick Reply section where you can type in what you want and click on the button to submit it.

I suggest also, that you read all the responses you get and respond to them. I have two posts in your thread that instruct you (not a request - this is an instruction I am giving you as an administrator) on what you must do before continuing to ask for more help. Responding to this is not optional. You must do so or receive an infraction for breaking the rules.

Whether you respond to other posts is a matter of good manners. We prefer you to show that, but not doing so is not something we discipline for.

If there is any point (like here where you weren't able to follow the instructions without further explanation) that you are confused about then please just say so and I will endeavour to explain more clearly.

[topher23]

@NeoPa
Is that twenty-two or two-plus-two? = )

I'm getting to the point where I'm wondering what's going on behind this form, as there appear to be some real problems here.

mseo, you may want to spend some time studying the "Northwind.mdb" database that ships with Access. If you don't have that on your system, you can download the Access 2000 version (the only version available for download) at http://www.microsoft.com/downloads/d...displaylang=EN

[NeoPa]

@topher23
Good spot. Fixed now thanks.

[mseo]

the version of microsoft access is 2003

[mseo]

hi,
this code for save button for handling the 3021 error and any other error which happen during the save action

Private Sub Save_Click()
On Error GoTo Err_Save_Click
    DoCmd.DoMenuItem acFormBar, acRecordsMenu, acSaveRecord, , acMenuVer70
Exit_Save_Click:
    Exit Sub
Err_Save_Click:
    MsgBox Err.Description, vbDefaultButton1 + vbCritical + vbOKOnly, "Hi-Tech SysAdmin"
    Resume Exit_Save_Click
End Sub

but when I click save the command excutes the save command but I need to set the form to new record after saving the previous one but using the same code
the second question is how can attach ms-access in here?
thank you

[Delerna]

something like

DoCmd.gotoRecord acNewRecord
 

which would also save any unsaved changes to the current record before moving on to the new record....if memory serves me correctly

[topher23]

Delerna's almost got it. In specific, its

DoCmd.GoToRecord , , acNewRec

However, you can find that easily in the help file, or as an answer on countless threads spread across the Internet. Really, it would be so much better for you, mseo, if you'd look for the answer yourself before posting it up as a question.

[topher23]

As for the second question about attaching your database, see these guidelines by NeoPa, then click "Manage Attachments" in the "Additional Options" section of the advanced reply page. From there, you should be able to handle it. @NeoPa

[mseo]

hi, the problem is not about saving the uncurrent changes before moving to new record but it is all about how to move to the next record, excuse me because this code must be included within the previous code I posted and I really tried this code

docmd.gotorecord,, acrec

and nothing changed the same thing appears for me the save record in unavailable error number 3046
and I didn't mean to tease anyone but I am in real problem so I want attach the database form to see the real problem yourselves.
thanks

[mseo]

hi,
I attached the form which I have the problem with
please try to help me handling it
thanks

[topher23]

Okay, this code works in the OnClick event of your save button without issue. I added 3 different Star Wars characters in a row with it.

Private Sub Save_Click()
On Error GoTo Err_Save_Click
    DoCmd.RunCommand acCmdSaveRecord
    DoCmd.GoToRecord , , acNewRec
Exit_Save_Click:
    Exit Sub
Err_Save_Click:
    MsgBox Err.Description
    Resume Exit_Save_Click
End Sub
 

Also, your "Close" button is hiding behind the tab control. As soon as you click on a text box, you lose the button, but if you click where it "should" be, it closes the form. To fix this, open the form in design view, selec the Close button and go to Format > Move To Front on the Menu bar.

Let us know if you have more issues.

[topher23]

Slight modification to the code. This makes it so that when the update is cancelled because the user didn't type in everything, it doesn't give them a "RunCommand has been cancelled." dialog box by telling the error handler not to display anything when that specific error code pops up.

Private Sub Save_Click()
On Error GoTo Err_Save_Click
    DoCmd.RunCommand acCmdSaveRecord
    DoCmd.GoToRecord , , acNewRec
Exit_Save_Click:
    Exit Sub
Err_Save_Click:
    Select Case Err
    Case 2046, 2501
        'do nothing
    Case Else
        MsgBox Err & ", " & Err.Description
    End Select
    Resume Exit_Save_Click
End Sub
 

[mseo]

thanks topher23 for your answer it is the really best answer
but I get error msg for error 3021

[NeoPa]

Mseo - Please check your PMs.

I need a confirmation of receipt from you when you've read it please.

[topher23]

I spent a bit more time with your form, and the only way was able to replicate a 3021 error was when I tried to save the record without filling out all of the required fields.

If an error is being generated and you know you can just ignore it because it's not really an error, add it to the Case statement from the last post:

@topher23
So it looks like

    Case 2046, 2501, 3021
 

The only problem with this is that sometimes you might ignore a legitimate error, so it's best to make sure that the only way that specific error is generated is in a way that is safe to be ignored.