Trying to update a combo box using a command button or report event

[Richard Penfold]

I have a form with a subform containing the combo box I want to update. I have a command button in the header of the main form that launches a report in print preview mode. I want to update the combo box from 'New' to 'Confirmed' when the report is generated. I have tried the following code in both the buttons on_click event and in the reports on_close event (security is set to trust the db)

Forms![Transactions]![Transaction Details Subform].[Form]![OrderStatusID]="1"

There are no errors but it does not work.
Can someone help.
NB: There is a one-to-many relationship between the underlying tables of the main and sub forms so multiple instances of the combo box may appear on the form - All need to be updated.

[DonRayner]

Your syntax is slightly off.

Forms![Transactions]![Transaction Details Subform].[Form]![OrderStatusID]="1"
 

should be

Forms![Transactions].Form![Transaction Details Subform]![OrderStatusID]="Confirmed"
 

[NeoPa]

Can you perhaps share with us how this ComboBox is set up Richard?

We don't really have enough info to determine what your problem may be. .RowSource, .ColumnCount, .ColumnWidths & .BoundColumn properties would be most helpful to start with.

[NeoPa]

@DonRayner
I'm sorry Don. I feel you may be mistaken here.

Check out Referring to Items on a Sub-Form. The .Form property is relative to the SubForm control.

[Richard Penfold]

Many thanks for the help so far.
NeoPa
The Combo Box control details are as follows:
Control Source = Transactions.OrderStatusID
Row Source = SELECT [Order Status].ID, [Order Status].OrderStatus FROM [Order Status];
Format: Column Count = 2: Column Width = 0cm;2.5cm.

All
I have implemented the code suggested with one minor change as follows:

Private Sub Report_Close()
Forms![Transactions]![Transaction Details Subform]![OrderStatusID] = 2
End Sub

This code updates one instance of the control on my form. There can be multiple instances however. As a simplified representation, the form looks like this...

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 
Main Form
CustomerName : OrderNumber : Date : Comments
 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 
Sub Form
New: Qty : OrderCode : Description  
New: Qty : OrderCode : Description  
New: Qty : OrderCode : Description  
...etc
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Where 'New' is the default value of the 'OrderStatusID' control I want to update

When I run the code (close the report) I get this...

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 
Main Form
CustomerName : OrderNumber : Date : Comments
 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 
Sub Form
Confirmed  : Qty : OrderCode : Description  
New        : Qty : OrderCode : Description  
New        : Qty : OrderCode : Description  
...etc
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

A customer may request many items on any one order. - I want to confirm all of them at once.

[NeoPa]

Ah. That's quite a different question then (at least a fundamentally different answer now the question is clearer).

For this you will want instead, to update the records in the table (using some simple SQL) and then call a .Requery of the subform.

We don't have the details of any filtering or linking that restricts the data on your subform, but you will need to design SQL to reflect the same records in your update query (SQL).

If you need help with this then please reply including the info we would need to be able to show this for you.

[Richard Penfold]

Thanks NeoPa. I'll give it a go myself over the weekend and let you know the outcome.

[NeoPa]

Please do Richard.

Good luck :)

[Richard Penfold]

Hi,
After much brain wracking I have to admit defeat. Can you tell me what's wrong with this...

Private Sub Report_Close()
Update [Transaction Details] Set OrderStatusID = 2
WHERE ((([Transaction Details].TransactionID) = [Forms]![Transactions]![Transaction Details Subform].[Form]![TransactionID]))
End Sub

I just get a syntax error.
I have tried various combinations of bracket types and quote marks. I also tried renaming the table to remove the space - Still no-go.

[NeoPa]

Yes. I can.

Fundamentally you are trying to execute SQL code as VBA code.

I'll have a look at it and see what I can do, but you need to create your SQL string first using VBA, then pass that string to be executed as SQL.

[NeoPa]

Try this :

Private Sub Report_Close() 
  Dim strSQL As String
 
  strSQL = "Update [Transaction Details] " & _
           "Set OrderStatusID = 2 " & _
           "WHERE [Transaction Details].TransactionID=" & _
           [Forms]![Transactions]![Transaction Details Subform]![TransactionID]
  Call CurrentDb.Execute(strSQL)
End Sub

[Richard Penfold]

Hi NeoPa,
Your code works beautifully, many thanks.

I guess there is a VBA equivalent to the code I used but I did not find an example on the web. Does the "Dim nnn As String, nnn = and Call" wrapper to sql code work in all such instances?

[NeoPa]

It should work for all executable queries, yes.