Subscript out of range: 'f'

[jerrydfowlerjr]

This is driving me crazy, I am by no means a pro at this, but I am trying to figure out why this error is popping up, please help, I feel like it is simple..

I am going to post the code and bold and underline the line that is throwing the error

sub addVariations(pOptionGroupDescrip, pOptionDescrip, pPriceToAdd, pPercentageToAdd, pIdProduct)
 
 dim rstemp, pIndex  
 
 if pOptionGroupDescrip<>"" then
 
  arrayOptions      =split(pOptionDescrip,",")
  arrayPrices       =split(pPriceToAdd,",")         
  arrayPercentage       =split(pPercentageToAdd,",")         
 
  ' verification
  if arrayOptions(0)="" then
    response.redirect "comersus_backoffice_message.asp?message="& Server.Urlencode("If you need variations please fill every variation in order")
  end if
 
   '  add option group 
   mySQL="INSERT INTO optionsGroups (optionGroupDesc, type) VALUES ('" &pOptionGroupDescrip & "','D')"
   call  updateDatabase(mySQL, rstemp, "itemFunctions.asp")  
 
   ' retrieve optionGroupId
 
   mySQL="SELECT MAX(idOptionGroup) AS maxIdOptionGroup FROM optionsGroups WHERE optionGroupDesc='" & pOptionGroupDescrip& "'"
   call  getFromDatabase(mySQL, rstemp, "itemFunctions.asp") 
 
   if rstemp.eof then        
     response.redirect "comersus_backoffice_message.asp?message="& Server.Urlencode("Cannot get option group ID")
   end if  
 
   pIdOptionGroup=rstemp("maxIdOptionGroup")       
 
   ' add options
 for f=0 to 3
 
   if arrayOptions(f)<>"" and (arrayPrices(f) <> "" or arrayPercentage(f) <> "") then
       mySQL="INSERT INTO options (optionDescrip, priceToAdd, percentageToAdd) VALUES ('" & arrayOptions(f) & "'," & arrayPrices(f)& "," & arrayPercentage(f) & ")"     
 
        call  updateDatabase(mySQL, rstemp, "itemFunctions.asp")  
 
        ' get idOption
 
        mySQL="SELECT MAX(idOption) AS maxIdOption FROM options WHERE optionDescrip='" & arrayOptions(f) & "'"
 
        call  getFromDatabase(mySQL, rstemp, "itemFunctions.asp") 
 
        if rstemp.eof then        
             response.redirect "comersus_backoffice_message.asp?message="& Server.Urlencode("Cannot get option ID")
        end if     
 
        pIdOption=rstemp("maxIdOption")   
 
        ' assign to group
        mySQL="INSERT INTO options_optionsGroups (idOption, idOptionGroup) VALUES (" & pIdOption & "," & pIdOptionGroup & ")"
 
        call  updateDatabase(mySQL, rstemp, "itemFunctions.asp")  
 
   end if
 
   next
 
   ' assign group to product
    mySQL="INSERT INTO optionsGroups_products (idOptionGroup, idProduct) VALUES (" & pIdOptionGroup & "," & pIdProduct & ")"
 
    call  updateDatabase(mySQL, rstemp, "itemFunctions.asp")  
 
  end if ' filled
 
end sub
 
 
sub loadProductVariations(pIdProduct, arrayOptions1, arrayOptions2, pHiddenIdOptions, pOptionDescrip1, pOptionDescrip2, pIdOptionGroup1, pIdOptionGroup2)
 
  dim rstemp
 
  ' retrieve option groups
 
  mySQL="SELECT optionsGroups.idOptionGroup, optionGroupDesc FROM optionsGroups_products, optionsGroups WHERE optionsGroups.idOptionGroup=optionsGroups_products.idOptionGroup AND idProduct=" &pIdProduct
  call getFromDatabase(mySQL, rstemp, "getOptions") 
 
  pIdOptionGroup1=0
  pIdOptionGroup2=0  
 
  do while not rstemp.eof 
 
    if pIdOptionGroup1=0 then
      pOptionDescrip1=rstemp("optionGroupDesc")
      pIdOptionGroup1=rstemp("idOptionGroup")
    else
      pOptionDescrip2=rstemp("optionGroupDesc")
      pIdOptionGroup2=rstemp("idOptionGroup")
    end if
 
  rstemp.movenext
  loop  
 
  ' fill option arrays with default values
  for f=0 to 3
   arrayOptions1(0,f)=""
   arrayOptions1(1,f)=0
   arrayOptions1(2,f)=0
   arrayOptions1(3,f)=0
   arrayOptions2(0,f)=""
   arrayOptions2(1,f)=0   
   arrayOptions2(2,f)=0
  next
 
 
  ' retrieve options
  pHiddenIdOptions=""
 
  if pIdOptionGroup1<>0 then
 
   mySQL="SELECT optionDescrip, priceToAdd, percentageToAdd, options.idOption FROM options, options_optionsGroups WHERE idOptionGroup=" & pIdOptionGroup1 & " AND options.idOption=options_optionsGroups.idOption"
   call getFromDatabase(mySQL, rstemp, "getOptions") 
   f=0
 
   do while not rstemp.eof
     arrayOptions1(0,f)    = trim(rstemp("optionDescrip"))
     arrayOptions1(1,f)    = rstemp("priceToAdd")
     arrayOptions1(2,f)    = rstemp("percentageToAdd")
     pHiddenIdOptions    = pHiddenIdOptions & rstemp("idOption") &"," 
    f=f+2
   rstemp.movenext
   loop   
 
  end if
 
  if pIdOptionGroup2<>0 then
 
   mySQL="SELECT optionDescrip, priceToAdd, percentageToAdd, options.idOption FROM options, options_optionsGroups WHERE idOptionGroup=" & pIdOptionGroup2 & " AND options.idOption=options_optionsGroups.idOption"
   call getFromDatabase(mySQL, rstemp, "getOptions") 
 
   f=0
   do while not rstemp.eof
     arrayOptions2(0,f)    = trim(rstemp("optionDescrip"))
     arrayOptions2(1,f)    = rstemp("priceToAdd")
     arrayOptions2(2,f)    = rstemp("percentageToAdd")
     pHiddenIdOptions    = pHiddenIdOptions & rstemp("idOption") &"," 
    f=f+2
   rstemp.movenext
   loop   
 
  end if
 
end sub

[Stewart Ross]

Hi. Sorry, but 144 lines of code is too much to try to review for potential errors without being able to use the full debugging environment that VBA provides.

The error message is telling you that you are trying to access an array element with an index value that lies outside of the declared range for that array. I would doubt that the error is arising on your highlighted line, the innocuous for loop at line 32, even though you appear to be using an undeclared variable f as the loop index. An error could occur here if at some stage you have changed the value of for counter f from within the loop to a value lying outside of its preset range of 0-3, but this does not jump out from looking at the code.

It also does not help us that the code you post has no declarations for your arrays either.

I would suggest that you are going to have to be systematic about debugging. Set a breakpoint at the start of your routine and step through the code line by line, using the local variable watch facilities of VBA to check the values of all variables as you go. You should check particularly that the value of your array index variable f stays within the declared index range for the arrays concerned.

You may wish to read the series of short articles by our expert site admin NeoPa on Debugging in VBA for further guidance.

-Stewart

ps at lines 58 and 104 you list 'next' instead of 'next f' - better to be explicit and specify what the loop variable being incremented actually is, so use next f there instead.

[Stewart Ross]

Further to the previous post, it appears that you are either using undeclared variables routinely or you have globals defined elsewhere. You can use the compiler to prevent errors such as the use of undeclared variables by setting

OPTION EXPLICIT

at the top of your code.

Look particularly at where (or if) you are defining loop variable f. It appears in your sub called from your main procedure, and in your main procedure. If it is global in scope you really will have a problem, as its value in the calling routine will be overwritten by the sub when you call it.

-Stewart