Seeking way to shorten this little code snippet...

[MLH]

Select Case Me.OpenArgs
Case "frmVehicleEntryForm"
Forms![frmVehicleEntryForm]![OwnerChooserBox].Requery
Case "frmEditTowedVehicleList"

Forms![frmEditTowedVehicleList]![OwnerChooserBox].Requery
End Select

Me.OpenArgs is the name of the calling form. There are only two forms
that open frmOwerEntryForm in which the above code resides. Can the
above snippet be shortened?

[Danny J. Lesandrini]

This will work ...
Forms(Me.OpenArgs)!OwnerChooserBox.Requery

Provided that OpenArgs is never empty and that the form it references
always has that particular control. You might add another call to see
if the form exists before doing the requery.
--

Danny J. Lesandrini
dl*********@hotmail.com
http://amazecreations.com/datafast
"MLH" <CR**@NorthState.net> wrote ...

Select Case Me.OpenArgs
Case "frmVehicleEntryForm"
Forms![frmVehicleEntryForm]![OwnerChooserBox].Requery
Case "frmEditTowedVehicleList"

Forms![frmEditTowedVehicleList]![OwnerChooserBox].Requery
End Select

Me.OpenArgs is the name of the calling form. There are only two forms
that open frmOwerEntryForm in which the above code resides. Can the
above snippet be shortened?

[MLH]

Alright. Everybody loves a good one-liner.
Thx.

[Tom van Stiphout]

On Mon, 27 Mar 2006 12:56:51 -0500, MLH <CR**@NorthState.net> wrote:

Danny had a good suggestion. I'm focussing on the use of OpenArgs to
pass in a form name. I prefer to do that a bit differently. I use a
querystring-like string for OpenArgs:
Docmd.OpenForm "someform",,,,,,"FormName=frmVehicleEntryForm"
The beauty is that the OpenArgs string becomes self-documenting, and
that we are re-using a format that everyone is already familiar with.

Then in the receiving form, I parse OpenArgs using a function that I
wrote once to parse any querystring into a Scripting.Dictionary
object:
dim m_dict as Scripting.Dictionary
m_dict = ParseQueryString(Me.OpenArgs)
The beauty is that OpenArgs becomes very flexible; I can add more
arguments at any time and will not get confused about what's what:
Docmd.OpenForm
"someform",,,,,,"FormName=frmVehicleEntryForm&Vehi cleID=123&DriverID=456"

-Tom.

Select Case Me.OpenArgs
Case "frmVehicleEntryForm"
Forms![frmVehicleEntryForm]![OwnerChooserBox].Requery
Case "frmEditTowedVehicleList"

Forms![frmEditTowedVehicleList]![OwnerChooserBox].Requery
End Select

Me.OpenArgs is the name of the calling form. There are only two forms
that open frmOwerEntryForm in which the above code resides. Can the
above snippet be shortened?

[Lyle Fairfield]

Que sera, sera
Whatever will be, will be
The future's not ours to see
Que sera, sera
What will be, will be

On Mon, 27 Mar 2006 12:56:51 -0500, MLH <[e-mail]> wrote:

something ... I think

[Mark]

"MLH" <CR**@NorthState.net> wrote:

Can the above snippet be shortened?

I'm a big fan of letting VBA go out and find relevant objects at runtime.
It doesn't necessarily result in shorter code (although it will if you are
replacing a _lengthy_ set of conditional statements.) The beauty of it
is that if you are consistent in your naming standards for the objects
that you want to manipulate, then this will catch all of them. And if you
decide to put another "OwnerChooserBox" in your application, then
your existing code will find it.

For example, this code will search all open forms for controls
named "OwnerChooserBox" and execute the Requery method
for each control. For added safety you could validate the control
type as well.

Sub do_requeries()
Dim obj As Form
Dim ctrl As Control

For Each obj In Application.Forms
For Each ctrl In obj.Controls
If ctrl.Name = "OwnerChooserBox" Then
obj.Requery
endif
Next ctrl
Next obj
End Sub

[Mark]

"Mark" <no****@thanksanyway.org> wrote:

For Each obj In Application.Forms
For Each ctrl In obj.Controls
If ctrl.Name = "OwnerChooserBox" Then
obj.Requery

Make that "ctrl.Requery" of course. Shame on me.
Try this instead:

Sub do_requeries()
Dim frm As Form
Dim ctrl As Control

For Each frm In Application.Forms
For Each ctrl In frm.Controls
If ctrl.Name = "OwnerChooserBox" Then
ctrl.Requery
endif
Next ctrl
Next frm
End Sub

[MLH]

That's pretty neat. I like it.

[Mark]

"MLH" <CR**@NorthState.net> wrote:

That's pretty neat. I like it.

It's one of several approaches. I like it, but it does
impose a control naming convention in order for it
to work. In your case, your naming convention is
already in place, so this approach probably makes
sense for you.

Good luck
-Mark

[Mark]

"Mark" <no****@thanksanyway.org> wrote:

"MLH" <CR**@NorthState.net> wrote:

That's pretty neat. I like it.

It's one of several approaches. I like it, but it does
impose a control naming convention in order for it
to work.

And of course, you wouldn't want to use this code
inside a recursive loop. Execution time for my code
sample probably won't be noticeable if it runs in
response to a user input. Example:

sub cmdRequery.click()
do_requeries()
end sub

That would be fine. But try this:

dim iCnt as integer
for iCnt = 1 to 10000
do_requeries()
loop

and your users will enter a House of Pain.