Sometimes another record gets deleted !

[Prakash]

Below is my code to delete a record in a continuous form. I can't
figure out any reason but sometimes (another) record gets deleted
instead of where the record pointer is positioned.

Small table - just 750 records ... no primary key defined.

Using Access 2003 under WinXP SP1.

There must be something I've overlooked. Maybe one of you gurus could
help.

Thks & Best Rgds,
Prakash.
--- Code snippet begins here ---------------------------
Private Sub Cmd_Delete_Click()
On Error GoTo Err_Cmd_Delete_Click

Dim choice As Long
Dim msg As String
msg = "Delete Contact: " & Me.Contact_person & " ?" & Chr(13) &
Chr(13) & "This Action Cannot Be Undone !"
choice = MsgBox(msg, vbYesNo + vbQuestion, "Delete Record")
If choice = vbYes Then
On Error Resume Next
DoCmd.RunCommand acCmdUndo 'Undo the changes if the
user has edited the record ... REQUIRED ! DO NOT DELETE THIS !
DoCmd.SetWarnings False
DoCmd.RunCommand acCmdDeleteRecord 'Delete the record
DoCmd.SetWarnings True

Me.Cmb_Company.Requery
Me.Cmb_ContactPerson.Requery
End If

Exit_Cmd_Delete_Click:
Exit Sub

Err_Cmd_Delete_Click:
MsgBox Err.Description
Resume Exit_Cmd_Delete_Click

End Sub
--- Code snippet ends here ----------------------------------

[Tom van Stiphout]

On 7 Dec 2004 10:29:48 -0800, "Prakash" <si****@omantel.net.om> wrote:

No primary key???? Add one!

-Tom.

Below is my code to delete a record in a continuous form. I can't
figure out any reason but sometimes (another) record gets deleted
instead of where the record pointer is positioned.

Small table - just 750 records ... no primary key defined.

Using Access 2003 under WinXP SP1.

There must be something I've overlooked. Maybe one of you gurus could
help.

Thks & Best Rgds,
Prakash.
--- Code snippet begins here ---------------------------
Private Sub Cmd_Delete_Click()
On Error GoTo Err_Cmd_Delete_Click

Dim choice As Long
Dim msg As String
msg = "Delete Contact: " & Me.Contact_person & " ?" & Chr(13) &
Chr(13) & "This Action Cannot Be Undone !"
choice = MsgBox(msg, vbYesNo + vbQuestion, "Delete Record")
If choice = vbYes Then
On Error Resume Next
DoCmd.RunCommand acCmdUndo 'Undo the changes if the
user has edited the record ... REQUIRED ! DO NOT DELETE THIS !
DoCmd.SetWarnings False
DoCmd.RunCommand acCmdDeleteRecord 'Delete the record
DoCmd.SetWarnings True

Me.Cmb_Company.Requery
Me.Cmb_ContactPerson.Requery
End If

Exit_Cmd_Delete_Click:
Exit Sub

Err_Cmd_Delete_Click:
MsgBox Err.Description
Resume Exit_Cmd_Delete_Click

End Sub
--- Code snippet ends here ----------------------------------

[Salad]

Prakash wrote:

Below is my code to delete a record in a continuous form. I can't
figure out any reason but sometimes (another) record gets deleted
instead of where the record pointer is positioned.

Small table - just 750 records ... no primary key defined.

Using Access 2003 under WinXP SP1.

There must be something I've overlooked. Maybe one of you gurus could
help.

Thks & Best Rgds,
Prakash.
--- Code snippet begins here ---------------------------
Private Sub Cmd_Delete_Click()
On Error GoTo Err_Cmd_Delete_Click

Dim choice As Long
Dim msg As String
msg = "Delete Contact: " & Me.Contact_person & " ?" & Chr(13) &
Chr(13) & "This Action Cannot Be Undone !"
choice = MsgBox(msg, vbYesNo + vbQuestion, "Delete Record")
If choice = vbYes Then
On Error Resume Next
DoCmd.RunCommand acCmdUndo 'Undo the changes if the
user has edited the record ... REQUIRED ! DO NOT DELETE THIS !
What is the Undo for? Who cares if the data has been modified? What if
this is a new record and you tell it to Undo? What record gets deleted
then? Certainly not a new, unsaved record.

You could put in something like
If not Me.NewRecord then
...delete code
Else
Me.Undo
Endif

DoCmd.SetWarnings False
DoCmd.RunCommand acCmdDeleteRecord 'Delete the record
DoCmd.SetWarnings True

Me.Cmb_Company.Requery
Me.Cmb_ContactPerson.Requery
End If

Exit_Cmd_Delete_Click:
Exit Sub

Err_Cmd_Delete_Click:
MsgBox Err.Description
Resume Exit_Cmd_Delete_Click

End Sub
--- Code snippet ends here ----------------------------------

[Prakash]

It's just a simple address book. I'd have to use something like an
autonumber field to add a primary key and personally I'm not a fan of
autonumbers.

Moreover, a primary key does not seem to be required here as i would'nt
serve any purpose.

In light of all this would you still recommend me ading a primary key
...and..
Do you think it'll help solve my problem of another record getting
deleted ?

Thx & Best Rgds,
Prakash.