Dir() function problem

[Ron Nolan]

Re: Access 2000

According to the help, to loop through a folder, you use code like
this:

' Returns filename with specified extension. If more than one *.ini
' file exists, the first file found is returned.
MyFile = Dir("C:\WINDOWS\*.INI")

' Call Dir again without arguments to return the next *.INI file in
the
' same directory.
MyFile = Dir
--------------
ok...I'm trying something similar.
I am trying to loop through a folder and do something with each of the
4 .mdb files in the folder.
Whenever I add something in my loop, I get an "Invalid procedure call
or argument" error on this line: strOldFile = Dir
When I add the "FileExists" function, I need to do this to see if the
new file exists then if it does, delete the old one.
If I remove the "FileExists" line, the >>strOldFile = Dir<< line of
code works fine for all files in the loop.
I have tried this by adding an array of different lines of code, but
when I do, then the >>strOldFile = Dir<< line will always return
null on the 2nd try, and there are 4 files I need to look at in this
loop.

What good is this process......
MyFile = Dir("C:\WINDOWS\*.INI")
MyFile = Dir
.....when I cannot add anything to it?

--------
Here is my code:
strOldFile = Dir("C:\My Documents\*.mdb")
Do While strOldFile <> ""
strNewFile = Left$(strOldFile, (Len(strOldFile) - 4)) & "_CMPCT.MDB"
blnreturn = FileExists(strDirectory & strNewFile)
Debug.Print "Old File: " & strOldFile & " / " & "New File: " &
strNewFile
strOldFile = Dir
Loop

-------

Thanks for the assistance.

RLN

[JSand42737]

In article <13**************************@posting.google.com >,
rl**********@yahoo.com (Ron Nolan) writes:

Re: Access 2000

According to the help, to loop through a folder, you use code like
this:

' Returns filename with specified extension. If more than one *.ini
' file exists, the first file found is returned.
MyFile = Dir("C:\WINDOWS\*.INI")

' Call Dir again without arguments to return the next *.INI file in
the
' same directory.
MyFile = Dir
--------------
ok...I'm trying something similar.
I am trying to loop through a folder and do something with each of the
4 .mdb files in the folder.
Whenever I add something in my loop, I get an "Invalid procedure call
or argument" error on this line: strOldFile = Dir
When I add the "FileExists" function, I need to do this to see if the
new file exists then if it does, delete the old one.
If I remove the "FileExists" line, the >>strOldFile = Dir<< line of
code works fine for all files in the loop.
I have tried this by adding an array of different lines of code, but
when I do, then the >>strOldFile = Dir<< line will always return
null on the 2nd try, and there are 4 files I need to look at in this
loop.

What good is this process......
MyFile = Dir("C:\WINDOWS\*.INI")
MyFile = Dir
....when I cannot add anything to it?

--------
Here is my code:
strOldFile = Dir("C:\My Documents\*.mdb")
Do While strOldFile <> ""
strNewFile = Left$(strOldFile, (Len(strOldFile) - 4)) & "_CMPCT.MDB"
blnreturn = FileExists(strDirectory & strNewFile)
Debug.Print "Old File: " & strOldFile & " / " & "New File: " &
strNewFile
strOldFile = Dir
Loop

-------

Thanks for the assistance.

RLN

Ron

At a guess, FileExists is a user created function that utilises the Dir
function. Unfortunately, using Dir in this way resets the first Dir in the
loop. You may wish to create an array and write the file names to this array.
Something like:
Sub SLoopDir()
Dim strOldFile As String
Dim strNewFile As String
Dim astrDBFiles() As String
Dim intLoop As Integer
ReDim astrDBFiles(1 To 2, 1 To 10)
intLoop = 1
strOldFile = Dir("C:\My Documents\*.mdb")
Do While strOldFile <> ""
strNewFile = Left$(strOldFile, (Len(strOldFile) - 4)) & "_CMPCT.MDB"
astrDBFiles(1, intLoop) = strOldFile
astrDBFiles(2, intLoop) = strNewFile
intLoop = intLoop + 1
If intLoop Mod 10 = 0 Then ReDim Preserve astrDBFiles(1 To 2, 1 To
intLoop + 10)
strOldFile = Dir
Loop
If intLoop > 1 Then ReDim Preserve astrDBFiles(1 To 2, 1 To intLoop - 1)
For intLoop = 1 To UBound(astrDBFiles)
Debug.Print "old: " & astrDBFiles(1, intLoop) & vbTab & "new: " &
astrDBFiles(2, intLoop)
Next intLoop
End Sub

Once you have the file names in the array, you can then check if they exist,
and perform actions as required.
--

Jon

www.applecore99.com - Access Tips and Tricks

[Ron Nolan]

> Ron

At a guess, FileExists is a user created function that utilises the Dir
function. Unfortunately, using Dir in this way resets the first Dir in the
loop. You may wish to create an array and write the file names to this array.
Something like:
Sub SLoopDir()
Dim strOldFile As String
Dim strNewFile As String
Dim astrDBFiles() As String
Dim intLoop As Integer
ReDim astrDBFiles(1 To 2, 1 To 10)
intLoop = 1
strOldFile = Dir("C:\My Documents\*.mdb")
Do While strOldFile <> ""
strNewFile = Left$(strOldFile, (Len(strOldFile) - 4)) & "_CMPCT.MDB"
astrDBFiles(1, intLoop) = strOldFile
astrDBFiles(2, intLoop) = strNewFile
intLoop = intLoop + 1
If intLoop Mod 10 = 0 Then ReDim Preserve astrDBFiles(1 To 2, 1 To
intLoop + 10)
strOldFile = Dir
Loop
If intLoop > 1 Then ReDim Preserve astrDBFiles(1 To 2, 1 To intLoop - 1)
For intLoop = 1 To UBound(astrDBFiles)
Debug.Print "old: " & astrDBFiles(1, intLoop) & vbTab & "new: " &
astrDBFiles(2, intLoop)
Next intLoop
End Sub

Once you have the file names in the array, you can then check if they exist,
and perform actions as required.

Jon,

This worked beautifully! Thank you very much for your assistance
here! Have a great day.

Ron

[Ron Nolan]

Jon,

Your solution here works, but I wanted to ask some questions, mainly
for my own education, so I could understand your methods better:

Dim astrDBFiles() As String ReDim astrDBFiles(1 To 2, 1 To 10)<<

My thoughts here: is it less efficient to just dim it as an array from
the beginning?

If intLoop Mod 10 = 0 Then ReDim Preserve astrDBFiles(1 To 2, 1 To

intLoop + 10)<<
What does "redim preserve" do?

Thanks,

RLN

[Larry Linson]

astrDBFiles _is_ dim'd as an array from the start -- but without _specific
dimensions_.

You use ReDim to reset the dimensions of an array when you only know how big
it is as you continue through the code. The Preserve option preserves the
contents of the array through the ReDim -- otherwise it is redimensioned and
reinitialized.

Larry Linson
Microsoft Access MVP

"Ron Nolan" <rl**********@yahoo.com> wrote in message
news:13**************************@posting.google.c om...

Jon,

Your solution here works, but I wanted to ask some questions, mainly
for my own education, so I could understand your methods better:

Dim astrDBFiles() As String ReDim astrDBFiles(1 To 2, 1 To 10)<<

My thoughts here: is it less efficient to just dim it as an array from
the beginning?

If intLoop Mod 10 = 0 Then ReDim Preserve astrDBFiles(1 To 2, 1 To

intLoop + 10)<<
What does "redim preserve" do?

Thanks,

RLN