Hello Folks. Thanks for all the help i have received here. I was trying to write an upload file. It was ok until i began error reporting. First i tried to inspect the file uploaded by asking the print_r to show the associate array of name, type, size, tmp_name and error. It works all right but it gives this error just as i load the page
Notice: Undefined index: file_upload in C:\wamp\www\btb_sandbox\upload.php on line 27
I didnt take it quite serious then i continues my error reporting. It gave the following errors
Notice: Undefined index: file_upload in C:\wamp\www\btb_sandbox\upload.php on line 18
Notice: Undefined index: in C:\wamp\www\btb_sandbox\upload.php on line 19
I understand that file_upload is undefined, but i dont know how to go around it. Or is it from my html tags? Please help out. Here is the code. Thanks -
<?php
-
-
//In an application, this could be moved to a config file
-
$upload_errors = array
-
(//http://www.php.net/manual/en/features.file-upload.errors.php
-
-
UPLOAD_ERR_OK => "No Errors.",
-
UPLOAD_ERR_INI_SIZE => "Larger than upload_max_filesize.",
-
UPLOAD_ERR_FORM_SIZE => "Larger than form MAX_FILE_SIZE.",
-
UPLOAD_ERR_PARTIAL => "Partial upload.",
-
UPLOAD_ERR_NO_FILE => "No file.",
-
UPLOAD_ERR_NO_TMP_DIR => "No temporary directory",
-
UPLOAD_ERR_CANT_WRITE => "Can't write to disk",
-
UPLOAD_ERR_EXTENSION => "File upload stopped by extension."
-
);
-
-
-
$error = $_FILES['file_upload']['error'];
-
$message = $upload_errors[$error];
-
-
-
-
-
-
//print_r( is the one giving me Notice: Undefined index: file_upload in C:\wamp\www\btb_sandbox\upload.php on line 4. Echo makes it go, nut show nothing because it aint redable by humans
-
echo "<pre>";
-
print_r($_FILES['file_upload']);
-
echo "</pre>";
-
echo "<hr/>";
-
-
-
?>
-
-
-
<!DOCTYPE html>
-
-
<html lang="en">
-
<head>
-
<meta charset="utf-8" />
-
<title> Upload </title>
-
</head>
-
<body>
-
-
-
<?php if(!empty($message)){echo "<p>{$message}</p>";} //A means to pass messages to the the user about the from processing?>
-
<form action="upload.php" enctype="multipart/form-data" method="POST">
-
-
<input type="hidden" name="MAX_FILE_SIZE" value="100000000"/>
-
-
<input type="file" name="file_upload"/>
-
-
<input type="submit" value="Upload"/>
-
-
</form>
-
-
-
-
-
-
</body>
-
</html>
-
17  3244 
if you call the page in order to upload a file, the $_FILES array is empty.
Thanks Dormilich, so how can i solve it???
you check if $_FILES is populated and only then run the upload code.
FWD: - <?php
-
-
if(isset($_POST['file_upload']))
-
{
-
$upload_errors = array
-
(
-
UPLOAD_ERR_OK => "No Errors.",
-
UPLOAD_ERR_INI_SIZE => "Larger than upload_max_filesize.",
-
UPLOAD_ERR_FORM_SIZE => "Larger than form MAX_FILE_SIZE.",
-
UPLOAD_ERR_PARTIAL => "Partial upload.",
-
UPLOAD_ERR_NO_FILE => "No file.",
-
UPLOAD_ERR_NO_TMP_DIR => "No temporary directory",
-
UPLOAD_ERR_CANT_WRITE => "Can't write to disk",
-
UPLOAD_ERR_EXTENSION => "File upload stopped by extension."
-
);
-
-
-
$error = $_FILES['file_upload']['error'];//Notice: Undefined index: file_upload
-
$message = $upload_errors[$error];
-
-
-
echo "<pre>";
-
print_r($_FILES['file_upload']);//Notice: Undefined index: file_upload
-
echo "</pre>";
-
echo "<hr/>";
-
}
-
-
?>
-
-
-
<!DOCTYPE html>
-
-
<html lang="en">
-
<head>
-
<meta charset="utf-8" />
-
<title> Upload </title>
-
</head>
-
<body>
-
-
-
<?php if(!empty($message)){echo "<p>{$message}</p>";}?>
-
<form action="upload.php" enctype="multipart/form-data" method="POST">
-
-
<input type="hidden" name="MAX_FILE_SIZE" value="100000000"/>
-
-
<input type="file" name="file_upload"/>
-
-
<input type="submit" value="Upload"/>
-
-
</form>
-
-
-
-
</body>
-
</html>
It removed the error, but it doesnt seem to process the form or even output the associative array that i asked it for. It was just like the all php above <!DOCTYPE html> were removed. The page just opens with only CHOOSE FILE and UPLOAD buttons, and when i try to upload, it refuses, telling me "No file chosen". Same thing happens with if(isset($_POST['file_upload'])){....My php code here..}. Is it because the page is submitting to itself?Or the the whole form processing is on one page?? Thanks
your data is in $_FILES, not in $_POST.
there’s a pretty good example here.
Thanks Dormilich. You have really been helpful. i look at that php.net link that you showed to me and it was really helpful. Im pretty new to php. I spent all night working on this bug, yet no progress. Same error, or some other. Just now, i came up with an idea. If it was about the index 'file_upload' not being set,, or not being an array, why not a simple echo statement. Thus i took the initiative from the php.net site and did something like this - if (
-
!isset($_FILES['file_upload']['error']) ||
-
is_array($_FILES['file_upload']['error'])
-
)
-
-
{echo "File Upload is set";}
-
It returned "File Upload is set", Thus i guess thats a step forward. Im stuck here. I have tried everything i could to weave syntax to accommodate the rest of the code yet, same stuff. Last stuff i tried was this -
if (
-
!isset($_FILES['file_upload']['error']) ||
-
is_array($_FILES['file_upload']['error'])
-
)
-
-
{ $upload_errors = array
-
(
-
UPLOAD_ERR_OK => "No Errors.",
-
UPLOAD_ERR_INI_SIZE => "Larger than upload_max_filesize.",
-
UPLOAD_ERR_FORM_SIZE => "Larger than form MAX_FILE_SIZE.",
-
UPLOAD_ERR_PARTIAL => "Partial upload.",
-
UPLOAD_ERR_NO_FILE => "No file.",
-
UPLOAD_ERR_NO_TMP_DIR => "No temporary directory",
-
UPLOAD_ERR_CANT_WRITE => "Can't write to disk",
-
UPLOAD_ERR_EXTENSION => "File upload stopped by extension."
-
);
-
-
-
$error = $_FILES['file_upload']['error'];//Notice: Undefined index: file_upload
-
$message = $upload_errors[$error];
-
-
-
echo "<pre>";
-
print_r($_FILES['file_upload']);//Notice: Undefined index: file_upload
-
echo "</pre>";
-
echo "<hr/>";
-
}
-
-
?>
-
-
-
<!DOCTYPE html>
-
-
<html lang="en">
-
<head>
-
<meta charset="utf-8" />
-
<title> Upload </title>
-
</head>
-
<body>
-
-
-
<?php if(!empty($message)){echo "<p>{$message}</p>";}?>
-
<form action="upload.php" enctype="multipart/form-data" method="POST">
-
-
<input type="hidden" name="MAX_FILE_SIZE" value="100000000"/>
-
-
<input type="file" name="file_upload"/>
-
-
<input type="submit" value="Upload"/>
-
-
</form>
-
</body>
-
</html>
-
Could you please help me weak the right syntax for this my code? Thanks a trillion :-)
well, your if condition triggers if:
- $_FILES['file_upload']['error'] does not exist or
- $_FILES['file_upload']['error'] is an array
compare what is written in the comment vs. what is written in your code!
OHH! My bad. I think isset && is_array would have been better -
-
<?php
-
-
-
$upload_errors = array
-
(
-
UPLOAD_ERR_OK => "No Errors.",
-
UPLOAD_ERR_INI_SIZE => "Larger than upload_max_filesize.",
-
UPLOAD_ERR_FORM_SIZE => "Larger than form MAX_FILE_SIZE.",
-
UPLOAD_ERR_PARTIAL => "Partial upload.",
-
UPLOAD_ERR_NO_FILE => "No file.",
-
UPLOAD_ERR_NO_TMP_DIR => "No temporary directory",
-
UPLOAD_ERR_CANT_WRITE => "Can't write to disk",
-
UPLOAD_ERR_EXTENSION => "File upload stopped by extension."
-
);
-
-
if (
-
isset($_FILES['file_upload']['error']) &&
-
is_array($_FILES['file_upload']['error'])
-
)
-
-
{
-
echo "Defined and ready";
-
}
-
-
else {echo "Undefined and Unready";}
-
-
?>
-
It returned Undefined and unready. So please, what should i do to define it and make it an array. Thanks in advance
why—do you think—should $_FILES['file_upload']['error'] be an array?
No. $upload_errors is the array. What should i do to at least define 'file_upload'? Am confused right now
$upload_errors is of no interest for the problem.
let’s have a look at the original snippet again - try {
-
-
// Undefined | Multiple Files | $_FILES Corruption Attack
-
// If this request falls under any of them, treat it invalid.
-
if (
-
!isset($_FILES['upfile']['error']) ||
-
is_array($_FILES['upfile']['error'])
-
) {
-
throw new RuntimeException('Invalid parameters.');
-
}
-
-
// Check $_FILES['upfile']['error'] value.
-
switch ($_FILES['upfile']['error']) {
-
case UPLOAD_ERR_OK:
-
break;
-
case UPLOAD_ERR_NO_FILE:
-
throw new RuntimeException('No file sent.');
-
case UPLOAD_ERR_INI_SIZE:
-
case UPLOAD_ERR_FORM_SIZE:
-
throw new RuntimeException('Exceeded filesize limit.');
-
default:
-
throw new RuntimeException('Unknown errors.');
-
}
-
-
// ...
-
line #5 - #10 is a preliminary check for the code block (#13 - #23) following it. the key to understanding the check is to understand what the variable $_FILES['upfile']['error'] is used for.
it is used in a switch() that tests it for a single value (an integer, to be precise)! hence we should make sure that $_FILES['upfile']['error'] 1) exists and 2) it contains a primitive value (string, integer, boolean).
we know that user data (via $_GET, $_POST, etc.) come in exactly 2 types: string and array. an array is not a primitive, so it needs to be excluded.
these two tests are made before the switch. and due to the use of exceptions the test is made in reverse: it tests if one of the required conditions (existence, data type) fails and if one fails the error handling kicks in. (this is one way to prevent nesting hell) If both requirements are met, i.e. both failure conditions fail, the script can proceed.
Thanks Dormilich. You have been far too kind. I have cracked it. An elder colleague advised me to run the isset test after the $upload_errors array and not before it. I removed those <pre> tags that i used in inspecting the uploaded files and later decided against running the test on 'file_upload'. Instead i checked whether the $_POST variable was subumitted. Like this - if(isset($_POST['submit']))
-
{..my form processing code here..}
-
It worked. I thus proceeded to move the uploaded file to a more permanent directory with the original name(basename) and give a success message or error message utilizing that $upload_errors array. The problem was never 'file_uploads'. I have pasted the full code below. -
-
-
<?php
-
-
-
$upload_errors = array(
-
-
UPLOAD_ERR_OK => "No errors.",
-
UPLOAD_ERR_INI_SIZE => "Larger than upload_max_filesize.",
-
UPLOAD_ERR_FORM_SIZE => "Larger than form MAX_FILE_SIZE.",
-
UPLOAD_ERR_PARTIAL => "Partial upload.",
-
UPLOAD_ERR_NO_FILE => "No file.",
-
UPLOAD_ERR_NO_TMP_DIR => "No temporary directory.",
-
UPLOAD_ERR_CANT_WRITE => "Can't write to disk.",
-
UPLOAD_ERR_EXTENSION => "File upload stopped by extension."
-
);
-
-
if(isset($_POST['submit']))
-
{
-
-
$tmp_file = $_FILES['file_upload']['tmp_name'];
-
$target_file = basename($_FILES['file_upload']['name']);
-
-
-
$upload_dir = "uploads";
-
-
-
if(move_uploaded_file($tmp_file, $upload_dir."/".$target_file))
-
{
-
$message = "File uploaded successfully.";
-
}
-
else
-
{
-
$error = $_FILES['file_upload']['error'];
-
$message = $upload_errors[$error];
-
}
-
-
}
-
-
-
?>
-
<html>
-
<head>
-
<title>Upload</title>
-
</head>
-
<body>
-
-
-
<?php if(!empty($message)) { echo "<p>{$message}</p>"; } ?>
-
<form action="upload.php" enctype="multipart/form-data" method="POST">
-
-
<input type="hidden" name="MAX_FILE_SIZE" value="1000000" />
-
<input type="file" name="file_upload" />
-
-
<input type="submit" name="submit" value="Upload" />
-
</form>
-
-
</body>
-
</html>
-
-
Thanks alot Dormilich. I appreciate. I learnt alot during this debugging process. I hope this helps someone that has a similar pitfall in the future. Gracias.
An elder colleague advised me to run the isset test after the $upload_errors array and not before it.
that array is just a convenience to translate the PHP constants into readable text. it serves no purpose for the actual error checking.
I […] later decided against running the test on 'file_upload'. Instead i checked whether the $_POST variable was subumitted.
which makes you highly prone to upload errors.
imagine the following scenario: what happens in your code if the form is submitted, but no file uploaded?
starting with line #21 you’ll get warnings (missing index) to errors (no such file) all over the place. and only after everything has failed, you check what was actually the problem.
there is a reason for the UPLOAD_ERR_OK constant.
Oh. Thanks Dormilich. Sorry for the late reply. I have not been feeling too fine. This upload page was just a test, on how i could handle my uploads. When i was sure i could upload successfully, i wrote 2 public methods SAVE and ATTACH_FILE, that perfectly handles from file upload, to tmp_directory, to permanent directory, considering every exception i could think of. I flexed the muscles of the conditional statements on this one. Here are they. Anything i should add?? -
-
public function attach_file($file) {
-
// Perform error checking on the form parameters
-
if(!$file || empty($file) || !is_array($file)) {
-
// error: nothing uploaded or wrong argument usage
-
$this->errors[] = "No file was uploaded.";
-
return false;
-
} elseif($file['error'] != 0) {
-
// error: report what PHP says went wrong
-
$this->errors[] = $this->upload_errors[$file['error']];
-
return false;
-
} else {
-
// Set object attributes to the form parameters.
-
$this->temp_path = $file['tmp_name'];
-
$this->filename = basename($file['name']);
-
$this->type = $file['type'];
-
$this->size = $file['size'];
-
// Don't worry about saving anything to the database yet.
-
return true;
-
-
}
-
}
-
-
public function save() {
-
// A new record won't have an id yet.
-
if(isset($this->id)) {
-
// Really just to update the caption
-
$this->update();
-
} else {
-
// Make sure there are no errors
-
-
// Can't save if there are pre-existing errors
-
if(!empty($this->errors)) { return false; }
-
-
// Make sure the caption is not too long for the DB
-
if(strlen($this->caption) <= 255) {
-
$this->errors[] = "The caption can only be 255 characters long.";
-
return false;
-
}
-
-
// Can't save without filename and temp location
-
if(empty($this->filename) || empty($this->temp_path)) {
-
$this->errors[] = "The file location was not available.";
-
return false;
-
}
-
-
// Determine the target_path
-
$target_path = SITE_ROOT .DS. 'public' .DS. $this->upload_dir .DS. $this->filename;
-
-
// Make sure a file doesn't already exist in the target location
-
if(file_exists($target_path)) {
-
$this->errors[] = "The file {$this->filename} already exists.";
-
return false;
-
}
-
-
// Attempt to move the file
-
if(move_uploaded_file($this->temp_path, $target_path)) {
-
// Success
-
// Save a corresponding entry to the database
-
if($this->create()) {
-
// We are done with temp_path, the file isn't there anymore
-
unset($this->temp_path);
-
return true;
-
}
-
} else {
-
// File was not moved.
-
$this->errors[] = "The file upload failed, possibly due to incorrect permissions on the upload folder.";
-
return false;
-
}
-
}
-
}
-
-
-
-
on line #8 I’d use elseif($file['error'] !== \UPLOAD_ERR_OK), that way it becomes immediately clear what the test is for.
and on line #2 I’d use type hinting: public function attach_file(array $file) {
Thanks Dormilich, on Line #8 i kinda prefer the numeric error codes. Thats how they are understandable to me.
Line #2 is also a good idea.
Thanks Dormilich, you have really been helpful. :-)
Sign in to post your reply or Sign up for a free account.
Similar topics
by: jsgoodrich |
last post by:
I am looking for some help if anyone can lend a hand.
I have a simple php website that displays a table from my mysql
database.
To prep for my MCSE I moved my home server to Windows 2003...
|
by: number1yan |
last post by:
Can anyone help me,
i am creating a website and am using a php script that recomends the website to other people. I keep getting the same error and can not work out why. The error is:
Notice:...
|
by: sickboy |
last post by:
$channels=$_GET; if (empty($channels)) { $channels='blank'; } changechannels($channels);
$theatre=$_GET; if (empty($theatre)) { $theatre='splash'; } changetheatre($theatre);
$info=$_GET; if...
|
by: Philth |
last post by:
Hey there, it has to be said that I am a complete novice in PHP, I know this is a common error and has probably been covered to some degree already - but my head really does hurt - so I couldn't...
|
by: francsutherland |
last post by:
Notice: Undefined index: send in D:\Domains\workingdata.co.uk\wwwroot\contact_text.php on line 7
Hi,
I've started getting this error in the contact page form of my website. The web hosting...
|
by: FutureShock |
last post by:
I have since recently turned up my error reporting on a production site
to E_ALL to ensure I am using 'best practices' when writing out code.
So far it has helped me discipline myself with...
|
by: stealthmode666 |
last post by:
New to .php so need script help.
I want to know how to stop this being displayed when I click submit.
Notice: Undefined index: homeowner in E:\domains\r\...\user\htdocs\...\form.php on line 166
...
|
by: razvanel442 |
last post by:
Hi all i am new here!
I take a look on forum but i don't found a the answer for my problem
ok this is my problem:
Line47:$user = $_GET;
Line48:$pass = $_GET;
Line49:$char = $_GET;
|
by: norwichchris |
last post by:
hi, I am having serious trouble with my PHP Postcard script. The error message i get is:
Notice: Undefined index:
Notice: Undefined variable
Basically it does not send out the scripts at...
|
by: nyrzs |
last post by:
"Notice: Undefined index: prod_rep in F:\xampp\htdocs\isys\products\process.php on line 153
Notice: Undefined variable: prod_id in F:\xampp\htdocs\isys\products\process.php on line 160
Warning:...
|
by: taylorcarr |
last post by:
A Canon printer is a smart device known for being advanced, efficient, and reliable. It is designed for home, office, and hybrid workspace use and can also be used for a variety of purposes. However,...
|
by: Charles Arthur |
last post by:
How do i turn on java script on a villaon, callus and itel keypad mobile phone
|
by: emmanuelkatto |
last post by:
Hi All, I am Emmanuel katto from Uganda. I want to ask what challenges you've faced while migrating a website to cloud.
Please let me know.
Thanks!
Emmanuel
|
by: nemocccc |
last post by:
hello, everyone, I want to develop a software for my android phone for daily needs, any suggestions?
|
by: Sonnysonu |
last post by:
This is the data of csv file
1 2 3
1 2 3
1 2 3
1 2 3
2 3
2 3
3
the lengths should be different i have to store the data by column-wise with in the specific length.
suppose the i have to...
|
by: marktang |
last post by:
ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However,...
|
by: Hystou |
last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can...
|
by: Oralloy |
last post by:
Hello folks,
I am unable to find appropriate documentation on the type promotion of bit-fields when using the generalised comparison operator "<=>".
The problem is that using the GNU compilers,...
|
by: jinu1996 |
last post by:
In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven...
| |
