Problem with hyperlink formating

jeddiki

Hi,

I have a database record which contains the contents of an email
and in the email there should be a clickable link.

For some reason the link is not formatting correctly.

Maybe it is something to do with br's and nl's ?

This is what I input in the database record:

Expand|Select|Wrap|Line Numbers

 
Then click here to grab a copy of the definitive guide to CPA Marketing!

url=http://www.example.net/sp/cpa-cash/]CPA-Cash Profits[/url]
 
See you again in part 4.

( I took out the leading [ )

This is what I have in the email:

Quote:

Then click here to grab a copy of the definitive guide to CPA
Marketing! target="_blank">CPA-Cash Profits

See you again in part 4.

My code now looks like this:

Expand|Select|Wrap|Line Numbers

 
$to = $cl_email; 

$contact = $cl_name;

$subject = $camp_row['title'];

$cur_mess = $cp_mes;

$message_html = eml_bbcode($cur_mess,$contact);

$message_html = wordwrap($message_html, 70, "\n");

$message_html = nl2br($message_html);

$message_html = str_replace("<br />", "<br>", $message_html);

$message_html = $message_html."<br><br> 

and my eml_bbcode() function is:

The eml_bbcode() function in there is used to
format the text with html.

Expand|Select|Wrap|Line Numbers

 
function eml_bbcode($Text,$client) {
 
// Replace any html brackets with HTML Entities to prevent executing HTML or script

/

// Don't use strip_tags here because it breaks [url] search by replacing & with amp

$Text = str_replace("<", "&lt;", $Text);

$Text = str_replace(">", "&gt;", $Text);
 
// Set up the parameters for a URL search string

$URLSearchString = " a-zA-Z0-9\:\/\-\?\&\.\=\_\~\#\'";
 
// Perform URL Search

$Text = preg_replace("(\[url\=([$URLSearchString]*)\](.+?)\[/url\])", '<a href="$1" target="_blank">$2</a>', $Text);
 
// Check for client flag

$Text = preg_replace("(\[client\])is","$client",$Text);
 
// Check for bold text

$Text = preg_replace("(\[b\](.+?)\[\/b])is",'<b>$1</b>',$Text);

The problem is that the target="_blank"> is not getting
identified as part of the hyperlink, even though is looks like a valid format ( to me ).

Can anyone spot where I have gone wrong ?

Thanks

Atli

Hi.

Can you show us the exact HTML that your code is generating?

P.S.
You can pass FALSE as the second parameter into the nl2br function to make it generate HTML breaks (<br>) rather than XHTML breaks (<br />).

Dormilich

Quote:

Originally Posted by jeddiki

( I took out the leading [ )

you can use [. this will print as [ but won't act as bbcode.

jeddiki

Hi,

I dont out put the result as HTML page, I just send
it as an email.

I tried looking at the source code for the mail in the gmail page but I could not find the email content - even a search in the source can out negative - don't know how they hide it - maybe its all encoded ?

jeddiki

OK - I see my problem now.

It is the wordwrap function that is breaking the line up.

Expand|Select|Wrap|Line Numbers

$message_html = wordwrap($message_html, 70, "\n");

Because of the space before the target word, the line gets broken at that point.

I took out that space but now the link doesn't work because of the sapace between the <a and the href .

I think that problem is because this part:

Quote:

href="http://www.example.net/sp/cpa-cash/index.php"target="_blank">
is over 70 characters long.

I am not sure what to do about this

Atli

Is there any specific reason why you are using the wordwrap function?
I know it was common to break up messages in the old days but no decent email client today should mind, and certainly not if you are sending HTML mails.

If you insist on breaking it up, try doing it before you convert the BBCode into HTML. You might have to adjust your regexp to cover multiple lines, tho, in case the [url]...[/url] line gets broken.

jeddiki

Having the wordwrap makes it much quicker to format
my emailsl so they are "easier on the eye".

Do you mean like this: ?

Expand|Select|Wrap|Line Numbers

 $message_html = wordwrap($message_html, 70, "\n");  

$message_html = eml_bbcode($cur_mess,$contact);

$message_html = nl2br($message_html);

$message_html = str_replace("<br />", "<br>", $message_html);

I am not sure what I would nned to do to make sure that this code of my bbcode will still work:

Expand|Select|Wrap|Line Numbers

 // Set up the parameters for a URL search string

$URLSearchString = " a-zA-Z0-9\:\/\-\?\&\.\=\_\~\#\'";
 
// Perform URL Search

$Text = preg_replace("(\[url\=([$URLSearchString]*)\](.+?)\[/url\])", "<a href=\"$1\"target=\"_blank\"> $2</a>", $Text);

The only place it can get broken now is at the space just
before the href label.

Any ideas on this ?

Problem with hyperlink formating

re: Problem with hyperlink formating

re: Problem with hyperlink formating

re: Problem with hyperlink formating

re: Problem with hyperlink formating

re: Problem with hyperlink formating

re: Problem with hyperlink formating

Similar PHP bytes

/bytes/development

/bytes/it

/bytes/about