What is wrong with this code?

Pheddy

Hi this one is hurtin' me!!

Expand|Select|Wrap|Line Numbers

 <?php 

$strID = $_GET["id"];
 
$filename = "c:\somedir\somedir\" . $strID . ".php";

if (file_exists($filename)) {

    $strIncPage = "somedir/" . $strID . ".php";

} else {

    $strIncPage = "somedir/error404.php";

}

?>

Ig get the error

Expand|Select|Wrap|Line Numbers

Parse error: parse error in C:\xampp\htdocs\index2.php on line (....x)

The problem persists with the "$filename" variable, I have tried jusing "'" characters instead of """ But then I get

Expand|Select|Wrap|Line Numbers

 Warning: Unexpected character in input: ''' (ASCII=39) state=1 in C:\xampp\htdocs\index2.php on line 6

c:\xampp\htdocs\insert_pages' . $strID . php

I cant seem to find out when to use either "'" or """, and when and how to use "." in these statements...

Expand|Select|Wrap|Line Numbers

$filename = 'c:\somedir\somedir\' . $strID . '.php';

Expand|Select|Wrap|Line Numbers

$filename = 'c:\somedir\somedir\$strID.php';

Expand|Select|Wrap|Line Numbers

$filename = "c:\somedir\somedir\$strID.php";

Frederik

Dormilich

\ is used as escape character so if you have a certain combination (like \n which is the new line character) you end up having invalid characters in your file path.

EDIT: \" escapes the quotation mark, so that it is not treated as string closing character.

Pheddy

Thank you!

I edited the \ to / characters...

prabirchoudhury

1. what Dormilich mention about your invalid character that always you have to remenber in writing script.

2. you could put all the seperated part of the link in a variable and then call as a complate file name

Expand|Select|Wrap|Line Numbers

 
if (file_exists($filename)) { 
 
$filename = "";

$filename  .= "c:\somedir\somedir\";

$filename  .= $strID;

$filename  .= ".php";

}else{
 
$filename  = somedir/error404.php";

}

:)

Dormilich

Quote:

Originally Posted by prabirchoudhury

Expand|Select|Wrap|Line Numbers

 $filename  .= "c:\somedir\somedir\";
 
$filename  = somedir/error404.php";

would result in a parse error.

EDIT: thank god I'm using posix (unix, linux, bsd, ...)

Atli

Quote:

Originally Posted by prabirchoudhury

1. what Dormilich mention about your invalid character that always you have to remenber in writing script.

2. you could put all the seperated part of the link in a variable and then call as a complate file name

Expand|Select|Wrap|Line Numbers

 
if (file_exists($filename)) { 
 
$filename = "";

$filename  .= "c:\somedir\somedir\";

$filename  .= $strID;

$filename  .= ".php";

}else{
 
$filename  = somedir/error404.php";

}

:)

Line #4 in that code would fail, for the exact same reason the OP's original code failed.

And why would you test if the file path stored in $filename exists, and then construct it? Makes no sense.

Edit:
Dormilich beat me to it :)

prabirchoudhury

ya sry guys, you both right .. i have bn in illusion with \ and / ... it will brk on line 4..

What is wrong with this code?

re: What is wrong with this code?

re: What is wrong with this code?

re: What is wrong with this code?

re: What is wrong with this code?

re: What is wrong with this code?

re: What is wrong with this code?

Similar PHP bytes

/bytes/development

/bytes/it

/bytes/about