Connecting Tech Pros Worldwide Help | Site Map
bytes > topic > php > answers

Php Upload script not working

Member
  
Join Date: Sep 2006
Posts: 35
#1: May 24 '08
hi,

I have found an upload script in hotscripts and have implemented it into the website, I followed the installation steps to 'give write permissions to php on the upload folder (which is _uploadedfiles_xxxx) (php must be allowed to move uploaded files to this folder' - uploadedfiles_xxxx.

I typed
Expand|Select|Wrap|Line Numbers
  1.  <?php chmod ('_uploadedfiles_xxxx',640); ?> 
into notepad and saved it as php in the uploaded_xxxx folder, when I went to test it, the error message I got was 'Error:invalid response received from server.'
This is the code which is quite long and thanks for any help received
Expand|Select|Wrap|Line Numbers
  1. <?php
  2.     @set_time_limit(90); // try to change to maximum allowed execution time for this page
  3.     define('CFG_UPLOADFOLDER','_uploadedfiles_xxxx/'); 
  4.     $bSecure = (isset($_SERVER['HTTPS']))? true : false;
  5.  
  6.     include('inc.ErrorHandling.php');
  7.     include('inc.init.php');
  8.     include('class.DataException.php');
  9.     include('class.File.php');
  10.  
  11.  
  12.  
  13.  
  14. function ProduceJavaScriptResponse($aResponse){
  15. $response = <<<EOD
  16. <html><head>
  17. <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  18. <meta http-equiv="Cache-Control" content="no cache" >
  19. <meta http-equiv="Pragma" content="no_cache" >
  20. <meta name="language" content="en" >
  21. </head>
  22. <body>
  23. <script type="text/javascript">{code}</script>
  24. </body></html>
  25. EOD;
  26.  
  27.     // encode into JSON
  28.     $jsResponse = 'window.parent.'. $_REQUEST['callback'] .'('. json_encode($aResponse) .');';
  29.     $response = str_replace('{code}', $jsResponse, $response);
  30.     return $response;
  31. }
  32.  
  33.  
  34.  
  35.  
  36. // Upload file
  37. $errorMessage = '';
  38. $aResponse = array();
  39. if ($_SERVER['REQUEST_METHOD'] == 'POST'){
  40. ############################################################
  41.  
  42.     if (!headers_sent()){
  43.         Header("Pragma: no-cache");
  44.         Header("Cache-Control: no-cache");
  45.         Header('Expires: '. GMDate("D,d M Y H:i:s") .' GMT');
  46.     }
  47.  
  48.     $blacklist = array('.php', '.phtml', '.php3', '.php4');
  49.     foreach ($blacklist as $item) {
  50.        if (preg_match("/$item\$/i", $_FILES['_file']['name'])){
  51.            $errorMessage = 'Uploading PHP files is not allowed!';
  52.        }
  53.     }
  54.  
  55.     try{
  56.         if ($errorMessage == ''){
  57.             $maxAllowedSize = null; // no limit (see FAQ)
  58.             $aAllowedContenTypes = null; // any file (see FAQ)
  59.             $oFile = File::UploadFile('_file', CFG_UPLOADFOLDER, $maxAllowedSize, $aAllowedContenTypes);
  60.         }
  61.     }catch(Exception $e){
  62.         $errorMessage = 'An error occured:'. $e->getMessage();
  63.     }
  64.  
  65.  
  66.     // produce response
  67.     if (isset($_REQUEST['output']) && $_REQUEST['output'] == 'js'){
  68.         if (!isset($_REQUEST['callback']) || empty($_REQUEST['callback'])){
  69.         // ERROR: BAD AJAX call
  70.  
  71.             $errorMessage = "Bad Ajax call! URL argument \'callback\' was not specified.";
  72.             die('<script type="text/javascript">alert("'. $errorMessage .'");</script>');
  73.  
  74.         }else if(empty($errorMessage) && $oFile){
  75.         // SUCCESS (file was uploaded)
  76.  
  77.             $aResponse['result'] = 'success';
  78.             $aResponse['file'] = array('size'          => $oFile->getSize(),
  79.                                        'sizeFormatted' => $oFile->FormatFileSize($oFile->getSize()),
  80.                                        'name'          => $oFile->getName()
  81.                                       );
  82.  
  83.         }else{
  84.         // UPLOAD ERROR
  85.  
  86.             $aResponse['result'] = 'failure';
  87.             $aResponse['message'] = 'Upload error ('. $errorMessage .').';
  88.  
  89.         }
  90.  
  91.         $response = ProduceJavaScriptResponse($aResponse);
  92.  
  93.     }else{
  94.         $response = file_get_contents('fileUploaded.tpl.php');
  95.  
  96.         $aValues = array($oFile->getName(), $oFile->FormatFileSize($oFile->getSize()));
  97.         $aPlaceHolders = array('{filename}', '{filesize}');
  98.         $response = str_replace($aPlaceHolders,$aValues,$response,$count);
  99.  
  100.     }
  101.     die($response);
  102.  
  103.  
  104. ############################################################
  105. }
  106.  
  107.  
  108. ?>
  109. <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
  110.             "http://www.w3.org/TR/html4/loose.dtd">
  111. <html lang="en">
  112.     <head>
  113.         <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  114.         <meta name="language" content="en" >
  115.         <meta name="description" content="Secure file uploading : a page for uploading files securely">
  116.         <meta name="author" content="attila szabo (www.w3net.eu)" >
  117.         <meta name="robots" content="noindex,nofollow" >
  118.         <title><?php if($bSecure){echo 'Secure ';}?>File Upload form</title>
  119.         <link media="handheld" href="css/handheld.css" type="text/css" rel="stylesheet">
  120.         <link rel="stylesheet" type="text/css" media="all" href="css/main.css">
  121.         <script type="text/javascript" src="js/common.js"></script>
  122.         <script type="text/javascript" src="js/FileListing.js"></script>
  123.         <script type="text/javascript" src="js/PageController.js"></script>
  124.     </head>
  125. <body id="home">
  126. <table border="0" cellpadding="0" cellspacing="0" width="627" align="center">
  127. <tr>
  128.     <td>
  129.     <div id="logo">
  130.     <img src="../images/logoGreyPurple.gif" width="627" height="75" border="0" alt="" /></div>    </td>
  131. </tr>
  132. </table>
  133.  
  134.  
  135. <table border="0" cellpadding="0" cellspacing="0" width="627" align="center">
  136. <tr>
  137.     <td>
  138.     <div id="imgHeader">
  139.     <img src="../images/acounts.jpg"  width="627" height="33" border="0" alt="" /></div>
  140.  
  141.     <div id="nav">
  142.     <ul>
  143.         <li><a href="index.html">Home</a></li>
  144.         <li><a href="about.html">About</a></li>
  145.         <li><a href="HowWeWork.html">How we work</a></li>
  146.         <li><a href="requirementsForm.html">Requirements Form</a></li>
  147.         <li><a href="servicesAndRates.html">Services &amp; Rates</a></li>
  148.         <li><a href="contact.html">Contact</a></li>
  149.     </ul>
  150.  
  151. </div>
  152. </table>    
  153.  
  154. <div id="container">
  155.     <ul id="skip">
  156.         <li><a href="#main">Skip to main content</a></li>
  157.         <li><a href="#form">Skip to the upload form</a></li>
  158.     </ul>
  159. <iframe id="uploadIfr" src="blank.htm" name="uploadIfr" class="hiddenUploadIframe" title="ignore this frame"></iframe>
  160.  
  161.     <!-- @@@ listing of uploaded files -->
  162.     <div id="uploadedFiles">
  163.     </div>
  164.     <!-- end listing of uploaded files @@@ -->
  165.  
  166.     <a name="main"></a>
  167.     <h1><?php if($bSecure){echo 'Secure file';}else{echo 'File';}?> uploading</h1>
  168.     <?php 
  169.     if($bSecure){
  170.     ?>
  171.     <p class="message" id="annotationSecure">
  172.     Uploading files using this web page is secure. This webpage transmits the file using a high-level encryption so that 
  173.     only I will be able to access the information. 
  174.     Web pages beginning with &quot;https&quot; instead of &quot;http&quot; enable secure information transmission.
  175.     </p><?php
  176.     }else{
  177.         echo "<p></p>";
  178.     }
  179.     ?>
  180.  
  181.  
  182.     <div id="frmAttachFile_ErrorMessage" class="form_boxErrorMsg" style="display: none"></div>
  183.  
  184.     <!-- @@@ file upload form -->
  185.     <div id="fileuploadForm"><a name="form"></a>
  186.     <form name='frmUploadFile' id="frmUploadFile" action="index.php" method="post" enctype="multipart/form-data" > <!-- uploadIfr -->
  187.         <fieldset title="Choose the file to upload">
  188.             <legend> 1: Choose a file to upload</legend>
  189.             <p>Click the button to browse the file system of your computer. Find and select the file you want to upload.</p>
  190.  
  191.             <label for="fileInput" class="form_label">File:</label>
  192.             <input type="file" accept="" name="_file" id="fileInput" >
  193.         </fieldset>
  194.         <fieldset id="confirmation" title="Confirmation">
  195.             <legend> 2: Upload file</legend>
  196.             <p>When you have selected the file to upload, click on the <strong>Upload</strong> button.</p>
  197.             <div class="actionBar" id="submitBtnBox">
  198.                 <input type="submit" value="Upload" >
  199.             </div>
  200.  
  201.         </fieldset>
  202.     </form>
  203.     </div>
  204.     <!-- end file upload form @@@ -->
  205. </div>
  206. </div>
  207. </body></html>
  208.  
This is the css if you want to have a look

Expand|Select|Wrap|Line Numbers
  1. BODY {
  2.     margin: 50px 0px 0px 0px;      
  3.     padding: 0px 0px 0px 0px;
  4.     font-family: arial, helvetica, sans-serif;
  5.  
  6. /* part 1 of 2 centering hack */
  7.     color:#000;
  8.     background:#C2CACB;
  9.     font-family:  arial, helvetica, sans-serif;
  10.     font-size: x-small; /* for IE5/Win */
  11.     voice-family: "\"}\""; 
  12.     voice-family: inherit;
  13.     font-size: small; /* for compliant browsers */
  14. } 
  15. html>body {font-size:small;}
  16.  
  17. #container {
  18.     font-size: 110%;
  19.     margin-right: auto;
  20.     margin-left: auto;     /* opera does not like 'margin:20px auto' */
  21.     background: #fff;
  22.     border:solid 1px #FFFFFF;
  23.     text-align:left; /* part 2 of 2 centering hack */
  24.     width: 627px; /* ie5win fudge begins */
  25.     voice-family: "\"}\"";
  26.     voice-family:inherit;
  27.     width: 627px;
  28. }
  29.  
  30. form {
  31.     margin: 0;
  32. }
  33.  
  34. #skip {
  35.     display: none;
  36. }
  37.  
  38. h1 {
  39.     font-size: 170%;
  40.     background: transparent url(../imgs/green_up.gif) no-repeat right;
  41.     padding-right: 40px;
  42.     padding-right: 30px;
  43.     display: inline;
  44. }
  45.  
  46. #uploadedFiles {
  47.     margin-bottom: 20px;
  48. }
  49.  
  50. #fileuploadForm {
  51.     margin-right: auto;                                                         
  52.     margin-left: auto;     /* opera does not like 'margin:20px auto' */
  53.     background: #fff;
  54.     border:solid 1px #FFFFFF;
  55.     text-align:left; /* part 2 of 2 centering hack */
  56.     width: 625px; /* ie5win fudge begins */
  57.     voice-family: "\"}\"";
  58.     voice-family:inherit;
  59.     width: 627px;                           
  60. }
  61.  
  62. fieldset {
  63.     border-left:0;
  64.     border-right:0;
  65.     border-bottom:0;
  66.     padding: 0.5em;
  67. }
  68.  
  69. legend {
  70.     background-color:#B2CBE7;
  71.     color:#000;
  72.     font-weight:bold;
  73.     margin:0px;
  74.     padding:5px 10px;        
  75. }
  76.  
  77. #confirmation {
  78.     margin-top: 2em;
  79. }
  80.  
  81. .actionBar {
  82.     background-color:#B2CBE7;
  83.     padding: 0.6em;
  84.     text-align: center;
  85.  
  86. }
  87.  
  88. .actionBar input {
  89.     font-size: 110%;
  90. }
  91.  
  92. .hiddenUploadIframe {
  93.     width:0;
  94.     height:0;
  95.     border:0;
  96.     position: absolute;
  97.     top: -1000px;
  98. }
  99.  
  100.  
  101.  
  102. /* Msg boxes
  103. ------------------------------ */
  104. .message {
  105.     margin: 1.5em 0;
  106. /*    padding: 15px;*/
  107.     font-size: 90%;
  108.     line-height: 1.5em;    
  109.     border-left: none;
  110.     border-right: none;
  111. }
  112.  
  113. .success {
  114.     background-color: #A2D489;
  115.     border-top: 3px solid #339900;
  116.     border-bottom: 3px solid #339900;
  117. }
  118.  
  119. .error {
  120.     background-color: #FFDDCC;
  121.     border-top: 3px solid #DD0000;
  122.     border-bottom: 3px solid #DD0000;
  123. }
  124.  
  125. .alert {
  126.     background-color: #FFF3CE;
  127.     border-top: 3px solid #FDDC9A;
  128.     border-bottom: 3px solid #FDDC9A;
  129. }
  130.  
  131. #annotationSecure {
  132.     background: #FFFFAA ;
  133.     padding:2px;
  134. /*  padding-left: 15px;*/
  135. }
  136.  
  137.  
  138.  
  139. /* Uploaded files
  140. ------------------------------ */
  141. table {
  142.     border-collapse:collapse;
  143. }
  144. #uploadedFiles caption {
  145.     line-height: 2.1em;
  146.     text-align: left;
  147.     padding-left: 20px;
  148.     background: #fff url(../imgs/lock.png) no-repeat left;
  149. }
  150. #uploadedFiles th,
  151. #uploadedFiles td{
  152.     border:1px solid #CCCCCC;
  153.     padding:0.5em;
  154. }
  155.  
  156. #uploadedFiles thead{
  157.     background-color:#DDDDDD;
  158. }
  159.  
  160. #uploadedFiles tr.rowodd {
  161.     background-color:#FFFFFF;
  162. }
  163. #uploadedFiles tr.roweven {
  164.     background-color:#F2F2F2;
  165. }
  166.  
  167.  
  168. /* Busy page
  169. ------------------------------ */
  170. #dropSheet{
  171.   background-color/**/: #000000;
  172.   background-image: url(imgs/dots.gif);
  173.   background-image/**/: none;
  174.   opacity: 0.35;
  175.   filter: alpha(opacity=35);
  176. }
  177. div.busyDialog {
  178.     background-color: #ECB7B2;
  179.     font-size: 110%;
  180.     font-weight: bold;
  181.     margin: 0;
  182.     padding: 0;
  183. }
  184. div.busyDialog p {
  185.     margin:0;
  186.     padding: 5px;
  187. }
  188.  
  189. /*    Footer    */
  190.  
  191. #footer {
  192.     width:627px; 
  193.     height:20px;
  194.     background-color:#FFFFFF;
  195.     font-family:Arial, Helvetica, sans-serif;
  196.     font-size:0.8em;
  197.     color:black;
  198.     text-align:center;
  199.     font-weight:normal;
  200.     padding-top:1%;
  201. }
  202.  
  203. /*Links - a, a:visited*/    
  204. a {
  205.     text-decoration: none;
  206.     color:  #000000;
  207.     }
  208.  
  209. a:visited {
  210.     color:#000000;
  211.     text-decoration:none;
  212. }
  213.  
  214.  
  215. /*    Misc    */
  216.  
  217. .margin {  /*margin between content &amp; footer*/        
  218.     margin-top:1.5%;
  219. }    
  220.  
  221. #nav {
  222.     width:627px;        
  223.     float:left;
  224.     font-family:Arial, Helvetica, sans-serif;
  225.     font-size:1.0em;
  226.     color:#ffffff;
  227. }
  228.  
  229. #nav ul {
  230.     background-color:#ffffff;
  231.     text-align:left;
  232.     font-size:1.0em;
  233.     font-family:Arial, Helvetica, sans-serif;
  234.     margin-left:0.95%;
  235.     padding-left:0;
  236.     margin-top:-.55%;
  237. }
  238.  
  239. #nav li {
  240.     list-style-type:none;
  241.     padding:1.6em 1em;
  242.     display:inline;
  243.     color:#5F5E61;
  244. }
  245.  
  246. #imgHeader {
  247.     margin-top:2%;
  248. }
  249.  
Markus's Avatar
Moderator
  
Join Date: Jun 2007
Location: York, England, with wolves.
Posts: 4,936
#2: May 24 '08

re: Php Upload script not working

The css is irrelevant :)

Quite a lengthy code as well.

At the moment I don't have time to check it out, but as a rule: don't use hotscripts. Have a look at this w3schools upload - well documented and cleaner.

Cheers
Member
  
Join Date: Sep 2006
Posts: 35
#3: May 24 '08

re: Php Upload script not working

thanks,

is there a way of making the upload script a bit more secure so only certain people can upload onto the server
Markus's Avatar
Moderator
  
Join Date: Jun 2007
Location: York, England, with wolves.
Posts: 4,936
#4: May 25 '08

re: Php Upload script not working

Quote:

Originally Posted by camphor

thanks,

is there a way of making the upload script a bit more secure so only certain people can upload onto the server

You'd need a registration system, which takes usernames, etc. Then a login system - once logged in, set a session which says "logged_in" = true.

Check for this session on your upload page, if it's set, allow the upload, else, don't.

:)
Member
  
Join Date: Sep 2006
Posts: 35
#5: May 28 '08

re: Php Upload script not working

thanks markusn00b,

Your help much appreciated, decided not to have login, anyway, I read through the W3Schools php file upload link which you provided, newbie to php, so found it easy to understand but when I uploaded the 'upload page' and checked on the server to see if the .xls (excel - only want this type of file) file was in the upload folder, it wasn't, don't know why?

Also if I want the .xls file to use a high-level encryption so that only I will be able to access the information would this be the correct php code
Expand|Select|Wrap|Line Numbers
  1. <?php if($bSecure){echo 'Secure file';}else{echo 'File';}?>
After the file has been uploaded how would I write 'thank you for uploading your file'

Expand|Select|Wrap|Line Numbers
  1. <?php
  2. if ((($_FILES["file"]["type"] == ".xls")
  3. || ($_FILES["file"]["type"] == ".xls")
  4. || ($_FILES["file"]["type"] == ".xls"))
  5. && ($_FILES["file"]["size"] ))
  6.   {
  7.   if ($_FILES["file"]["error"] > 0)
  8.     {
  9.     echo "Return Code: " . $_FILES["file"]["error"] . "<br />";
  10.     }
  11.   else
  12.     {
  13.     echo "Upload: " . $_FILES["file"]["upload_file.php"] . "<br />";
  14.     echo "Type: " . $_FILES["file"][".xls"] . "<br />";
  15.     echo "Size: " . ($_FILES["file"]["size"] / 1024) . " Kb<br />";
  16.     echo "Temp file: " . $_FILES["file"]["tmp_name"] . "<br />";
  17.  
  18.     if (file_exists("upload/" . $_FILES["file"]["name"]))
  19.       {
  20.       echo $_FILES["file"]["upload_file.php"] . " already exists. ";
  21.       }
  22.     else
  23.       {
  24.       move_uploaded_file($_FILES["file"]["upload"],
  25.       "upload/" . $_FILES["file"]["name"]);
  26.       echo "Stored in: " . "upload/" . $_FILES["file"]["upload"];
  27.       }
  28.     }
  29.   }
  30. else
  31.   {
  32.   echo "Invalid file";
  33.   }
  34. ?>
  35.  
Markus's Avatar
Moderator
  
Join Date: Jun 2007
Location: York, England, with wolves.
Posts: 4,936
#6: May 28 '08

re: Php Upload script not working

First question: you need to specify correct mime types for the ['type'] check.

HAve a look at this for mime types of xls

Second question: confused?

Third question: the else statement on line 22 is where the file is uploaded successfully.
So, in this statement echo "Thankyou..."

:)
Reply

« previous question | next question »

Similar PHP bytes

/bytes/development

/bytes/it

/bytes/about

We are a network of experts and professionals in IT and software development that help one another with answers to tough questions and share insights. Get the best answers to your questions from over 226,223 network members.

dev questions:
algorithms | asp | asp.net | c/c++ | coldfusion | c# | flash | html/css | java | javascript |
mobile dev | .net | perl | php | python | ruby | software dev | vb.net | visual basic | xml
it questions:
access | apache | careers | db2 | iis | macosx | mysql | networking | oracle | postgresql | sql server | unix | windows

About Bytes | Copyright 1995-2009 BYTES. All rights Reserved