Incorrect Format value return from the subroutine | Newbie | | Join Date: Apr 2007
Posts: 6
| | |
Perl, I have a main program which calls two subroutines (depending upon the report names).In the subroutine I am printing the data from CSV file using the format variable, Format_top prints the report header and STDOUT prints the report data. Both these subroutine runs fine individually, independent of each other. Now I have included both these subroutine in my main program and I call these subroutine depending upon the name of the report. Here is my problem:
1. When I run this program the format of second subroutine is displayed for the first subroutine.
2. Output display only the header and data for the first report and for the second subroutine it displays only data, no header is displayed for the second subroutine.
Can any one help me with this????
|  | Expert | | Join Date: Jan 2007 Location: Southern California USA
Posts: 4,091
| | | re: Incorrect Format value return from the subroutine
how can we help without seeing your code?
| | Newbie | | Join Date: Apr 2007
Posts: 6
| | | re: Incorrect Format value return from the subroutine
Thanks for the responce, i am a beginner and not much familier with perl.
So here is my one subroutine and the second subroutine is also similar but the only difference is it has more number of columns. -
sub abc() {
-
$last_element = @raw_data;
-
$report_name = @raw_data[0];
-
$column_name = @raw_data[1];
-
-
chop($column_name);
-
$column_name =~s/"/\ /g;
-
($column_name1, $column_name2, $column_name3, $column_name4) = split(/,/,$column_name);
-
write;
-
-
foreach $field (@raw_data[2..$last_element]) {
-
chop($field);
-
$field=~tr/"//d;
-
($Date, $code, $TotalMsg, $Zmsgs) = split(/\,/,$field);
-
write;
-
}
-
-
format STDOUT_TOP =
-
-
@|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
-
$report_name
-
@<<<<<<<<<<<@<<<<<<<@<<<<<<<<<<@<<<<<<<<<<<<<<<<<<<@<<<<<<<<<<<<<
-
$column_name1,$column_name2,$column_name3,$column_name4
-
==================================================================
-
.
-
-
format STDOUT =
-
@<<<<<<<<<<<@<<<<<<<@<<<<<<<<<<@<<<<<<<<<<@
-
$Date,$code,$TotalMsg,$Zmsgs
-
.
-
-
}
-
and in my main program i am calling these two subroutine as shown below, and i am passing the content of the CSV file as a parameter to the subroutine. -
if (@raw_data[0] eq "Counts") {
-
&abc(@raw_data);
-
} else (@raw_data[0] eq "Count1") {
-
&abc1(@raw_data);
-
}
-
I hope this makes things more clear.
| | Newbie | | Join Date: Apr 2007
Posts: 6
| | | re: Incorrect Format value return from the subroutine
Can anybody please help with this!!!!
| | Expert | | Join Date: Jan 2007 Location: Southern California USA
Posts: 4,091
| | | re: Incorrect Format value return from the subroutine
I can't tell from what you posted what the problem might be. Post the code, with the second subroutine, and some sample data.
| | Expert | | Join Date: Jan 2007 Location: Southern California USA
Posts: 4,091
| | | re: Incorrect Format value return from the subroutine
actually, this is suspect: - if (@raw_data[0] eq "Counts")
-
{
-
&abc(@raw_data);
-
}
-
else (@raw_data[0] eq "Count1")
-
{
-
&abc1(@raw_data);
-
}
the else {} block should not have any conditional statement: - if (@raw_data[0] eq "Counts")
-
{
-
&abc(@raw_data);
-
}
-
else
-
{
-
&abc1(@raw_data);
-
}
if you need to check the value of @raw_data[0] use an elsif condition: - if ($raw_data[0] eq "Counts")
-
{
-
&abc(@raw_data);
-
}
-
elsif ($raw_data[0] eq "Count1")
-
{
-
&abc1(@raw_data);
-
}
-
else {
-
print "error";
-
}
you should also be using $raw_data[0] instead of @raw_data[0]. $raw_data[0] is a scalar, @raw_data[0] isn't really a scalar but perl will probably treat it as one in that context.
| | Newbie | | Join Date: Apr 2007
Posts: 6
| | | re: Incorrect Format value return from the subroutine
thanks for the responce and here is my second subroutine - #####################################
-
#Subroutine for Dealer reports
-
#####################################
-
-
sub abc1()
-
{
-
local ($report_name,$column_name,$column_name1,$column_name2,$column_name3,$column_name4,$column_name5,$column_name6,$column_name7,$column_name8,$column_name9,$column_name10,$column_name11,$column_name12,$column_name13,$column_name14,$column_name15);
-
local ($Date,$code,$Plan,$Beg,$Act,$NAct,$Add,$DeAct,$MIN,$Max,$Nadd,$EBal,$AUser,$TMsg,$Zm,$last_el)= 0;
-
-
$last_element=@raw_data; # to find the total number of elements in the file
-
-
$report_name = @raw_data[0];
-
$column_name = @raw_data[1];
-
-
chop($column_name);
-
$column_name =~s/"/\ /g;
-
($column_name1,$column_name2,$column_name3,$column_name4,$column_name5,$column_name6,$column_name7,$column_name8,$column_name9,$column_name10,$column_name11,$column_name12,$column_name13,$column_name14,$column_name15) = split(/,/,$column_name);
-
write;
-
-
-
foreach $field (@raw_data[2..$last_element])
-
{
-
chop($field);
-
$field=~tr/"//d;
-
($Date,$code,$Plan,$Beg,$Act,$NAct,$Add,$DeAct,$MIN,$Max,$Nadd,$EBal,$AUser,$TMsg,$Zm,$last_el)=split(/\,/,$field);
-
write;
-
}
-
-
format STDOUT_TOP =
-
-
@|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
-
$report_name
-
@<<<<<<<<<<<@<<<<<<<@<<<<<<<<<<@<<<<<<<<<<<<<<<<<<<@<<<<<<<<<<<<<@<<<<<<<<<<<<<<<<@<<<<<<<<<<@<<<<<<<<<<<<<@<<<<<<<<<<<<<@<<<<<<<<<<<<<<@<<<<<<<<<@<<<<<<<<<<<<<<<<@<<<<<<<<<<<<<@<<<<<<<<<<<<<<@<<<<<<<<<<<<<<<<<<<<<<<<
-
$column_name1,$column_name2,$column_name3,$column_name4,$column_name5,$column_name6,$column_name7,$column_name8,$column_name9,$column_name10,$column_name11,$column_name12,$column_name13,$column_name14,$column_name15
-
==============================================================================================================================================================================================================================
-
.
-
format STDOUT =
-
@<<<<<<<<<<<@<<<<<<<@<<<<<<<<<<@<<<<<<<<<<@<<<<<<<<<<<<<@<<<<<<<<<<<<<<<<@<<<<<<<<<<@<<<<<<<<<<<<<@<<<<<<<<<<<<<@<<<<<<<<<<<<<<@<<<<<<<<<@<<<<<<<<<<<<<<<<@<<<<<<<<<<<<<@<<<<<<<<<<<<<<@<<<<<<<<<<<<<<<<<<<<<<<<
-
$Date,$code,$Plan,$Beg,$Act,$NAct,$Add,$DeAct,$MIN,$Max,$Nadd,$EBal,$AUser,$TMsg,$Zm,$last_el
-
.
-
}
-
From the main program i am sending the report header and that will avcivate the respective subroutine.
| | Expert | | Join Date: Jan 2007 Location: Southern California USA
Posts: 4,091
| | | re: Incorrect Format value return from the subroutine
Are you using a really old vesion of perl?
| | Newbie | | Join Date: Apr 2007
Posts: 6
| | | re: Incorrect Format value return from the subroutine
Ok, so do u think that could be the the reason?
Can you please suggest me which version should i use to get read of this problem.
| | Expert | | Join Date: Jan 2007 Location: Southern California USA
Posts: 4,091
| | | re: Incorrect Format value return from the subroutine
if you are using an old version of perl I think the code would be OK. I never use the "write" function, so I really am at a loss to determine what the problem might be.
Whats with these gaps in the code you posted?
just a copy and paste problem?
| | Newbie | | Join Date: Apr 2007
Posts: 6
| | | re: Incorrect Format value return from the subroutine
yes, i guess that a copy paste problem. Thanks for your help.
|  |
| | |  /bytes/about
We are a network of experts and professionals in IT and software development that help one another with answers to tough questions and share insights.
Get the best answers to your questions from over 226,366 network members.
|
