Rethrowing "finished" exception?

Please could someone on the VC++ 7.0 compiler team (note; not 7.1)
tell me if this code is handled 'correctly' (i.e. as the original
poster suggests) in all cases?

http://groups.google.com/groups?hl=e...y1.airnews.net

(Incase the URL doesn't make it I've copied it below.)

I have a situation where I really need this technique. But the fact
that Dave Abrahams wasn't sure about it very much worries me...

Many thanks,

Chris Newcombe, Valve Software.

------------

From: "Bill Wade" <bill.wade@stoner.com>
Subject: Defect Report: Rethrowing "finished" exception?
Date: 2000/02/29
Message-ID: <89ed5u$8ck@library1.airnews.net>#1/1
Newsgroups: comp.std.c++

Paragraph seven of "15.1 Throwing an exception" [except.throw]
discusses which exception is thrown by a throw-expression with no
operand.

May an expression which has been "finished (15.1p7)" by an inner catch
block be rethrown by an outer catch block?

catch(...) // Catch the original exception
{
try{ throw; } // rethrow it at an inner level (in reality this is
probably inside a function)
catch (...)
{
} // Here, an exception (the original object) is "finished"
according to 15.1p7 wording

// 15.1p7 says that only an unfinished exception may be rethrown.
throw; // Can we throw it again anyway? It is certainly still
alive (15.1p4).
}

I believe this is ok, since the paragraph says that the exception is
finished when the "corresponding" catch clause exits. However since
we have two clauses, and only one exception, it would seem that the
one exception gets "finished" twice.

re: Rethrowing "finished" exception?

chrisn@valvesoftware.com (Chris Newcombe) wrote in message news:<a6cd7f01.0309022127.66a8cb18@posting.google. com>...[color=blue]
> Please could someone on the VC++ 7.0 compiler team (note; not 7.1)
> tell me if this code is handled 'correctly' (i.e. as the original
> poster suggests) in all cases?
>
> http://groups.google.com/groups?hl=e...y1.airnews.net[/color]


Well if no-one here can answer this, can someone please tell me
who/where I should ask?

Thanks,

Chris

re: Rethrowing "finished" exception?

"Carl Daniel [VC++ MVP]" <cpdaniel@nospam.mvps.org> wrote in message news:<#Qf$Q01cDHA.2296@TK2MSFTNGP09.phx.gbl>...[color=blue]
> I agree with James Kuyper & Dave Abrahams that the code presented in the
> original posting probably should call terminate(), according to the
> standard.[/color]

Thanks Carl. However I think Dave Abrahams was actually agreeing with
the original poster, that the code should be OK...
[color=blue]
>Dave Abrahams wrote:
>in article 89ed5u$8ck@library1.airnews.net, Bill Wade at
>bill.wade@stoner.com wrote on 2/29/00 6:04 AM:[color=green]
>> I believe this is ok, since the paragraph says that the exception[/color][/color]
is[color=blue][color=green]
>> finished when the "corresponding" catch clause exits. However[/color][/color]
since we have[color=blue][color=green]
>> two clauses, and only one exception, it would seem that the one[/color][/color]
exception[color=blue][color=green]
>> gets "finished" twice.[/color]
>
>FWIW, I agree that your interpretation is the only one that makes[/color]
sense.

[color=blue]
> FWIW, both VC7 and VC7.1 (but not VC6) appear to implement what you want
> this code to mean:[/color]

Thanks -- yes I'm already using it and it appears to work. However
given the apparent ambuiguity of the standard I'd really like to get
an authoratative statement from the compiler developers that the code
generated is correct in all cases (i.e. has no side effects, and isn't
just acceidentally appearing to work).

I do plan to ask on comp.std.c++ but any defect report or ambiguity
resolution will be far too late to affect my current project. I
really need to know asap if this technique is practically safe with
the current VC++ 7.0 compiler.

Is there a developer on this list who worked on exception handling?

regards,

Chris

re: Rethrowing "finished" exception?

Chris Newcombe wrote:[color=blue]
> "Carl Daniel [VC++ MVP]" <cpdaniel@nospam.mvps.org> wrote in message[color=green]
>> FWIW, both VC7 and VC7.1 (but not VC6) appear to implement what you
>> want
>> this code to mean:[/color]
>
> Thanks -- yes I'm already using it and it appears to work. However
> given the apparent ambuiguity of the standard I'd really like to get
> an authoratative statement from the compiler developers that the code
> generated is correct in all cases (i.e. has no side effects, and isn't
> just acceidentally appearing to work).
>
> I do plan to ask on comp.std.c++ but any defect report or ambiguity
> resolution will be far too late to affect my current project. I
> really need to know asap if this technique is practically safe with
> the current VC++ 7.0 compiler.
>
> Is there a developer on this list who worked on exception handling?[/color]

I've raised the issue to the VC team, requesting that someone from the
compiler team comment on your question. From what I understand about how VC
implements exception handling, you're safe in relying on the current
behavior for at least VC7 and 7.1 - of course, there's no guarantee about
the future.

I don't have access to any other compilers, but my guess is that the
behavior of the VC-compiled application is a side-effect of how VC layers
C++ EH on top of Win32 structured exception handling. I would expect other
implementations to probably not have the behavior you're counting on. Under
the VC model, the "catch clause" is effectively called as if it was a
subroutine called at the point of the throw. Under most other models, the
catch clause is entered as-if by longjump after the stack has been unwound.
In that model, it seems likely to me that the exception object will be
destroyed by the middle catch clause and the attempted re-throw will result
in a call to terminate().

-cd

re: Rethrowing "finished" exception?

> From: chrisn@valvesoftware.com (Chris Newcombe)[color=blue]
> Thanks -- yes I'm already using it and it appears to work. However
> given the apparent ambuiguity of the standard I'd really like to get
> an authoratative statement from the compiler developers that the code
> generated is correct in all cases (i.e. has no side effects, and isn't
> just acceidentally appearing to work).
>
> I do plan to ask on comp.std.c++ but any defect report or ambiguity
> resolution will be far too late to affect my current project. I
> really need to know asap if this technique is practically safe with
> the current VC++ 7.0 compiler.
>
> Is there a developer on this list who worked on exception handling?[/color]

I implemented the fix in the CRT to get this example working in VC++ 7.0,
back about 4 years ago. Under the current implementation, when a catch
block exits via normal fall-through, the exception object will be destroyed
except when the catch block is nested within some other catch block which
is using the same exception object.

Now as it turns out, Bill Wade submitted this as a defect report back in
Feb 2000 (see issue 208,
http://www.comeaucomputing.com/iso/c...ects.html#208). That DR has a
status of WP, which means that the standards committee has voted to apply
the issue to the current Working Paper. That is, this will be officially
fixed in the C++0x, but not in the current standard. I have no information
on just why that is.

As it stands, yes, you can count on VC++ 7.0 and beyond to act as you wish
here, since we went out of our way to make sure that was true. The earlier
implementation would just destroy the exception object when exiting a catch
block via fall-through, even when nested within another catch block.

Do note that this behavior is not guaranteed by the current C++ standard,
so it's not likely to be portable, as Carl Daniel stated.

...Phil (one-time VC++ CRT dev)

--
Phil Lucido, Microsoft Visual C++ Team
This posting is provided "AS IS" with no warranties, and confers no rights.
Use of included script samples are subject to the terms specified at
http://www.microsoft.com/info/cpyright.htm

re: Rethrowing "finished" exception?

"Visual C++ Team" wrote:[color=blue]
> As it stands, yes, you can count on VC++ 7.0 and beyond to act as you
> wish here, since we went out of our way to make sure that was true.
> The earlier implementation would just destroy the exception object
> when exiting a catch block via fall-through, even when nested within
> another catch block.
>
> Do note that this behavior is not guaranteed by the current C++
> standard, so it's not likely to be portable, as Carl Daniel stated.[/color]

Thanks for the gorey details, Phil!

-cd

re: Rethrowing "finished" exception?

philiplu@online.microsoft.com ("Visual C++ Team") wrote in message news:<chKx#3jdDHA.2220@cpmsftngxa06.phx.gbl>...[color=blue]
> I implemented the fix in the CRT to get this example working in VC++ 7.0,
> back about 4 years ago.[/color]

Great stuff -- thankyou very much for taking the time to give this much detail.

regards,

Chris (much relieved :)