James Walker wrote:[color=blue]
>
> Can some one help I get an error of 'checkIndate' is null or not an object
>
> can someone please help. I can't work out why
>
> Thanks in advance
>
> James[/color]
<snip><snip>
Hi James,
Please find below a working version of the script and code.
Even when the mentioned problem had been solved, the function still
contained quite some problems most of which would "break" the function
as well.
I'll summarize them for you:
* You open the form twice
* The input button which called the js function was outside of the form
* The form fields had id's however, they should be named ( i.e.
name="adults"). Good guideline: use non-capitalized words only. (i.e.
checkindate in stead of checkInDate)
Preferably you should then use the id's to attach the labels to the
field so that the form will be better accessible - using tabindex would
help too, but that's of course off topic.
* The onClick function wasn't passing the form and for some reason the
"theForm" variable wasn't picking it up either
* Javascript is case-sensitive so (please note that the astrixes have
only been added to point out the problem letter):
"theForm.checkIndate[checkInDate.selectedIndex].value" will never work
when you mean "theForm.checkIn*D*ate[checkInDate.selectedIndex].value.
Similar: "theForm.adults[adults.selectedindex].value" can't work when
you mean "theForm.adults[adults.selected*I*ndex].value"
* The syntax for getting the value of a selected option in a selectlist
is:
form.field.options[form.field.selectedindex].value
So missing out the "options" part and the second "form" will also make
sure your function won't work
* The last part where you are stringing text together, you are referring
to for instance "month" and "year" while the variables you created are
named differently, i.e. "checkInMonth" and "checkInYear".
Again, obviously the function will break on that too.
Please note: I haven't cleaned up your code, only adjusted it to make it
work.
Tested & working in IE6 and NS7.
Good luck,
Juliette
<HTML><HEAD></HEAD><BODY>
<TABLE>
<td height="24" colspan="7" valign="top"><form
name="booknow"><select
name="checkindate" class="f11">
<option value="1" >1</option>
<option value="2" >2</option>
<option value="3" >3</option>
<option value="4" >4</option>
<option value="5" >5</option>
<option value="6" >6</option>
<option value="7" >7</option>
<option value="8" >8</option>
<option value="9" >9</option>
<option value="10" >10</option>
<option value="11" >11</option>
<option value="12" >12</option>
<option value="13" >13</option>
<option value="14" >14</option>
<option value="15" >15</option>
<option value="16" >16</option>
<option value="17" >17</option>
<option value="18" >18 </option>
<option value="19" >19</option>
<option value="20" >20</option>
<option value="21">21</option>
<option value="22" >22</option>
<option value="23" >23</option>
<option value="24">24</option>
<option value="25" >25</option>
<option value="26">26</option>
<option value="27">27</option>
<option value="28" >28</option>
<option value="29 ">29</option>
<option value="30" >30</option>
<option value="31" >31</option>
</select>
<select name="month" id="month" class="f11">
<option value="1" >Jan</option>
<option value="2" >Feb</option>
<option value="3">Mar</option>
<option value="4" >Apr</option>
<option value="5" >May</option>
<option value="6" >Jun</option>
<option value="7" >Jul</option>
<option value="8" >Aug</option>
<option value="9" >Sep</option>
<option value="10" >Oct</option>
<option value="11" >Nov</option>
<option value="12" >Dec</option>
</select>
<select name="year" id="year" class="f11">
<option value="03" >2003</option>
<option value="04" >2004</option>
<option value="05" >2005</option>
<option value="06" >2006</option>
</select>
</td>
</tr>
<tr>
<td width="44" height="15" valign="top"><strong>Adults</strong></td>
<td width="15"></td>
<td width="50" valign="top"><strong>Nights</strong></td>
<td width="15"></td>
<td colspan="2" valign="top"><strong>Rooms</strong></td>
<td width="11"></td>
</tr>
<tr>
<td height="29" colspan="2" valign="top"><select name="adults"
id="adults" class="f11">
<option value="1" >1</option>
<option value="2" >2</option>
<option value="3" >3</option>
<option value="4" >4</option>
<option value="5" >5</option>
<option value="6" >6</option>
<option value="7" >7</option>
</select></td>
<td valign="top"><select name="nights" id="nights" class="f11">
<option value="1" >1</option>
<option value="2" >2</option>
<option value="3" >3</option>
<option value="4" >4</option>
<option value="5" >5</option>
<option value="6" >6</option>
<option value="7" >7</option>
</select></td>
<td> </td>
<td colspan="2" valign="top"><select name="rooms" id="rooms"
class="f11">
<option value="1" >1</option>
<option value="2" >2</option>
<option value="3" >3</option>
<option value="4" >4</option>
<option value="5" >5</option>
<option value="6" >6</option>
<option value="7" >7</option>
</select></td>
<td></td>
</tr>
<tr>
<td height="20"></td>
<td></td>
<td></td>
<td> </td>
<td width="42" valign="top"><input type=submit value="Go!"
onclick="doURL(this.form)"></form></TD>
</TR>
</TABLE>
<script language="JavaScript">
function doURL(form) {
var
checkInDate=form.checkindate.options[form.checkindate.selectedIndex].value;
var checkInMonth=form.month.options[form.month.selectedIndex].value;
var checkInYear=form.year.options[form.year.selectedIndex].value;
var
numberOfNights=form.nights.options[form.nights.selectedIndex].value;
var
numberOfAdults=form.adults.options[form.adults.selectedIndex].value;
var
numberOfRooms=form.rooms.options[form.rooms.selectedIndex].value;
var t =
"http://www.ichotelsgroup.com/redirect?checkInDatebrandCode=6c"+
"&path=asearch&city=London&countryId=0925&rateType Codes=6CBARC"+
"&checkInDate="+checkInDate+
"&checkInMonth="+checkInMonth+
"&checkInYear="+checkInYear+
"&numberOfNights="+numberOfNights+
"&numberOfAdults="+numberOfAdults+
"&numberOfRooms="+numberOfRooms+
"&hotelCode=LONLH";
window.open(t,"_blank","");
}
//-->
</script>
</BODY>
</HTML>
