Multiple 'If' statements - is there a better way to write this?

patelxxx

Expand|Select|Wrap|Line Numbers

 var locationID=document.getElementById("locationID");
 
        if (locationID.value!="England")

        if (locationID.value!="Wales")

        if (locationID.value!="Ireland")

        if (locationID.value!="Scotland")

        {

            alert("Please enter a location"); 

            return false;

        }

Please use CODE tags - MODERATOR
Is there a better way to write this (see above code)? If you can start me start off that would be great.

cheers

acoder

Moved from Articles section.

Please post code using CODE tags.

acoder

Quote:

Originally Posted by patelxxx

Is there a better way to write this (see above code)? If you can start me start off that would be great.

If locationID is select object, then just check if the value is equal to the empty string.

theS70RM

yea what he said, i.e.:

Expand|Select|Wrap|Line Numbers

 var locationID=document.getElementById("locationID");
 
if (locationID.value == "") {

  alert("Please enter a location");

  return false;

}

or if u need to check they havn't entered some other spurious location then:

Expand|Select|Wrap|Line Numbers

 function checklocation(){
 
var locationID=document.getElementById("locationID");
 
var allowed_locations = new Array("England", "Wales", "Ireland", "Scotland");
 
  for (i=0; i<=allowed_locations.length; i++){

    if (locationID == allowed_locations[i])

      return true;

  }

alert("enter a location");

return false;

}

be sure to check case sensitivity if you have let them enter this rather than using a dropdown box.

Multiple 'If' statements - is there a better way to write this?

re: Multiple 'If' statements - is there a better way to write this?

re: Multiple 'If' statements - is there a better way to write this?

re: Multiple 'If' statements - is there a better way to write this?

Similar JavaScript / Ajax / DHTML bytes

/bytes/development

/bytes/it

/bytes/about