Firefox won't work with show/hide div script

Idimmu

This code works fine in IE, but doesn't do anything in Firefox. Is there an issue with the layer_ref?
If you could re-write this to make it work, I would love you for it!

Expand|Select|Wrap|Line Numbers

 
<!-- Start Show / Hide Div Script -->

<script language="javascript">

        <!--

        var state = 'none';
 
        function showhide(layer_ref) {
 
        if (state == 'block') {

        state = 'none';

        }

        else {

        state = 'block';

        }

        if (document.all) { //IS IE 4 or 5 (or 6 beta)

        eval( "document.all." + layer_ref + ".style.display = state");

        }

        if (document.layers) { //IS NETSCAPE 4 or below

        document.layers[layer_ref].display == state;

        }

        if (document.getElementById && !document.all) {

        maxwell_smart = document.getElementById(layer_ref);

        maxwell_smart.style.display == state;

        }

        }

        //-->

</script>

<!-- End Show / Hide Div Script -->

iam_clint

document.all (not supported by most browsers)

use document.getElementById()

acoder

Also, the line

Expand|Select|Wrap|Line Numbers

maxwell_smart.style.display == state;

should be

Expand|Select|Wrap|Line Numbers

maxwell_smart.style.display = state;

You are comparing instead of setting.

sumittyagi

also:
eval( "document.all." + layer_ref + ".style.display = state");

should be:
eval("document.all." + layer_ref + ".style.display = " + state);

//but use document.getElementById(layer_ref).style.display = state; instead

//document.all is supported in firefox, but it is depricated, i.e. a warning message is shown.
but document.getElementById is supported in almost all the browsers.

Firefox won't work with show/hide div script

re: Firefox won't work with show/hide div script

re: Firefox won't work with show/hide div script

re: Firefox won't work with show/hide div script

Similar JavaScript / Ajax / DHTML bytes

/bytes/development

/bytes/it

/bytes/about