Storing and Using user input in GUI

[rickytb]

Hey all,
I've hit a snag on a beginner Java problem involving building occupancy. I'm supposed to get user input from a GUI. My main problem is that I'm totally lost on how to take the information from the user and implement it in my GUI. I have the display set up the way I want but can't use the input. I don't quite know what to do. Whenever I hit one of the buttons I get "Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException" at pretty much everywhere. Would any of you be able to take a look at my code and find out what I'm doing wrong and give me insight on how to fix it.

Thanks

import java.util.Scanner;
import java.io.*;
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
public class Building3 
{
 
 
    static JFrame frame;
    static Container pane;
    static JLabel totalRes;
    static JLabel total;
    static int sumOccupants;
    static JLabel average;
    static JLabel avgApt;
    static double avgPer;
    static JLabel above;
    static JLabel avgAbove;
    static int noAbove;
    static JLabel below;
    static JLabel avgBelow;
    static int noBelow;
    static JPanel panel;
    static JTextField apartment;
    static int aptNo;
    static JTextField residents;
    static int[] occupants;
    static JButton store;
    static JButton quit;
    static TotalHandler operation;
 
    static class TotalHandler implements ActionListener
    {
        public void actionPerformed(ActionEvent event)
        {
            String whichButton;
            whichButton = event.getActionCommand();
            if (whichButton.equals("Store"))
            {
                aptNo = Integer.valueOf(apartment.getText()).intValue();
                occupants[aptNo] = Integer.valueOf(residents.getText()).intValue();
            }
 
            else if (whichButton.equals("Quit"))
            {
                for (int aptNo = 0; aptNo < occupants.length; aptNo++)
                    sumOccupants = sumOccupants + occupants[aptNo];
                avgPer = sumOccupants / aptNo;
                if (occupants[aptNo] > avgPer)
                    noAbove++;
                if (occupants[aptNo] < avgPer)
                    noBelow++;
            }
            total.setText("" + sumOccupants);
            avgApt.setText("" + avgPer);
            avgAbove.setText("" + noAbove);
            avgBelow.setText("" + noBelow);
            apartment.setText("");
            residents.setText("");
        }
    }    
    public static void main(String[] args)
    {
        final int BUILDING_SIZE = 10;
        final int MAX_OCCUPANTS = 20;
 
        operation = new TotalHandler();
        int[] occupants = new int[BUILDING_SIZE];
 
        occupants[aptNo] = 0;
        sumOccupants = 0;
        avgPer = 0.0;
        noAbove = 0;
        noBelow = 0;
 
        totalRes = new JLabel("Total Residents:");
        total = new JLabel("0", JLabel.RIGHT);
        average = new JLabel("Avg number of residents per apt:");
        avgApt = new JLabel("0.0", JLabel.RIGHT);
        above = new JLabel("Above average occupancy number:");
        avgAbove = new JLabel("0", JLabel.RIGHT);
        below = new JLabel("Below average occupancy number:");
        avgBelow = new JLabel("0", JLabel.RIGHT);
 
        apartment = new JTextField("Enter apartment number");
        String str = apartment.getText();
        residents = new JTextField("Enter number of residents");
        String str1 = residents.getText();
 
        store = new JButton("Store");
        quit = new JButton("Quit");
 
        store.addActionListener(operation);
        quit.addActionListener(operation);
 
        frame = new JFrame();
        frame.setSize(500, 200);
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        pane = frame.getContentPane();
        pane.setLayout(new GridLayout(6, 2));
 
        pane.add(totalRes);
        pane.add(total);
        pane.add(average);
        pane.add(avgApt);
        pane.add(above);
        pane.add(avgAbove);
        pane.add(below);
        pane.add(avgBelow);
        pane.add(apartment);
        pane.add(residents);
        pane.add(store);
        pane.add(quit);
        frame.setVisible(true);
    }
}
 

When the store button is pressed the apartment number should go in the array and the residents number should be stored. Then the textFields should be empty for new input. When quit is pressed it should calculate the averages and other calculations. however, when I press a button it results in error.

[jkmyoung]

in Main you've got
occupants[aptNo] = 0;
but you haven't set aptNo yet.


In your event handler you use
aptNo = Integer.valueOf(apartment.getText()).intValue();
without handling the case where the string isn't an integer, and you use

occupants[aptNo]
without checking that aptNo is a valid apartment number.

[rickytb]

Ok, so I've simplified my application and removed all of the "static" in it. When I run the application it no longer results in errors but I still haven't really moved anywhere.

I think I'm having serious issues with the JButtons. Right now, i'm failing to see why this isn't working. When I hit either the "store" or "quit" buttons nothing happens and I don't know what to do.

I feel as if when I'm trying to figure it out I'm over-complicating things and am missing the simple answer. If somebody would be able to review my new code and point out where I'm goofing up it would be great.

Thanks

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
class Building5 implements ActionListener
{
 
 
    JFrame frame = new JFrame();
    Container pane = frame.getContentPane();
    JLabel totalRes = new JLabel("Total Residents:");
    JLabel total = new JLabel("0", JLabel.RIGHT);
    JLabel average = new JLabel("Avg number of residents per apt:");
    JLabel avgApt = new JLabel("0.0", JLabel.RIGHT);
    JLabel above = new JLabel("Above average occupancy number:");
    JLabel avgAbove = new JLabel("0", JLabel.RIGHT);
    JLabel below = new JLabel("Below average occupancy number:");
    JLabel avgBelow = new JLabel("0", JLabel.RIGHT);
 
    JTextField apartment = new JTextField("Enter apartment number");
 
    JTextField residents = new JTextField("Enter number of residents");
 
 
    JButton store = new JButton("Store");
    JButton quit = new JButton("Quit");
 
    public Building5()
    {
 
        frame.setSize(500, 200);
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        pane = frame.getContentPane();
        pane.setLayout(new GridLayout(6, 2));
 
        pane.add(totalRes);
        pane.add(total);
        pane.add(average);
        pane.add(avgApt);
        pane.add(above);
        pane.add(avgAbove);
        pane.add(below);
        pane.add(avgBelow);
        pane.add(apartment);
        pane.add(residents);
        pane.add(store);
        pane.add(quit);
        frame.setVisible(true);
    }
    public void actionPerformed(ActionEvent event)
    {
        final int BUILDING_SIZE = 10;
        final int MAX_OCCUPANTS = 20;
 
 
 
        int[] occupants = new int[BUILDING_SIZE];
 
        int aptNo = 0;
        occupants[aptNo] = 0;
        int sumOccupants = 0;
        double avgPer = 0.0;
        int noAbove = 0;
        int noBelow = 0;
        String whichButton;
        whichButton = event.getActionCommand();
 
        if (whichButton.equals("Store"))
        {
            String str = apartment.getText();
            int aptValue = Integer.parseInt(str);
            String str1 = residents.getText();
            int resValue = Integer.parseInt(str1);
 
            aptNo = aptValue;
            occupants[aptNo] = resValue;
            apartment.setText("");
            residents.setText("");
        }
 
        else if (whichButton.equals("Quit") || MAX_OCCUPANTS > 20)
        {
            for (aptNo = 0; aptNo < occupants.length; aptNo++)
                sumOccupants = sumOccupants + occupants[aptNo];
            avgPer = sumOccupants / aptNo;
            if (occupants[aptNo] > avgPer)
                noAbove++;
            if (occupants[aptNo] < avgPer)
                noBelow++;
 
        total.setText("" + sumOccupants);
        avgApt.setText("" + avgPer);
        avgAbove.setText("" + noAbove);
        avgBelow.setText("" + noBelow);
        apartment.setText("");
        residents.setText("");
        }
        frame.setVisible(true);
    }
    public static void main(String[] args)
    {
        Building5 building = new Building5();
    }
}
 

[jkmyoung]

(Repeat of above comment plus:)
In terms of style, you should be declaring your elements as class variables (you're mostly doing this), and setting them up in the constructor.


You're resetting the occupants everytime you click a button:
int[] occupants = new int[BUILDING_SIZE];
int[] occupants should be declared in the class variables section, and set up in the constructor.