Good coding

whitep8

Hi All,

Being new to java i was hoping for some input as to ensure im following best practice.

The following script is for some homework admittedly. It all works and outputs what i want, but to me it looks messy so i really want to know if im overdoing the code?

Thanks in advance

Expand|Select|Wrap|Line Numbers

 
/*

 * To change this template, choose Tools | Templates

 * and open the template in the editor.

 */
 
package weektwohomework;

// include your header
 
class CDDriver

{
 
    public static void main(String args[])

    {
 
                CD[] cdList = new CD[3];
 
                cdList[0] = new CD("Kaiser "," up the khazi ", 9.99);

        cdList[1] = new CD("Oasis "," morning glory ",3.99);

        cdList[2] = new CD("Bob Dylan "," Alreet Sunna ",6.99);
 
        System.out.println("Artist \t\tTitle\t\tCost");

        System.out.println("====================================");
 
                for (int i = 0; i < cdList.length; i++)

                System.out.println(cdList[i].getArtist() + " " + cdList[i].getTitle() + " " + cdList[i].getCost());

               // System.out.println(cd1.getArtist() + " " + cd1.getTitle() + " " + cd1.getCost());

                //System.out.println(cd2.getArtist() + " " + cd2.getTitle() + " " + cd2.getCost());

               // System.out.println(cd3.getArtist() + " " + cd3.getTitle() + " " + cd3.getCost());
 
                // set an integer for the highest price

                      double maxPrice = 0;
 
                        //loop through all records (the cdLists length) and increment by 1

                      for (int i=0; i<cdList.length; i++)
 
                          // if the items price which is being checked is higher than the

                          //current value of maxPrice,

                          if (cdList[i].getCost()>maxPrice)
 
                                //replace its value with that cds price

                          maxPrice = cdList[i].getCost();
 
                      // display max price to the screen

                      System.out.println("The highest price is: " + maxPrice);
 
                      // set an int to hold the total number of CDs that are counted and set to zero

                      int total = 0;
 
                      //for loop to work through list of cds

                      for( int j = 0; j < cdList.length;j++)
 
                            //add one to total for each item found

                          total = total + 1;
 
                      //output how many have been counted to screen

                      System.out.println("You have " + total + " cd's in your list");
 
                      //set variable for total price

                      double totalPrice = 0;
 
                    for ( int k = 0; k < cdList.length; k ++)
 
                        totalPrice = totalPrice + cdList[k].getCost();
 
                     System.out.println("The total value of all of your CD's is: " + totalPrice);
 
    }

}

myusernotyours

It's good that you are trying to learn about coding standard while learning the language. Most people don't.

A glance at your code tells me that it's time you discomposed your very long methods into a number of shorter ones that are a bit specialized. This allows for readability and more importantly reuse.

Also do not comment the obvious. Doing

Expand|Select|Wrap|Line Numbers

  // Add to total

total = total + 1;

does not say anything that we cannot tell immediately just by looking at the code.

There are many others but those do for now.
Happy coding!

Regards,

Alex.

r035198x

You can count the number of CDs on that rack at the same time as you are checking which one is the most expensive one. This will take you less time than going over the same rack twice.
Leaving you time on your hands to call ...

whitep8

so i could use the same for loop and have each function run concurrently?

r035198x

Don't forget the braces {} around the block of code you want repeating.

Good coding

re: Good coding

re: Good coding

re: Good coding

re: Good coding

Similar Java bytes

/bytes/development

/bytes/it

/bytes/about