adding a bool to a string

Hi All,
>
I'm trying to print boolean values and after I searched the entire web,
I couldn't find anything that does this =/ The code that I ended up using
is as follows:
>
string boolString(Object* obj_, size_t maxOutput_){
string string_;
>
for (size_t i=0; i<maxOutput_; i++){
>
if( sizeof(obj_->boolean(i)) == sizeof(bool) ){

if (obj_->boolean(i) == true)
string_ += "1";
else
string_ += "0";
}
}
>
return string_;
}
>
Is there any way to simplify this code?

I'm trying to print boolean values and after I searched the entire
web, I couldn't find anything that does this =/ The code that I
ended up using is as follows:
>
string boolString(Object* obj_, size_t maxOutput_){
string string_;
>
for (size_t i=0; i<maxOutput_; i++){
>
if( sizeof(obj_->boolean(i)) == sizeof(bool) ){

if (obj_->boolean(i) == true)
string_ += "1";
else
string_ += "0";

}
}
>
return string_;
}
>
Is there any way to simplify this code?

aaragon wrote:>
Why do you need to check the size? What does it give you?

>>
This could be written
>
string_ += (obj_->boolean(i) ? '1' : '0');
>
which I find a bit simpler.
>
Also, consider that you call 'boolean' member twice here (once to
check the size and the other to actually get the value); if the
function has side effects, calling it twice may not be what you
want.
>>
V
--
Please remove capital 'A's when replying by e-mail
I do not respond to top-posted replies, please don't ask

aaragon wrote:
>>
What is the above line supposed to do? What does obj_->boolean(i) return?
Note that sizeof is always computed at compile time.
>>
string boolString(Object* obj_, size_t maxOutput_){
stringstream stream_;
>
for (size_t i=0; i<maxOutput_; i++)
// depending on the return type of boolean(), you can remove the cast
stream_ << bool(obj_->boolean(i));
>
return stream_.str();
}

aaragon wrote:
>>
What is the above line supposed to do? What does obj_->boolean(i)
return? Note that sizeof is always computed at compile time.
>>
string boolString(Object* obj_, size_t maxOutput_){
stringstream stream_;
>
for (size_t i=0; i<maxOutput_; i++)
// depending on the return type of boolean(), you can remove the
cast stream_ << bool(obj_->boolean(i));
>
return stream_.str();
}

>
Victor Bazarov wrote:>
I need to check the size because the function may not return a bool but
an integer for example.
>

Victor Bazarov wrote:>
I need to check the size because the function may not return a bool
but an integer for example.

[..]

Consider that some locales do not have '1' or '0' as the default
for outputting a bool value. If the OP wanted '1' or '0', it should
probably be explicit.
>
And how is using a stringstream simpler (better) than, say,
>
for (size_t i=0; i<maxOutput_; i++)
string_ += (bool(obj_->boolean(i)) ? '1' : '0');
>
return string_;
>
?
>

V
--
Please remove capital 'A's when replying by e-mail
I do not respond to top-posted replies, please don't ask

"aaragon" <alejandro.aragon@gmail.comwrote in message
news:1163617470.334923.67870@k70g2000cwa.googlegro ups.com...>
And how do you know that a value is a bool just because it's the same
size as one?
>
Also, boolean() is your own function, so you should already know what
its return type is. It can't sometimes return a bool and other times
return an int. (Unless, I guess, if "boolean" isn't really a
function member of obj_ at all, but is instead a function pointer
which you assign elsewhere.)

>
Well, this definitely will work for booleans. But, the object I'm
working on, would also be a container for other values (say double,
integers) in which case boolean representation is no longer useful
(forget about the name boolean(i), it could be anything, like
value(i)). Therefore, the cast that you're using is not useful
anymore.

>
If it's a function pointer, the return value type is part of the type
of that pointer. C++ is strict in that regard. You cannot have return
value types change arbitrarily during run-time.
>

>
Sometimes boolean() may return an integer, so doing a cast to a boolean
is not a good idea.

This is the reason behind the check of the size of whatever type boolean()
returns.

I thought that the sream can automatically convert to 1 or 0 from a
boolean as
>
stream_ += boolean(i);