problem including file (intermediate)

Hi,

I wonder if someone can help me, I've set my web site up as follows:
There is a 'services' page that displays .html pages in a sub-dir when
specified in the URL. I need use the switch function as the code
following shows:


<?php if(isset($_GET['p']))
{
switch ($_GET['p'])
{
// include ('test.inc');
case "test": include "./services/test.html"; break;
case "2test2": include "./services/2test2.html"; break;
default:
}
}
else
{
echo "<p><br><br><B>Please choose a topic from the left</B></p>\n";
}
?>

Basically.. I want to use the include(test.inc) file which contains
the two lines of code following it. But I get an error:

Parse error: parse error, expecting `T_CASE' or `T_DEFAULT' or `'}''
in /home/rmgraphics/public_html/services.php on line 27
- which is the include page line and I've commented out for now

I need to use the test.inc file for the case lines because I want to
manage the list by opening the file direct.

This is a bit over my head now.. I'm sure someone knows a good
workaround!

Thanks in advance

FrobinRobin

FrobinRobin wrote:[color=blue]
> <?php if(isset($_GET['p']))
> {
> switch ($_GET['p'])
> {
> // include ('test.inc');
> case "test": include "./services/test.html"; break;[/color]
(snip)


You cannot have anything except "case ..." or "default ..." inside a
switch!

Try moving the switch to the included file

#v+
<?php
if (isset($_GET['p'])) {
include 'test.inc';
} else {
echo 'Choose from ...';
}
?>
#v-

and

#v+
<?php // test.inc
switch ($_GET['p']) {
case 'test': include './services/test.html'; break;
case '2test2': include './services/2test2.html'; break;
default:
}
?>
#v-
--
--= my mail box only accepts =--
--= Content-Type: text/plain =--
--= Size below 10001 bytes =--

Use an associative array instead:

test.php:
include("test.inc");
$path = @$topic_to_files[@$_GET['p']];
if($path) {
include($path);
}
else {
echo "<p><br><br><B>Please choose a topic from the left</B></p>\n";
}

test.inc:
$topic_to_files = array(
"page1" => "./services/page1.html",
"page2" => "./service/page2.html",
"page3" => "./service/page3.html"
);

Uzytkownik "FrobinRobin" <frobinrobin@hotmail.com> napisal w wiadomosci
news:2ecd35fd.0401161517.5625fb41@posting.google.c om...[color=blue]
> Hi,
>
> I wonder if someone can help me, I've set my web site up as follows:
> There is a 'services' page that displays .html pages in a sub-dir when
> specified in the URL. I need use the switch function as the code
> following shows:
>
>
> <?php if(isset($_GET['p']))
> {
> switch ($_GET['p'])
> {
> // include ('test.inc');
> case "test": include "./services/test.html"; break;
> case "2test2": include "./services/2test2.html"; break;
> default:
> }
> }
> else
> {
> echo "<p><br><br><B>Please choose a topic from the left</B></p>\n";
> }
> ?>
>
> Basically.. I want to use the include(test.inc) file which contains
> the two lines of code following it. But I get an error:
>
> Parse error: parse error, expecting `T_CASE' or `T_DEFAULT' or `'}''
> in /home/rmgraphics/public_html/services.php on line 27
> - which is the include page line and I've commented out for now
>
> I need to use the test.inc file for the case lines because I want to
> manage the list by opening the file direct.
>
> This is a bit over my head now.. I'm sure someone knows a good
> workaround!
>
> Thanks in advance
>
> FrobinRobin[/color]

Thanks ... I worked out the switch problem this morning when I thought
... I'll just put that in there.. and it worked! I like what you said
chung - because when I upload a html page - the script also adds a new
line to the ./test.inc - I thought this was the best way to acheive
what I want?
A manageaable list of files as they get uploaded which can act as a
list to other pages to access? I usually use mysql but thought I'd try
it this way - good fun this PHP

And by the way, use readfile() instead of include(). Since the files are
HTML, there's no need for PHP to parse it.

You should seriously consider changing how you store the file list. Using
PHP to write PHP code is a bad idea for more than one reason.

Uzytkownik "FrobinRobin" <frobinrobin@hotmail.com> napisal w wiadomosci
news:2ecd35fd.0401170352.25c16f6e@posting.google.c om...[color=blue]
> Thanks ... I worked out the switch problem this morning when I thought
> .. I'll just put that in there.. and it worked! I like what you said
> chung - because when I upload a html page - the script also adds a new
> line to the ./test.inc - I thought this was the best way to acheive
> what I want?
> A manageaable list of files as they get uploaded which can act as a
> list to other pages to access? I usually use mysql but thought I'd try
> it this way - good fun this PHP[/color]