web_design wrote:[color=blue]
> I put this together from some other scripts I am using on a site. I'm
> trying to make a better email hiding script. It isn't working. Also, it
> causes Internet Explorer 6 SP2 to block the script as "active content". :([/color]
There is little point in 'hiding' email addresses in web pages. Do a
search on "hide email address" and you will find many threads discussing
it. Here's one that's only a couple of weeks old:
<URL:http://groups-beta.google.com/group/news.admin.net-abuse.email/browse_frm/thread/52b865188d082c35/22ae192f3ff1a9ef?q=hide+email+address&rnum=4&hl=en #22ae192f3ff1a9ef>
It is generally accepted that a form is better than depending on the
user having an email client configured to respond to 'mailto:'.
[color=blue]
>
> The idea is that if the user doesn't have JavaScript enabled, they will see
> an image of the email address (that can't be read by email harvesting
> programs). If JavaScript is enabled, the image will be hidden and the
> javascript will generate the email address in an "mailto:" link text.
>
> <script language=javascript>[/color]
Language is depreciated, type is required:
<script type="text/javascript">
[color=blue]
> <!--[/color]
HTML comments inside script tags are completely unnecessary and possibly
harmful. Don't use them.
[color=blue]
> var name = "contact"
> var domain = "mysite.com"
> document.write("Email: " + name + "@" + domain) // this is going to be
> changed to a href=mailto: link...[/color]
Sufficient obfuscation may be:
document.write("Email: " + name + "@" + domain);
[color=blue]
>
> // hides email image below if JavaScript is enabled
> var obj;
> obj = document.getElementById("email");
> obj.style.display = "none";[/color]
Or:
if ( document.getElementById ) {
var obj = document.getElementById("email");
}
if ( obj && obj.style ) {
obj.style.display = "none";
}
But it will still fail because the element with id 'email' doesn't exist
yet. Put the script below the element and you'll have a better chance
of success. Also, the image should only be hidden if the entire script
works (see below).
[color=blue]
> //-->
> </script>
>
> <div id="email" style="display: inline;">
> <img src="images/email.gif" alt="Email address" />[/color]
Is this really XHTML? If not, use the HTML markup declaration close
delimiter (">") without a slash.
[color=blue]
> </div>[/color]
<script type="text/javascript">
if ( document.getElementById ) {
var obj = document.getElementById("email");
}
if ( obj && obj.style ) {
obj.style.display = "none";
// Replace with chosen obfuscation or whatever...
var name = "contact"
var domain = "mysite.com"
document.write("Email: " + name + "@" + domain)
}
</script>
--
Rob
Email hiding JavaScript not working :( 
