size_t and int comparison

for (int i=0;i < strlen(pathcmd);i++){//this line cause a warning

warning C4018: '<' : signed/unsigned mismatch

strlen returns a number of type 'size_t'. size_t is an unsigned type and
you are comparing it to an int, a signed type.

Two solutions to remove the warning:

1. Change the type of the variable 'i' to 'size_t'.
2. staic_cast i to "unsigned" type.

Which way is better in C++?

"tings" <tings668@hotmail.com> wrote in message
news:%RgEd.10483$c13.154@bgtnsc04-news.ops.worldnet.att.net...[color=blue]
> for (int i=0;i < strlen(pathcmd);i++){//this line cause a warning
>
> warning C4018: '<' : signed/unsigned mismatch
>
> strlen returns a number of type 'size_t'. size_t is an unsigned type and
> you are comparing it to an int, a signed type.
>
> Two solutions to remove the warning:
>
> 1. Change the type of the variable 'i' to 'size_t'.
> 2. staic_cast i to "unsigned" type.
>
> Which way is better in C++?[/color]

Change 'i' to type 'size_t'.

Or better yet, replace your char array 'pathcmd'
with a 'std::string' object, and write:

std::string pathcmd("whatever");
for(std::string::size_type i = 0; i < pathcmd.size(); ++i)
/* etc */

(if the code in your loop does not modify the string, you
might get a slight performance improvement by storing the
size before the loop and using that:

std::vector::size_type sz(pathcmd.size());
for(std::vector::size_type i = 0; i < sz; ++i)
/* etc */

-Mike
[color=blue]
>
>[/color]

"tings" <tings668@hotmail.com> wrote...[color=blue]
> for (int i=0;i < strlen(pathcmd);i++){//this line cause a warning
>
> warning C4018: '<' : signed/unsigned mismatch
>
> strlen returns a number of type 'size_t'. size_t is an unsigned type and
> you are comparing it to an int, a signed type.
>
> Two solutions to remove the warning:
>
> 1. Change the type of the variable 'i' to 'size_t'.
> 2. staic_cast i to "unsigned" type.[/color]

3. Ignore the warning.
[color=blue]
> Which way is better in C++?[/color]

It depends on how 'i' is used later. I prefer #3 myself.

Victor

"Mike Wahler" <mkwahler@mkwahler.net> wrote...[color=blue]
> [..]
> (if the code in your loop does not modify the string, you
> might get a slight performance improvement by storing the
> size before the loop and using that:
>
> std::vector::size_type sz(pathcmd.size());
> for(std::vector::size_type i = 0; i < sz; ++i)
> /* etc */[/color]

I personally prefer not to pollute scopes with unnecessary names,
so I'd write

for (std::string::size_type sz = pathcmd.size(), i = 0; i < sz; i++) {
...

But it often doesn't matter, probably.

V

"Victor Bazarov" <v.Abazarov@comAcast.net> wrote in message
[color=blue]
> 3. Ignore the warning.[/color]

You can use #pragma to avoid the warning, in MSVC at least.

"Victor Bazarov" <v.Abazarov@comAcast.net> wrote in message
news:F9OdnfhbNOT6A3zcRVn-pA@comcast.com...[color=blue]
> "Mike Wahler" <mkwahler@mkwahler.net> wrote...[color=green]
> > [..]
> > (if the code in your loop does not modify the string, you
> > might get a slight performance improvement by storing the
> > size before the loop and using that:
> >
> > std::vector::size_type sz(pathcmd.size());
> > for(std::vector::size_type i = 0; i < sz; ++i)
> > /* etc */[/color]
>
> I personally prefer not to pollute scopes with unnecessary names,[/color]

So I'm a litterbug. :-)
[color=blue]
> so I'd write
>
> for (std::string::size_type sz = pathcmd.size(), i = 0; i < sz; i++) {[/color]

Yes, that's probably better.
[color=blue]
> ...
>
> But it often doesn't matter, probably.[/color]

Agreed.

-Mike

> Two solutions to remove the warning:[color=blue]
>
> 1. Change the type of the variable 'i' to 'size_t'.
> 2. staic_cast i to "unsigned" type.[/color]

It's giving you a warning because strlen returns a size_t, which is
some unsigned type. You're comparing it to 'i', which is a (signed)
int, and comparing a signed to an unsigned can cause rather strange
results (since each type can normally represent some values the other
can't).

It won't warn you, but you're re-computing the length of the string
every time through the loop. This makes your loop O(N * N) instead of
O(N) -- ugly unless your string is _really_ short. I'd use something
like:

for (int i=0; pathcmd[i] != '\0'; i++) {

Or, perhaps just switch to using an std::string, and while you're at
it, you might want to quit using an explicit loop and replace it with
an algorithm instead:

std::for_each(pathcmd.begin(), pathcmd.end(), do_whatever);

and possibly use boost::lambda to create do_whatever on the fly as
well...

--
Later,
Jerry.

The universe is a figment of its own imagination.

"tings" <tings668@hotmail.com> wrote in message
news:%RgEd.10483$c13.154@bgtnsc04-news.ops.worldnet.att.net...[color=blue]
> for (int i=0;i < strlen(pathcmd);i++){//this line cause a warning
>
> warning C4018: '<' : signed/unsigned mismatch
>
> strlen returns a number of type 'size_t'. size_t is an unsigned type and
> you are comparing it to an int, a signed type.
>
> Two solutions to remove the warning:
>
> 1. Change the type of the variable 'i' to 'size_t'.
> 2. staic_cast i to "unsigned" type.
>
> Which way is better in C++?
>[/color]
(2) is much better. Mixing up 'int' and 'size_t' is a sure way to write
non-portable code. For example, for most 64-bit C++ compilers, size_t is 64
bits whereas int is 32 bits. It's unlikely you would have a string longer
than 4Gb characters even on a 64-bit machine; but if you did, the code would
break.

David Crocker

tings wrote:[color=blue]
> for (int i=0;i < strlen(pathcmd);i++){//this line cause a warning
>
> warning C4018: '<' : signed/unsigned mismatch
>
> strlen returns a number of type 'size_t'. size_t is an unsigned type and
> you are comparing it to an int, a signed type.
>
> Two solutions to remove the warning:
>
> 1. Change the type of the variable 'i' to 'size_t'.
> 2. staic_cast i to "unsigned" type.
>
> Which way is better in C++?
>
>[/color]
I'd use an unsigned (or size_t) variable for i.

However, I wouldn't write the above anyhow. You are computing
strlen(pathcmd) over and over again. Depending what you are
doing with the rest of the loop, there are better ways to count
than that...

"David Crocker" <dcrocker@eschertech.ccoomm> for some reason
wrote:
[color=blue]
> "tings" <tings668@hotmail.com> wrote in message
> news:%RgEd.10483$c13.154@bgtnsc04-news.ops.worldnet.att.net...[color=green]
>> for (int i=0;i < strlen(pathcmd);i++){//this line cause a
>> warning
>>
>> warning C4018: '<' : signed/unsigned mismatch
>>
>> strlen returns a number of type 'size_t'. size_t is an unsigned
>> type and you are comparing it to an int, a signed type.
>>
>> Two solutions to remove the warning:
>>
>> 1. Change the type of the variable 'i' to 'size_t'.
>> 2. staic_cast i to "unsigned" type.
>>
>> Which way is better in C++?
>>[/color]
> (2) is much better. Mixing up 'int' and 'size_t' is a sure way
> to write non-portable code. For example, for most 64-bit C++
> compilers, size_t is 64 bits whereas int is 32 bits. It's
> unlikely you would have a string longer than 4Gb characters even
> on a 64-bit machine; but if you did, the code would break.
>
> David Crocker
>
>
>[/color]

erm, then why are you recommending casting an int?? Or is that a
typo?

KTC

--
Experience is a good school but the fees are high.
- Heinrich Heine

"KTC" <me@here.com> wrote in message
news:Xns95DABBEE73AFktchaninfonews@217.158.240.10. ..[color=blue]
> "David Crocker" <dcrocker@eschertech.ccoomm> for some reason
> wrote:
>[color=green]
> > "tings" <tings668@hotmail.com> wrote in message
> > news:%RgEd.10483$c13.154@bgtnsc04-news.ops.worldnet.att.net...[color=darkred]
> >> for (int i=0;i < strlen(pathcmd);i++){//this line cause a
> >> warning
> >>
> >> warning C4018: '<' : signed/unsigned mismatch
> >>
> >> strlen returns a number of type 'size_t'. size_t is an unsigned
> >> type and you are comparing it to an int, a signed type.
> >>
> >> Two solutions to remove the warning:
> >>
> >> 1. Change the type of the variable 'i' to 'size_t'.
> >> 2. staic_cast i to "unsigned" type.
> >>
> >> Which way is better in C++?
> >>[/color]
> > (2) is much better. Mixing up 'int' and 'size_t' is a sure way
> > to write non-portable code. For example, for most 64-bit C++
> > compilers, size_t is 64 bits whereas int is 32 bits. It's
> > unlikely you would have a string longer than 4Gb characters even
> > on a 64-bit machine; but if you did, the code would break.
> >
> > David Crocker
> >
> >
> >[/color]
>
> erm, then why are you recommending casting an int??[/color]

He's recommending to cast the int to an unsigned type,
so that it can be safely compared against another unsigned
object.
[color=blue]
>Or is that a
> typo?[/color]

I don't think so.

-Mike

tings wrote:
[color=blue]
> for (int i=0;i < strlen(pathcmd);i++){//this line cause a warning
>
> warning C4018: '<' : signed/unsigned mismatch
>
> strlen returns a number of type 'size_t'. size_t is an unsigned type and
> you are comparing it to an int, a signed type.
>
> Two solutions to remove the warning:
>
> 1. Change the type of the variable 'i' to 'size_t'.
> 2. staic_cast i to "unsigned" type.
>
> Which way is better in C++?[/color]



size_t. Since strlen() returns size_t which usually fits larger positive
integer values, why using int for i?




--
Ioannis Vranos

http://www23.brinkster.com/noicys

"Mike Wahler" <mkwahler@mkwahler.net> for some reason wrote:
[color=blue][color=green][color=darkred]
>> >>
>> > (2) is much better. Mixing up 'int' and 'size_t' is a sure[/color][/color][/color]
way[color=blue][color=green][color=darkred]
>> > to write non-portable code. For example, for most 64-bit C++
>> > compilers, size_t is 64 bits whereas int is 32 bits. It's
>> > unlikely you would have a string longer than 4Gb characters[/color][/color][/color]
even[color=blue][color=green][color=darkred]
>> > on a 64-bit machine; but if you did, the code would break.
>> >
>> > David Crocker
>> >
>> >
>> >[/color]
>>
>> erm, then why are you recommending casting an int??[/color]
>
> He's recommending to cast the int to an unsigned type,
> so that it can be safely compared against another unsigned
> object.
>[color=green]
>>Or is that a
>> typo?[/color]
>
> I don't think so.
>
> -Mike
>
>[/color]

Hmmm, okay. If one's worrying about the possible implementation's
size difference of the different types, then shouldn't one be
recommending to use the same type rather than cast? Namely, size_t
in this case...

Just wondering.

KTC

--
Experience is a good school but the fees are high.
- Heinrich Heine

"KTC" <me@here.com> wrote in message
news:Xns95DA2CEAF576Cktchaninfonews@217.158.240.23 ...[color=blue]
> "Mike Wahler" <mkwahler@mkwahler.net> for some reason wrote:
>[color=green][color=darkred]
> >> >>
> >> > (2) is much better. Mixing up 'int' and 'size_t' is a sure[/color][/color]
> way[color=green][color=darkred]
> >> > to write non-portable code. For example, for most 64-bit C++
> >> > compilers, size_t is 64 bits whereas int is 32 bits. It's
> >> > unlikely you would have a string longer than 4Gb characters[/color][/color]
> even[color=green][color=darkred]
> >> > on a 64-bit machine; but if you did, the code would break.
> >> >
> >> > David Crocker
> >> >
> >> >
> >> >
> >>
> >> erm, then why are you recommending casting an int??[/color]
> >
> > He's recommending to cast the int to an unsigned type,
> > so that it can be safely compared against another unsigned
> > object.
> >[color=darkred]
> >>Or is that a
> >> typo?[/color]
> >
> > I don't think so.
> >
> > -Mike
> >
> >[/color]
>
> Hmmm, okay. If one's worrying about the possible implementation's
> size difference of the different types, then shouldn't one be
> recommending to use the same type rather than cast? Namely, size_t
> in this case...[/color]

Yes, that's imo the best solution. But as long as the values
being used fit in the actual type being used ('int' in this
case), the cast will do the trick.

-Mike

KTC wrote:
[color=blue]
> Hmmm, okay. If one's worrying about the possible implementation's
> size difference of the different types, then shouldn't one be
> recommending to use the same type rather than cast? Namely, size_t
> in this case...
>
> Just wondering.[/color]


Don't let those guys to confuse you. They just want to look cool. :-)


Use size_t.




--
Ioannis Vranos

http://www23.brinkster.com/noicys